X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=expense_delete.php;h=d5eccf79d866984fb924ec95e131a009d731a3d0;hb=6289820a41e9ab79635294c1d6a22583aacf6e77;hp=42a6add80ca8e0a10558255fa3dd40bfc413084a;hpb=4dcb88a76a3de466ee6116ae0852f53ba2b259a5;p=timetracker.git

diff --git a/expense_delete.php b/expense_delete.php
index 42a6add8..d5eccf79 100644
--- a/expense_delete.php
+++ b/expense_delete.php
@@ -40,14 +40,14 @@ if (!$user->isPluginEnabled('ex')) {
   header('Location: feature_disabled.php');
   exit();
 }
-
-
-
-$cl_id = $request->getParameter('id');
-$expense_item = ttExpenseHelper::getItem($cl_id, $user->getActiveUser());
-
-// Prohibit deleting invoiced records.
-if ($expense_item['invoice_id']) die($i18n->get('error.sys'));
+$cl_id = (int)$request->getParameter('id');
+// Get the expense item we are deleting.
+$expense_item = ttExpenseHelper::getItem($cl_id);
+if (!$expense_item || $expense_item['invoice_id']) {
+  // Prohibit deleting not ours or invoiced items.
+  header('Location: access_denied.php');
+  exit();
+}
 
 if ($request->isPost()) {
   if ($request->getParameter('delete_button')) { // Delete button pressed.
@@ -59,7 +59,7 @@ if ($request->isPost()) {
 
     if ($err->no()) {
       // Mark the record as deleted.
-      if (ttExpenseHelper::markDeleted($cl_id, $user->getActiveUser())) {
+      if (ttExpenseHelper::markDeleted($cl_id)) {
         header('Location: expenses.php');
         exit();
       } else