X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=mobile%2Fexpense_delete.php;h=48e74dc0e3394b6bb82a87cb1db441508d995dbf;hb=67e827dacf08d8a55dff9118c82dd964f5da12c1;hp=cca61b7c1f32e45011b84e6caa09c6e657f59114;hpb=dd2ba64b1b4aaddacec2b9f6763c0ed7a35efc3b;p=timetracker.git diff --git a/mobile/expense_delete.php b/mobile/expense_delete.php index cca61b7c..48e74dc0 100644 --- a/mobile/expense_delete.php +++ b/mobile/expense_delete.php @@ -40,12 +40,15 @@ if (!$user->isPluginEnabled('ex')) { header('Location: feature_disabled.php'); exit(); } - -$cl_id = $request->getParameter('id'); -$expense_item = ttExpenseHelper::getItem($cl_id, $user->getActiveUser()); - -// Prohibit deleting invoiced records. -if ($expense_item['invoice_id']) die($i18n->get('error.sys')); +$cl_id = (int)$request->getParameter('id'); +// Get the expense item we are deleting. +$expense_item = ttExpenseHelper::getItem($cl_id); +if (!$expense_item || $expense_item['approved'] || $expense_item['invoice_id']) { + // Prohibit deleting not ours, approved, or invoiced items. + header('Location: access_denied.php'); + exit(); +} +// End of access checks. if ($request->isPost()) { if ($request->getParameter('delete_button')) { // Delete button pressed. @@ -57,7 +60,7 @@ if ($request->isPost()) { if ($err->no()) { // Mark the record as deleted. - if (ttExpenseHelper::markDeleted($cl_id, $user->getActiveUser())) { + if (ttExpenseHelper::markDeleted($cl_id)) { header('Location: expenses.php'); exit(); } else @@ -75,8 +78,11 @@ $form->addInput(array('type'=>'hidden','name'=>'id','value'=>$cl_id)); $form->addInput(array('type'=>'submit','name'=>'delete_button','value'=>$i18n->get('label.delete'))); $form->addInput(array('type'=>'submit','name'=>'cancel_button','value'=>$i18n->get('button.cancel'))); -$smarty->assign('expense_item', $expense_item); +$show_project = MODE_PROJECTS == $user->getTrackingMode() || MODE_PROJECTS_AND_TASKS == $user->getTrackingMode(); + $smarty->assign('forms', array($form->getName() => $form->toArray())); +$smarty->assign('expense_item', $expense_item); +$smarty->assign('show_project', $show_project); $smarty->assign('title', $i18n->get('title.delete_expense')); $smarty->assign('content_page_name', 'mobile/expense_delete.tpl'); $smarty->display('mobile/index.tpl');