X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=mobile%2Fexpense_delete.php;h=c0fa032eba9534f364eb6b66641f3f1802f85009;hb=45a530c33fdd7ab2ccd1905c24a371c94e17eac5;hp=cca61b7c1f32e45011b84e6caa09c6e657f59114;hpb=dd2ba64b1b4aaddacec2b9f6763c0ed7a35efc3b;p=timetracker.git diff --git a/mobile/expense_delete.php b/mobile/expense_delete.php index cca61b7c..c0fa032e 100644 --- a/mobile/expense_delete.php +++ b/mobile/expense_delete.php @@ -40,12 +40,14 @@ if (!$user->isPluginEnabled('ex')) { header('Location: feature_disabled.php'); exit(); } - -$cl_id = $request->getParameter('id'); -$expense_item = ttExpenseHelper::getItem($cl_id, $user->getActiveUser()); - -// Prohibit deleting invoiced records. -if ($expense_item['invoice_id']) die($i18n->get('error.sys')); +$cl_id = (int)$request->getParameter('id'); +// Get the expense item we are deleting. +$expense_item = ttExpenseHelper::getItem($cl_id, $user->getUser()); +if (!$expense_item || $expense_item['invoice_id']) { + // Prohibit deleting not ours or invoiced items. + header('Location: access_denied.php'); + exit(); +} if ($request->isPost()) { if ($request->getParameter('delete_button')) { // Delete button pressed. @@ -57,7 +59,7 @@ if ($request->isPost()) { if ($err->no()) { // Mark the record as deleted. - if (ttExpenseHelper::markDeleted($cl_id, $user->getActiveUser())) { + if (ttExpenseHelper::markDeleted($cl_id, $user->getUser())) { header('Location: expenses.php'); exit(); } else