X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=reports.php;h=efbf96421e09de550036744f212af67a1c090339;hb=1e7092b2a85592240048d9622a6f619aa2a7c68a;hp=31028f2f29031bc7c0707133694e1dccea8cac89;hpb=5403806f9c5e87add5a1594835018125a5ed0b0b;p=timetracker.git

diff --git a/reports.php b/reports.php
index 31028f2f..efbf9642 100644
--- a/reports.php
+++ b/reports.php
@@ -149,7 +149,7 @@ if ($user->can('view_reports') || $user->can('view_all_reports') || $user->isCli
   // Prepare user and assigned projects arrays.
   if ($user->can('view_reports') || $user->can('view_all_reports')) {
     $max_rank = $user->rank-1;
-    if ($user->can('view_all_reports')) $max_rank = 512;
+    if ($user->can('view_all_reports')) $max_rank = MAX_RANK;
     if ($user->can('view_own_reports'))
       $options = array('max_rank'=>$max_rank,'include_self'=>true);
     else
@@ -298,7 +298,7 @@ if ($request->isPost()) {
     if (!ttValidString($bean->getAttribute('new_fav_report'))) $err->add($i18n->get('error.field'), $i18n->get('form.reports.save_as_favorite'));
 
     if ($err->no()) {
-      $id = ttFavReportHelper::saveReport($user->id, $bean);
+      $id = ttFavReportHelper::saveReport($user->id, $bean); // TODO: review "on behalf" situations (both user and group), redesign if needed.
       if (!$id)
         $err->add($i18n->get('error.db'));
       if ($err->no()) {