X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=role_add.php;h=bd9f3e46f12074a87715cf826a6d148c3f06821d;hb=fdaf50116c208e78b6c4de6e6fe263541163c4af;hp=71220089e8978bd8de3254a51cd9bec8299f705d;hpb=ecbf1ecf19bfeb85794717fc7a6deb7ecc8c5f58;p=timetracker.git

diff --git a/role_add.php b/role_add.php
index 71220089..bd9f3e46 100644
--- a/role_add.php
+++ b/role_add.php
@@ -32,7 +32,7 @@ import('ttTeamHelper');
 import('ttRoleHelper');
 
 // Access check.
-if (!ttAccessCheck(right_manage_team)) {
+if (!ttAccessAllowed('manage_roles')) {
   header('Location: access_denied.php');
   exit();
 }
@@ -46,8 +46,7 @@ if ($request->isPost()) {
 $form = new Form('roleForm');
 $form->addInput(array('type'=>'text','maxlength'=>'100','name'=>'name','style'=>'width: 250px;','value'=>$cl_name));
 $form->addInput(array('type'=>'textarea','name'=>'description','style'=>'width: 250px; height: 40px;','value'=>$cl_description));
-for ($i = 0; $i < $user->role; $i++) {
-  $existing_role_name = null;
+for ($i = 0; $i < $user->rank; $i++) {
   $rank_data[] = $i;
 }
 $form->addInput(array('type'=>'combobox','name'=>'rank','data'=>$rank_data));
@@ -59,14 +58,15 @@ if ($request->isPost()) {
   if (!ttValidString($cl_description, true)) $err->add($i18n->getKey('error.field'), $i18n->getKey('label.description'));
 
   if ($err->no()) {
-    $existing_role = ttRoleHelper::getRoleByRank($cl_rank);
+    $existing_role = ttRoleHelper::getRoleByRank($cl_rank, $user->team_id);
     if (!$existing_role) {
-        // Update role information.
+        // Insert a role with default user rights.
         if (ttRoleHelper::insert(array(
           'team_id' => $user->team_id,
           'name' => $cl_name,
           'rank' => $cl_rank,
           'description' => $cl_description,
+          'rights' => 'track_own_time,track_own_expenses,view_own_reports,view_own_charts,manage_own_settings,view_users', // Default user rights.
           'status' => ACTIVE))) {
           header('Location: roles.php');
           exit();