X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=t%2F002goodperl.t;h=1f3a611d850b82ee3c79be992908b0c74fda8087;hb=1ef85bf93b36a4d3c868582f7984cacc0a22d639;hp=75a378c1e85eed5b4a89bab93a9cee7caeb9e4e3;hpb=f6e8c87bc23cb8b31a554ce89af51d2c3b0a5efd;p=kivitendo-erp.git diff --git a/t/002goodperl.t b/t/002goodperl.t index 75a378c1e..1f3a611d8 100644 --- a/t/002goodperl.t +++ b/t/002goodperl.t @@ -106,20 +106,23 @@ foreach my $file (@testitems) { # note, the html checker is not really thorough. # in particular it will not find standard tags with parameters. -# the estimate wether a file is dirty or not is still pretty helpful, as it will catch most of the closing tags. +# the estimate whether a file is dirty or not is still pretty helpful, as it will catch most of the closing tags. # if you are in doubt about a specific file, you still have to check it manually. my $tags = qr/b|i|u|h[1-6]|a href.*|input|form|br|textarea|table|tr|td|th|body|head|html|p|button|select|option|script/; +my $todo_files_re = qr{^bin/mozilla/ic\.pl$}; foreach my $file (@testitems) { my $found_html_count = 0; my $found_html = ''; $file =~ s/\s.*$//; # nuke everything after the first space (#comment) + next if (!$file); # skip null entries if (! open (FILE, $file)) { ok(0,"could not open $file --WARNING"); next; } while (my $file_line = ) { - if ($file_line =~ m/(<\/?$tags>)/) { + last if $file_line =~ /^__END__/; + if ($file_line =~ m/(<\/?$tags>)/o) { $found_html_count++; $found_html .= $1; } @@ -128,11 +131,17 @@ foreach my $file (@testitems) { if (!$found_html_count) { ok(1,"$file does not contain HTML"); } elsif ($found_html_count < 50) { - TODO: { local $TODO = q(Even slow amounts should go away....); + TODO: { local $TODO = q(Even little amounts of HTML should go away....); ok(0,"$file contains at least $found_html_count html tags."); } } else { + if ($file =~ $todo_files_re) { + TODO: { local $TODO = q(This file is known to have lots of old cruft.); + ok(0,"$file contains at least $found_html_count html tags."); + } + } else { ok(0,"$file contains at least $found_html_count html tags."); + } } }