X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=t%2F002goodperl.t;h=1f3a611d850b82ee3c79be992908b0c74fda8087;hb=4493d1eb7845b7eba868f0a16ec2e623dcf1d591;hp=d80d9eea31eae67840cbe2eda253cf1439dcb4ef;hpb=b93a2d44c5725d71a222a067e2b90cb0e602d76e;p=kivitendo-erp.git diff --git a/t/002goodperl.t b/t/002goodperl.t index d80d9eea3..1f3a611d8 100644 --- a/t/002goodperl.t +++ b/t/002goodperl.t @@ -82,8 +82,6 @@ foreach my $file (@testitems) { } foreach my $file (@testitems) { - local $TODO; - $TODO = 'schema updates are not required to be strict now' if $file =~ m{^sql/Pg-upgrade2}; my $found_use_strict = 0; $file =~ s/\s.*$//; # nuke everything after the first space (#comment) next if (!$file); # skip null entries @@ -108,13 +106,15 @@ foreach my $file (@testitems) { # note, the html checker is not really thorough. # in particular it will not find standard tags with parameters. -# the estimate wether a file is dirty or not is still pretty helpful, as it will catch most of the closing tags. +# the estimate whether a file is dirty or not is still pretty helpful, as it will catch most of the closing tags. # if you are in doubt about a specific file, you still have to check it manually. my $tags = qr/b|i|u|h[1-6]|a href.*|input|form|br|textarea|table|tr|td|th|body|head|html|p|button|select|option|script/; +my $todo_files_re = qr{^bin/mozilla/ic\.pl$}; foreach my $file (@testitems) { my $found_html_count = 0; my $found_html = ''; $file =~ s/\s.*$//; # nuke everything after the first space (#comment) + next if (!$file); # skip null entries if (! open (FILE, $file)) { ok(0,"could not open $file --WARNING"); @@ -135,7 +135,13 @@ foreach my $file (@testitems) { ok(0,"$file contains at least $found_html_count html tags."); } } else { + if ($file =~ $todo_files_re) { + TODO: { local $TODO = q(This file is known to have lots of old cruft.); + ok(0,"$file contains at least $found_html_count html tags."); + } + } else { ok(0,"$file contains at least $found_html_count html tags."); + } } }