X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=t%2Fdb_helper%2Fprice_tax_calculator.t;h=6caae1d7c3616d4a2dfd8f34eebae1703d9b35b4;hb=16d5a584a54b10a4a8cbd85d4bfb09836abb78d7;hp=53135a2f100e463bd43fcde65455a93dcb993ef4;hpb=0ff29f0620d5dd02242682778d8ea15b030da3e8;p=kivitendo-erp.git diff --git a/t/db_helper/price_tax_calculator.t b/t/db_helper/price_tax_calculator.t index 53135a2f1..6caae1d7c 100644 --- a/t/db_helper/price_tax_calculator.t +++ b/t/db_helper/price_tax_calculator.t @@ -10,7 +10,7 @@ use Data::Dumper; use List::MoreUtils qw(uniq); use Support::TestSetup; use Test::Exception; -use SL::Dev::ALL; +use SL::Dev::ALL qw(:ALL); use SL::DB::Buchungsgruppe; use SL::DB::Currency; @@ -49,14 +49,14 @@ sub reset_state { $tax7 = SL::DB::Manager::Tax->find_by(taxkey => 2, rate => 0.07) || croak "No tax for 7\%"; $taxzone = SL::DB::Manager::TaxZone->find_by( description => 'Inland') || croak "No taxzone"; - $customer = SL::Dev::CustomerVendor::create_customer( + $customer = new_customer( name => 'Test Customer', taxzone_id => $taxzone->id, %{ $params{customer} } )->save; @parts = (); - push @parts, SL::Dev::Part::create_part( + push @parts, new_part( partnumber => 'T4254', description => 'Fourty-two fifty-four', lastcost => 1.93, @@ -66,7 +66,7 @@ sub reset_state { %{ $params{part1} } )->save; - push @parts, SL::Dev::Part::create_part( + push @parts, new_part( partnumber => 'T0815', description => 'Zero EIGHT fifteeN @ 7%', lastcost => 5.473, @@ -76,7 +76,7 @@ sub reset_state { %{ $params{part2} } )->save; - push @parts, SL::Dev::Part::create_part( + push @parts, new_part( partnumber => 'T888', description => 'Triple 8', lastcost => 0, @@ -91,7 +91,7 @@ sub reset_state { sub new_invoice { my %params = @_; - return SL::Dev::Record::create_sales_invoice( + return create_sales_invoice( taxzone_id => $taxzone->id, %params, ); @@ -102,7 +102,7 @@ sub new_item { my $part = delete($params{part}) || $parts[0]; - return SL::Dev::Record::create_invoice_item( + return create_invoice_item( part => $part, %params, ); @@ -269,45 +269,35 @@ sub test_default_invoice_three_items_sellprice_rounding_discount() { my %taxkeys = map { ($_->id => $_->get_taxkey(date => DateTime->today_local, is_sales => 1, taxzone => $invoice->taxzone_id)) } uniq map { $_->part } ($item1, $item2, $item3); - # this is how price_tax_calculator is implemented. It differs from - # the way sales_order / invoice - forms are calculating: - # linetotal = sellprice 5.55 * qty 1 * (1 - 0.05) = 5.2725; rounded 5.27 - # linetotal = sellprice 5.50 * qty 1 * (1 - 0.05) = 5.225 rounded 5.23 - # linetotal = sellprice 5.00 * qty 1 * (1 - 0.05) = 4.75; rounded 4.75 - # ... - # item 1: # discount = sellprice 5.55 * discount (0.05) = 0.2775; rounded 0.28 - # sellprice = sellprice 5.55 - discount 0.28 = 5.27; rounded 5.27 - # linetotal = sellprice 5.27 * qty 1 = 5.27; rounded 5.27 + # linetotal = sellprice 5.55 * (1 - discount 0.05) * qty 1 = 5.2725; rounded 5.27 # 19%(5.27) = 1.0013; rounded = 1.00 # total rounded = 6.27 # lastcost 1.93 * qty 1 = 1.93; rounded 1.93 - # line marge_total = 3.34 + # line marge_total = 5.27 - 1.93 = 3.34 # line marge_percent = 63.3776091081594 # item 2: # discount = sellprice 5.50 * discount 0.05 = 0.275; rounded 0.28 - # sellprice = sellprice 5.50 - discount 0.28 = 5.22; rounded 5.22 - # linetotal = sellprice 5.22 * qty 1 = 5.22; rounded 5.22 - # 19%(5.22) = 0.9918; rounded = 0.99 - # total rounded = 6.21 + # linetotal = sellprice 5.50 * (1 - discount 0.05) * qty 1 = 5.225; rounded 5.23 + # 19%(5.23) = .99370; rounded = 0.99 + # total rounded = 6.22 # lastcost 1.93 * qty 1 = 1.93; rounded 1.93 - # line marge_total = 5.22 - 1.93 = 3.29 - # line marge_percent = 3.29/5.22 = 0.630268199233716 + # line marge_total = 5.23 - 1.93 = 3.30 + # line marge_percent = 3.30/5.23 = 0.630975143403442 # item 3: - # discount = sellprice 5.00 * discount 0.25 = 0.25; rounded 0.25 - # sellprice = sellprice 5.00 - discount 0.25 = 4.75; rounded 4.75 - # linetotal = sellprice 4.75 * qty 1 = 4.75; rounded 4.75 + # discount = sellprice 5.00 * discount 0.05 = 0.05 = 0.25; rounded 0.25 + # linetotal = sellprice 5.00 (1 - discount 0.05) * qty 1 = 4.75; rounded 4.75 # 19%(4.75) = 0.9025; rounded = 0.90 # total rounded = 5.65 # lastcost 1.93 * qty 1 = 1.93; rounded 1.93 - # line marge_total = 2.82 - # line marge_percent = 59.3684210526316 + # line marge_total = 4.75 - 1.93 = 2.82 + # line marge_percent = 2.82/4.75 = 59.3684210526316 my $title = 'default invoice, three items, sellprice, rounding, discount'; my %data = $invoice->calculate_prices_and_taxes; @@ -316,29 +306,29 @@ sub test_default_invoice_three_items_sellprice_rounding_discount() { is($item1->marge_percent, 63.3776091081594, "${title}: item1 marge_percent"); is($item1->marge_price_factor, 1, "${title}: item1 marge_price_factor"); - is($item2->marge_total, 3.29, "${title}: item2 marge_total"); - is($item2->marge_percent, 63.0268199233716, "${title}: item2 marge_percent"); + is($item2->marge_total, 3.30, "${title}: item2 marge_total"); + is($item2->marge_percent, 63.0975143403442, "${title}: item2 marge_percent"); is($item2->marge_price_factor, 1, "${title}: item2 marge_price_factor"); is($item3->marge_total, 2.82, "${title}: item3 marge_total"); is($item3->marge_percent, 59.3684210526316, "${title}: item3 marge_percent"); is($item3->marge_price_factor, 1, "${title}: item3 marge_price_factor"); - is($invoice->netamount, 5.27 + 5.22 + 4.75, "${title}: netamount"); + is($invoice->netamount, 5.27 + 5.23 + 4.75, "${title}: netamount"); - # 6.27 + 6.21 + 5.65 = 18.13 - # 1.19*(5.27 + 5.22 + 4.75) = 18.1356; rounded 18.14 - #is($invoice->amount, 6.27 + 6.21 + 5.65, "${title}: amount"); - is($invoice->amount, 18.14, "${title}: amount"); + # 6.27 + 6.22 + 5.65 = 18.14 + # 1.19*(5.27 + 5.23 + 4.75) = 18.1475; rounded 18.15 + #is($invoice->amount, 6.27 + 6.22 + 5.65, "${title}: amount"); + is($invoice->amount, 18.15, "${title}: amount"); - is($invoice->marge_total, 3.34 + 3.29 + 2.82, "${title}: marge_total"); - is($invoice->marge_percent, 62.007874015748, "${title}: marge_percent"); + is($invoice->marge_total, 3.34 + 3.30 + 2.82, "${title}: marge_total"); + is($invoice->marge_percent, 62.0327868852459, "${title}: marge_percent"); is_deeply(\%data, { allocated => {}, amounts => { $buchungsgruppe->income_accno_id($taxzone) => { - amount => 15.24, + amount => 15.25, tax_id => $tax->id, taxkey => 3, }, @@ -358,10 +348,10 @@ sub test_default_invoice_three_items_sellprice_rounding_discount() { tax_amount => 1.0013, taxkey_id => $taxkeys{$item1->parts_id}->id, }, - { linetotal => 5.22, + { linetotal => 5.23, linetotal_cost => 1.93, - sellprice => 5.22, - tax_amount => 0.9918, + sellprice => 5.23, + tax_amount => 0.9937, taxkey_id => $taxkeys{$item2->parts_id}->id, }, { linetotal => 4.75, @@ -386,35 +376,27 @@ sub test_default_invoice_one_item_19_tax_not_included_rounding_discount() { my %taxkeys = map { ($_->id => $_->get_taxkey(date => DateTime->today_local, is_sales => 1, taxzone => $invoice->taxzone_id)) } uniq map { $_->part } ($item); - # PTC and ar form calculate linetotal differently: # 6 parts for 0.60 with 3% discount # - # ar form: # linetotal = sellprice 0.60 * qty 6 * discount (1 - 0.03) = 3.492 rounded 3.49 # total = 3.49 + 0.66 = 4.15 # - # PTC: - # discount = sellprice 0.60 * discount (0.03) = 0.018; rounded 0.02 - # sellprice = sellprice 0.60 - discount 0.02 = 0.58 - # linetotal = sellprice 0.58 * qty 6 = 3.48 - # 19%(3.48) = 0.6612; rounded = 0.66 - # total rounded = 3.48 + 0.66 = 4.14 my $title = 'default invoice, one item, sellprice, rounding, discount'; my %data = $invoice->calculate_prices_and_taxes; - is($invoice->netamount, 3.48, "${title}: netamount"); + is($invoice->netamount, 3.49, "${title}: netamount"); - is($invoice->amount, 4.14, "${title}: amount"); + is($invoice->amount, 4.15, "${title}: amount"); - is($invoice->marge_total, 3.48, "${title}: marge_total"); + is($invoice->marge_total, 3.49, "${title}: marge_total"); is($invoice->marge_percent, 100, "${title}: marge_percent"); is_deeply(\%data, { allocated => {}, amounts => { $buchungsgruppe->income_accno_id($taxzone) => { - amount => 3.48, + amount => 3.49, tax_id => $tax->id, taxkey => 3, }, @@ -428,10 +410,60 @@ sub test_default_invoice_one_item_19_tax_not_included_rounding_discount() { $tax->chart_id => 0.66, }, items => [ - { linetotal => 3.48, + { linetotal => 3.49, linetotal_cost => 0, sellprice => 0.58, - tax_amount => 0.6612, + tax_amount => 0.6631, + taxkey_id => $taxkeys{$item->parts_id}->id, + }, + ], + rounding => 0, + }, "${title}: calculated data"); +} + +sub test_default_invoice_one_item_19_tax_not_included_rounding_discount_huge_qty() { + reset_state(); + + my $item = new_item(qty => 100000, part => $parts[2], discount => 0.03, sellprice => 0.10); + my $invoice = new_invoice( + taxincluded => 0, + invoiceitems => [ $item ], + ); + + my %taxkeys = map { ($_->id => $_->get_taxkey(date => DateTime->today_local, is_sales => 1, taxzone => $invoice->taxzone_id)) } uniq map { $_->part } ($item); + + my $title = 'default invoice, one item, 19% tax not included, rounding, discount, huge qty'; + my %data = $invoice->calculate_prices_and_taxes; + + is($invoice->netamount, 9700, "${title}: netamount"); + + is($invoice->amount, 11543, "${title}: amount"); + + is($invoice->marge_total, 9700, "${title}: marge_total"); + is($invoice->marge_percent, 100, "${title}: marge_percent"); + + is_deeply(\%data, { + allocated => {}, + amounts => { + $buchungsgruppe->income_accno_id($taxzone) => { + amount => 9700, + tax_id => $tax->id, + taxkey => 3, + }, + }, + amounts_cogs => {}, + assembly_items => [ + [], + ], + exchangerate => 1, + taxes => { + $tax->chart_id => 1843, + }, + items => [ + { linetotal => 9700, + linetotal_cost => 0, + sellprice => 0.1, + tax_amount => 1843, taxkey_id => $taxkeys{$item->parts_id}->id, }, ], @@ -439,12 +471,82 @@ sub test_default_invoice_one_item_19_tax_not_included_rounding_discount() { }, "${title}: calculated data"); } +sub test_default_invoice_one_item_19_tax_not_included_rounding_discount_big_qty_low_sellprice() { + reset_state(); + + my $item = new_item(qty => 10001, sellprice => 0.007, discount => 0.035); + my $invoice = new_invoice( + taxincluded => 0, + invoiceitems => [ $item ], + ); + + my %taxkeys = map { ($_->id => $_->get_taxkey(date => DateTime->today_local, is_sales => 1, taxzone => $invoice->taxzone_id)) } uniq map { $_->part } ($item); + + # item 1: + # discount = sellprice 0.007 * discount (0.035) = 0.000245; rounded 0.00 + # sellprice = sellprice 0.007 - discount 0.00 = 0.007 + # linetotal = sellprice 0.007 * qty 10001 * (1 - 0.035) = 67.556755; rounded 67.56 + # 19%(67.56) = 12.8364; rounded = 12.84 + # total rounded = 80.40 + + # lastcost 1.93 * qty 10001 = 19301.93; rounded 19301.93 + # line marge_total = 67.56-19301.93 = -19234.37 + # line marge_percent = 100*-19234.37/67.56 = -28470.0562462996 + + my $title = 'default invoice one item 19 tax not included rounding discount big qty low sellprice'; + my %data = $invoice->calculate_prices_and_taxes; + + is($invoice->netamount, 67.56, "${title}: netamount"); + + is($invoice->amount, 80.40, "${title}: amount"); + + is($invoice->marge_total, -19234.37, "${title}: marge_total"); + is($invoice->marge_percent, -28470.0562462996, "${title}: marge_percent"); + + is_deeply(\%data, { + allocated => {}, + amounts => { + $buchungsgruppe->income_accno_id($taxzone) => { + amount => 67.56, + tax_id => $tax->id, + taxkey => 3, + }, + }, + amounts_cogs => {}, + assembly_items => [ + [], + ], + exchangerate => 1, + taxes => { + $tax->chart_id => 12.84, + }, + items => [ + { linetotal => 67.56, + linetotal_cost => 19301.93, + sellprice => 0.007, + tax_amount => 12.8364, + taxkey_id => $taxkeys{$item->parts_id}->id, + }, + ], + rounding => 0, + }, "${title}: calculated data"); +} + + Support::TestSetup::login(); test_default_invoice_one_item_19_tax_not_included(); test_default_invoice_two_items_19_7_tax_not_included(); test_default_invoice_three_items_sellprice_rounding_discount(); test_default_invoice_one_item_19_tax_not_included_rounding_discount(); +test_default_invoice_one_item_19_tax_not_included_rounding_discount_huge_qty(); +test_default_invoice_one_item_19_tax_not_included_rounding_discount_big_qty_low_sellprice(); clear_up(); done_testing(); + +# vim: ft=perl +# set emacs to perl mode +# Local Variables: +# mode: perl +# End: