X-Git-Url: http://wagnertech.de/git?a=blobdiff_plain;f=timesheet_view.php;h=c8d7048a43d04826973e3e0320ba4d50f71c793a;hb=9819bb63bec83c13dd40ebb2ffc24df5fcfeda33;hp=0a3cc7201fb5e3057f9cc47b5f92d04ce5080a83;hpb=566ab32f690c6e281a85c79345af95dca9a97898;p=timetracker.git diff --git a/timesheet_view.php b/timesheet_view.php index 0a3cc720..c8d7048a 100644 --- a/timesheet_view.php +++ b/timesheet_view.php @@ -92,8 +92,8 @@ if ($showApprove) { if ($request->isPost()) { if ($request->getParameter('btn_submit')) { $fields = array('timesheet_id' => $timesheet['id'], - 'approver_id' => $approver_id); // TODO: obtain (and check) approver id above during access checks. - if (!ttTimesheetHelper::submitTimesheet($fields)) + 'approver_id' => $approver_id); + if (!ttTimesheetHelper::markSubmitted($fields)) $err->add($i18n->get('error.db')); if ($err->no() && !ttTimesheetHelper::sendSubmitEmail($fields)) { $err->add($i18n->get('error.mail_send')); @@ -107,24 +107,36 @@ if ($request->isPost()) { if ($request->getParameter('btn_approve')) { $fields = array('timesheet_id' => $timesheet['id'], + 'name' => $timesheet['name'], + 'user_id' => $timesheet['user_id'], 'comment' => $cl_comment); - if (ttTimesheetHelper::approveTimesheet($fields)) { + if (!ttTimesheetHelper::markApproved($fields)) + $err->add($i18n->get('error.db')); + if ($err->no() && !ttTimesheetHelper::sendApprovedEmail($fields)) { + $err->add($i18n->get('error.mail_send')); + } + if ($err->no()) { // Redirect to self. header('Location: timesheet_view.php?id='.$timesheet['id']); exit(); - } else - $err->add($i18n->get('error.db')); + } } if ($request->getParameter('btn_disapprove')) { $fields = array('timesheet_id' => $timesheet['id'], + 'name' => $timesheet['name'], + 'user_id' => $timesheet['user_id'], 'comment' => $cl_comment); - if (ttTimesheetHelper::disapproveTimesheet($fields)) { + if (!ttTimesheetHelper::markDisapproved($fields)) + $err->add($i18n->get('error.db')); + if ($err->no() && !ttTimesheetHelper::sendDisapprovedEmail($fields)) { + $err->add($i18n->get('error.mail_send')); + } + if ($err->no()) { // Redirect to self. header('Location: timesheet_view.php?id='.$timesheet['id']); exit(); - } else - $err->add($i18n->get('error.db')); + } } }