Testscript zum Auffinden häufiger Fehler (z.B. "my @foo = shift" oder "%bar->somethin...

diff --git a/t/structure/common_errors.t b/t/structure/common_errors.t
new file mode 100644 (file)
index 0000000..6e73070
--- /dev/null
+++ b/t/structure/common_errors.t
@@ -0,0 +1,71 @@
+#!/usr/bin/perl
+
+use strict;
+use lib 't';
+use Support::Files;
+
+my ($testcount);
+
+BEGIN {
+  $testcount = scalar @Support::Files::testitems;
+}
+
+use Test::More tests => $testcount;
+
+# Capture the TESTOUT from Test::More or Test::Builder for printing errors.
+# This will handle verbosity for us automatically.
+my $fh;
+{
+  local $^W = 0;                # Don't complain about non-existent filehandles
+  if (-e \*Test::More::TESTOUT) {
+    $fh = \*Test::More::TESTOUT;
+  } elsif (-e \*Test::Builder::TESTOUT) {
+    $fh = \*Test::Builder::TESTOUT;
+  } else {
+    $fh = \*STDOUT;
+  }
+}
+
+my @testitems = @Support::Files::testitems;
+
+# at last, here we actually run the test...
+
+my @common_errors = ([ '^\s*my\s+%[a-z0-9_]+\s*=\s*shift' ],
+                     [ '^\s*my\s+\(.*\)\s*=\s*shift'      ],
+                     [ '^\s*my\s+\$.*\s*=\s*@_'           ],
+                     [ '@[a-z0-9_]+->'                    ],
+                     [ 'uft8'                             ],
+                     [ '\$slef'                           ],
+                    );
+
+foreach my $file (@testitems) {
+  $file =~ s/\s.*$//;           # nuke everything after the first space (#comment)
+  next if (!$file);             # skip null entries
+
+  if (open (FILE, $file)) {     # open the file for reading
+    $_->[1] = [] foreach @common_errors;
+
+    my $line_number = 0;
+    while (my $file_line = <FILE>) {
+      $line_number++;
+
+      foreach my $re (@common_errors) {
+        push @{ $re->[1] }, $line_number if $file_line =~ /$re->[0]/i;
+      }
+    }
+
+    close (FILE);
+
+    my $errors = join('  ', map { $_->[0] . ' (' . join(' ', @{ $_->[1] }) . ')' } grep { scalar @{ $_->[1] } } @common_errors);
+    if ($errors) {
+      ok(0,"$file: found common errors: $errors");
+    } else {
+      ok(1,"$file does not contain common errors");
+    }
+  } else {
+    ok(0,"could not open $file for common errors check --WARNING");
+  }
+}
+
+exit 0;
+