projects / kivitendo-erp.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 6968d25)
syntax in hidden tags w3c conform gestalltet (bug 272)
authorThomas Kasulke <t.kasulke@linet-services.de>
Wed, 4 Apr 2007 06:46:31 +0000 (06:46 +0000)
committerThomas Kasulke <t.kasulke@linet-services.de>
Wed, 4 Apr 2007 06:46:31 +0000 (06:46 +0000)
bin/mozilla/io.pl patch | blob | history
bin/mozilla/is.pl patch | blob | history

diff --git a/bin/mozilla/io.pl b/bin/mozilla/io.pl
index c7b4f8f..785c3d5 100644 (file)
--- a/bin/mozilla/io.pl
+++ b/bin/mozilla/io.pl
@@ -141,66 +141,66 @@ sub display_row {
   # neue Optik im Rechnungsformular      #
 ########################################
   $column_data{runningnumber} =
-      qq|<th align=left nowrap width=5 class=listheading>|
+      qq|<th align="left" nowrap width="5" class="listheading">|
     . $locale->text('No.')
     . qq|</th>|;
   $column_data{partnumber} =
-      qq|<th align=left nowrap width=12 class=listheading>|
+      qq|<th align="left" nowrap width="12" class="listheading">|
     . $locale->text('Number')
     . qq|</th>|;
   $column_data{description} =
-      qq|<th align=left nowrap width=30 class=listheading>|
+      qq|<th align="left" nowrap width="30" class="listheading">|
     . $locale->text('Part Description')
     . qq|</th>|;
   if ($form->{"type"} eq "purchase_order") {
     $column_data{ship} =
-      qq|<th align=left nowrap width=5 class=listheading>|
+      qq|<th align="left" nowrap width="5" class="listheading">|
       . $locale->text('Ship rcvd')
       . qq|</th>|;
   } else {
     $column_data{ship} =
-      qq|<th align=left nowrap width=5 class=listheading>|
+      qq|<th align="left" nowrap width="5" class="listheading">|
       . $locale->text('Ship')
       . qq|</th>|;
   }
   $column_data{qty} =
-      qq|<th align=left nowrap width=5 class=listheading>|
+      qq|<th align="left" nowrap width="5" class="listheading">|
     . $locale->text('Qty')
     . qq|</th>|;
   $column_data{unit} =
-      qq|<th align=left nowrap width=5 class=listheading>|
+      qq|<th align="left" nowrap width="5" class="listheading">|
     . $locale->text('Unit')
     . qq|</th>|;
   $column_data{license} =
-      qq|<th align=left nowrap width=10 class=listheading>|
+      qq|<th align="left" nowrap width="10" class="listheading">|
     . $locale->text('License')
     . qq|</th>|;
   $column_data{serialnr} =
-      qq|<th align=left nowrap width=10 class=listheading>|
+      qq|<th align="left" nowrap width="10" class="listheading">|
     . $locale->text('Serial No.')
     . qq|</th>|;
   $column_data{projectnr} =
-      qq|<th align=left nowrap width=10 class=listheading>|
+      qq|<th align="left" nowrap width="10" class="listheading">|
     . $locale->text('Project')
     . qq|</th>|;
   $column_data{sellprice} =
-      qq|<th align=left nowrap width=15 class=listheading>|
+      qq|<th align="left" nowrap width="15" class="listheading">|
     . $locale->text('Price')
     . qq|</th>|;
   $column_data{sellprice_pg} =
-      qq|<th align=left nowrap width=15 class=listheading>|
+      qq|<th align="left" nowrap width="15" class="listheading">|
     . $locale->text('Pricegroup')
     . qq|</th>|;
   $column_data{discount} =
-      qq|<th align=left class=listheading>|
+      qq|<th align="left" class="listheading">|
     . $locale->text('Discount')
     . qq|</th>|;
   $column_data{linetotal} =
-      qq|<th align=left nowrap width=10 class=listheading>|
+      qq|<th align="left" nowrap width="10" class="listheading">|
     . $locale->text('Extended')
     . qq|</th>|;
   $column_data{bin} =
-      qq|<th align=left nowrap width=10 class=listheading>|
+      qq|<th align="left" nowrap width="10" class="listheading">|
     . $locale->text('Bin')
     . qq|</th>|;
 ############## ENDE Neueintrag ##################
@@ -215,12 +215,11 @@ sub display_row {
 
   print qq|
   <tr>
-    <td>
-      <input type="hidden" name="show_details" value="$form->{show_details}">
+    <td>| . $cgi->hidden("-name" => "show_details", "-value" => $form->{show_details}) . qq|
       <input type="checkbox" id="cb_show_details" onclick="show_form_details($show_details_new);" $show_details_checked>
       <label for="cb_show_details">| . $locale->text("Show details") . qq|</label><br>
-      <table width=100%>
-       <tr class=listheading>|;
+      <table width="100%">
+       <tr class="listheading">|;
 
   map { print "\n$column_data{$_}" } @column_index;
 
@@ -311,7 +310,7 @@ sub display_row {
     # neue Optik im Rechnungsformular      #
 ########################################
     $column_data{runningnumber} =
-      qq|<td><input name="runningnumber_$i" size=5 value=$i></td>|;    # HuT
+      qq|<td><input name="runningnumber_$i" size="5" value="$i"></td>|;    # HuT
 ############## ENDE Neueintrag ##################
 
     $column_data{partnumber} =
@@ -319,26 +318,26 @@ sub display_row {
 
     if (($rows = $form->numtextrows($form->{"description_$i"}, 30, 6)) > 1) {
       $column_data{description} =
-        qq|<td><textarea name="description_$i" rows=$rows cols=30 wrap=soft>| . H($form->{"description_$i"}) . qq|</textarea><button type="button" onclick="set_longdescription_window('longdescription_$i')">| . $locale->text('L') . qq|</button></td>|;
+        qq|<td><textarea name="description_$i" rows="$rows" cols="30" wrap="soft">| . H($form->{"description_$i"}) . qq|</textarea><button type="button" onclick="set_longdescription_window('longdescription_$i')">| . $locale->text('L') . qq|</button></td>|;
     } else {
       $column_data{description} =
-        qq|<td><input name="description_$i" size=30 value="| . $form->quote($form->{"description_$i"}) . qq|"><button type="button" onclick="set_longdescription_window('longdescription_$i')">| . $locale->text('L') . qq|</button></td>|;
+        qq|<td><input name="description_$i" size="30" value="| . $form->quote($form->{"description_$i"}) . qq|"><button type="button" onclick="set_longdescription_window('longdescription_$i')">| . $locale->text('L') . qq|</button></td>|;
     }
 
     (my $qty_dec) = ($form->{"qty_$i"} =~ /\.(\d+)/);
     $qty_dec = length $qty_dec;
 
     $column_data{qty} =
-        qq|<td align=right><input name="qty_$i" size=5 value=|
-      . $form->format_amount(\%myconfig, $form->{"qty_$i"}, $qty_dec) .qq|>|;
+        qq|<td align="right"><input name="qty_$i" size="5" value="|
+      . $form->format_amount(\%myconfig, $form->{"qty_$i"}, $qty_dec) .qq|">|;
     if ($form->{"formel_$i"}) {
-    $column_data{qty} .= qq|<button type="button" onclick="calculate_qty_selection_window('qty_$i','alu_$i', 'formel_$i', $i)">| . $locale->text('*/') . qq|</button>
-          <input type=hidden name="formel_$i" value="$form->{"formel_$i"}"><input type=hidden name="alu_$i" value="$form->{"alu_$i"}"></td>|;
+    $column_data{qty} .= qq|<button type="button" onclick="calculate_qty_selection_window('qty_$i','alu_$i', 'formel_$i', $i)">| . $locale->text('*/') . qq|</button>| .
+          $cgi->hidden("-name" => "formel_$i", "-value" => $form->{"formel_$i"}) . $cgi->hidden("-name" => "alu_$i", "-value" => $form->{"alu_$i"}). qq|</td>|;
     }
     $column_data{ship} =
-        qq|<td align=right><input name="ship_$i" size=5 value=|
+        qq|<td align="right"><input name="ship_$i" size=5 value="|
       . $form->format_amount(\%myconfig, $form->{"ship_$i"})
-      . qq|></td>|;
+      . qq|"></td>|;
 
     my $is_part     = $form->{"inventory_accno_$i"};
     my $is_assembly = $form->{"assembly_$i"};
@@ -369,9 +368,9 @@ sub display_row {
       }
 
       $column_data{sellprice_pg} =
-        qq|<td align=right><select name="sellprice_pg_$i">$form->{"prices_$i"}</select></td>|;
+        qq|<td align="right"><select name="sellprice_pg_$i">$form->{"prices_$i"}</select></td>|;
       $column_data{sellprice} =
-        qq|<td><input name="sellprice_$i" size=10 value=$price_tmp></td>|;
+        qq|<td><input name="sellprice_$i" size="10" value="$price_tmp"></td>|;
     } else {
 
       # for last row and report
@@ -383,26 +382,26 @@ sub display_row {
         $form->{"pricegroup_old_$i"} = $form->{"pricegroup_id_$i"};
 
         $column_data{sellprice_pg} =
-          qq|<td align=right><select name="sellprice_pg_$i">$prices</select></td>|;
+          qq|<td align="right"><select name="sellprice_pg_$i">$prices</select></td>|;
 
       } else {
 
         # for last row
-        $column_data{sellprice_pg} = qq|<td align=right>&nbsp;</td>|;
+        $column_data{sellprice_pg} = qq|<td align="right">&nbsp;</td>|;
       }
 
       $column_data{sellprice} =
-        qq|<td><input name="sellprice_$i" size=10 value=|
+        qq|<td><input name="sellprice_$i" size="10" value="|
         . $form->format_amount(\%myconfig, $form->{"sellprice_$i"},
                                $decimalplaces)
-        . qq|></td>|;
+        . qq|"></td>|;
     }
     $column_data{discount} =
-        qq|<td align=right><input name="discount_$i" size=3 value=|
+        qq|<td align="right"><input name="discount_$i" size=3 value="|
       . $form->format_amount(\%myconfig, $form->{"discount_$i"})
-      . qq|></td>|;
+      . qq|"></td>|;
     $column_data{linetotal} =
-        qq|<td align=right>|
+        qq|<td align="right">|
       . $form->format_amount(\%myconfig, $linetotal, 2)
       . qq|</td>|;
     $column_data{bin} = qq|<td>$form->{"bin_$i"}</td>|;
@@ -424,38 +423,20 @@ sub display_row {
     my $j = $i % 2;
     print qq|
 
-        <tr valign=top class=listrow$j>|;
+        <tr valign="top" class="listrow$j">|;
 
     map { print "\n$column_data{$_}" } @column_index;
 
     print qq|
         </tr>
-
-<input type=hidden name="orderitems_id_$i" value=$form->{"orderitems_id_$i"}>
-<input type=hidden name="bo_$i" value=$form->{"bo_$i"}>
-
-<input type=hidden name="pricegroup_old_$i" value=$form->{"pricegroup_old_$i"}>
-<input type=hidden name="price_old_$i" value=$form->{"price_old_$i"}>
-<input type=hidden name="unit_old_$i" value="| . $form->quote($form->{"selected_unit_$i"}) . qq|">
-<input type=hidden name="price_new_$i" value=|
-      . $form->format_amount(\%myconfig, $form->{"price_new_$i"}) . qq|>
-
-<input type=hidden name="id_$i" value=$form->{"id_$i"}>
-<input type=hidden name="inventory_accno_$i" value=$form->{"inventory_accno_$i"}>
-<input type=hidden name="bin_$i" value="$form->{"bin_$i"}">
-<input type=hidden name="partsgroup_$i" value="$form->{"partsgroup_$i"}">
-<input type=hidden name="partnotes_$i" value="| . $form->quote($form->{"partnotes_$i"}) . qq|">
-<input type=hidden name="income_accno_$i" value=$form->{"income_accno_$i"}>
-<input type=hidden name="expense_accno_$i" value=$form->{"expense_accno_$i"}>
-<input type=hidden name="listprice_$i" value="$form->{"listprice_$i"}">
-<input type=hidden name="assembly_$i" value="$form->{"assembly_$i"}">
-<input type=hidden name="taxaccounts_$i" value="$form->{"taxaccounts_$i"}">
-<input type=hidden name="ordnumber_$i" value="$form->{"ordnumber_$i"}">
-<input type=hidden name="transdate_$i" value="$form->{"transdate_$i"}">
-<input type=hidden name="cusordnumber_$i" value="$form->{"cusordnumber_$i"}">
-<input type=hidden name="longdescription_$i" value="| . $form->quote($form->{"longdescription_$i"}) . qq|">
-<input type=hidden name="basefactor_$i" value="$form->{"basefactor_$i"}">
-
+|;
+map({ print($cgi->hidden("-name" => $_, "-value" => $form->{$_})); } 
+       ("orderitems_id_$i", "bo_$i", "pricegroup_old_$i", "price_old_$i", "selected_unit_$i", "id_$i", "inventory_accno_$i", "bin_$i",
+          "partsgroup_$i", "partnotes_$i", "income_accno_$i", "expense_accno_$i", "listprice_$i", "assembly_$i", "taxaccounts_$i",
+          "ordnumber_$i", "transdate_$i", "cusordnumber_$i", "longdescription_$i", "basefactor_$i"));
+print qq|
+<input type="hidden" name="price_new_$i" value="|
+      . $form->format_amount(\%myconfig, $form->{"price_new_$i"}) . qq|">
 |;
 
 ########################################
@@ -468,8 +449,8 @@ sub display_row {
 
     # print second row
     print qq|
-        <tr  class=listrow$j $row_style_attr>
-         <td colspan=$colspan>
+        <tr  class="listrow$j" $row_style_attr>
+         <td colspan="$colspan">
 |;
     if ($lizenzen && $form->{type} eq "invoice" && $form->{vc} eq "customer") {
       my $selected = $form->{"licensenumber_$i"};
@@ -480,15 +461,15 @@ sub display_row {
       $lizenzen_quoted = $form->{"lizenzen_$i"};
       $lizenzen_quoted =~ s/\"/&quot;/g;
       print qq|
-       <b>Lizenz\#</b>&nbsp;<select name="licensenumber_$i" size=1>
+       <b>Lizenz\#</b>&nbsp;<select name="licensenumber_$i" size="1">
        $form->{"lizenzen_$i"}
         </select>
-       <input type=hidden name="lizenzen_$i" value="${lizenzen_quoted}">
+       <input type="hidden" name="lizenzen_$i" value="${lizenzen_quoted}">
 |;
     }
     if ($form->{type} !~ /_quotation/) {
       print qq|
-          <b>$serialnumber</b>&nbsp;<input name="serialnumber_$i" size=15 value="$form->{"serialnumber_$i"}">|;
+          <b>$serialnumber</b>&nbsp;<input name="serialnumber_$i" size="15" value="$form->{"serialnumber_$i"}">|;
     }
 
     print qq|<b>$projectnumber</b>&nbsp;| .
@@ -503,7 +484,7 @@ sub display_row {
         ? 'deliverydate'
         : 'reqdate';    # invoice uses a different term for the same thing.
       print qq|
-        <b>${$reqdate_term}</b>&nbsp;<input name="${reqdate_term}_$i" size=11 value="$form->{"${reqdate_term}_$i"}">
+        <b>${$reqdate_term}</b>&nbsp;<input name="${reqdate_term}_$i" size="11" value="$form->{"${reqdate_term}_$i"}">
 |;
     }
     my $subtotalchecked = ($form->{"subtotal_$i"}) ? "checked" : "";
@@ -584,15 +565,15 @@ sub select_item {
 
   $column_data{ndx}        = qq|<th>&nbsp;</th>|;
   $column_data{partnumber} =
-    qq|<th class=listheading>| . $locale->text('Number') . qq|</th>|;
+    qq|<th class="listheading">| . $locale->text('Number') . qq|</th>|;
   $column_data{description} =
-    qq|<th class=listheading>| . $locale->text('Part Description') . qq|</th>|;
+    qq|<th class="listheading">| . $locale->text('Part Description') . qq|</th>|;
   $column_data{sellprice} =
-    qq|<th class=listheading>| . $locale->text('Price') . qq|</th>|;
+    qq|<th class="listheading">| . $locale->text('Price') . qq|</th>|;
   $column_data{onhand} =
-    qq|<th class=listheading>| . $locale->text('Qty') . qq|</th>|;
+    qq|<th class="listheading">| . $locale->text('Qty') . qq|</th>|;
   $column_data{unit} =
-    qq|<th class=listheading>| . $locale->text('Unit') . qq|</th>|;
+    qq|<th class="listheading">| . $locale->text('Unit') . qq|</th>|;
   # list items with radio button on a form
   $form->header;
 
@@ -602,14 +583,14 @@ sub select_item {
   print qq|
 <body>
 
-<form method=post action=$form->{script}>
+<form method="post" action="$form->{script}">
 
-<table width=100%>
+<table width="100%">
   <tr>
-    <th class=listtop colspan=$colspan>$title</th>
+    <th class="listtop" colspan="$colspan">$title</th>
   </tr>
   <tr height="5"></tr>
-  <tr class=listheading>|;
+  <tr class="listheading">|;
 
   map { print "\n$column_data{$_}" } @column_index;
 
@@ -626,7 +607,7 @@ sub select_item {
           $ref->{"lizenzen"} .=
             qq|<option value=\"$item->{"id"}\">$item->{"licensenumber"}</option>|;
         }
-        $ref->{"lizenzen"} .= qq|<option value=-1>Neue Lizenz</option>|;
+        $ref->{"lizenzen"} .= qq|<option value="-1">Neue Lizenz</option>|;
         $ref->{"lizenzen"} =~ s/\"/&quot;/g;
       }
     }
@@ -637,17 +618,17 @@ sub select_item {
     $ref->{sellprice} =
       $form->round_amount($ref->{sellprice} * (1 - $form->{tradediscount}), 2);
     $column_data{ndx} =
-      qq|<td><input name=ndx class=radio type=radio value=$i $checked></td>|;
+      qq|<td><input name="ndx" class="radio" type="radio" value="$i" $checked></td>|;
     $column_data{partnumber} =
-      qq|<td><input name="new_partnumber_$i" type=hidden value="$ref->{partnumber}">$ref->{partnumber}</td>|;
+      qq|<td><input name="new_partnumber_$i" type="hidden" value="$ref->{partnumber}">$ref->{partnumber}</td>|;
     $column_data{description} =
-      qq|<td><input name="new_description_$i" type=hidden value="$ref->{description}">$ref->{description}</td>|;
+      qq|<td><input name="new_description_$i" type="hidden" value=$ref->{description}>$ref->{description}</td>|;
     $column_data{sellprice} =
-      qq|<td align=right><input name="new_sellprice_$i" type=hidden value=$ref->{sellprice}>|
+      qq|<td align="right"><input name="new_sellprice_$i" type="hidden" value="$ref->{sellprice}">|
       . $form->format_amount(\%myconfig, $ref->{sellprice}, 2, "&nbsp;")
       . qq|</td>|;
     $column_data{onhand} =
-      qq|<td align=right><input name="new_onhand_$i" type=hidden value=$ref->{onhand}>|
+      qq|<td align="right"><input name="new_onhand_$i" type="hidden" value="$ref->{onhand}">|
       . $form->format_amount(\%myconfig, $ref->{onhand}, '', "&nbsp;")
       . qq|</td>|;
     $column_data{unit} =
@@ -661,39 +642,23 @@ sub select_item {
 
     print qq|
 </tr>
-
-<input name="new_bin_$i" type=hidden value="$ref->{bin}">
-<input name="new_listprice_$i" type=hidden value=$ref->{listprice}>
-<input name="new_inventory_accno_$i" type=hidden value=$ref->{inventory_accno}>
-<input name="new_income_accno_$i" type=hidden value=$ref->{income_accno}>
-<input name="new_expense_accno_$i" type=hidden value=$ref->{expense_accno}>
-<input name="new_unit_$i" type=hidden value="$ref->{unit}">
-<input name="new_weight_$i" type=hidden value="$ref->{weight}">
-<input name="new_assembly_$i" type=hidden value="$ref->{assembly}">
-<input name="new_taxaccounts_$i" type=hidden value="$ref->{taxaccounts}">
-<input name="new_partsgroup_$i" type=hidden value="$ref->{partsgroup}">
-<input name="new_formel_$i" type=hidden value="$ref->{formel}">
-<input name="new_longdescription_$i" type=hidden value="| . Q($ref->{longdescription}) . qq|">
-<input name="new_not_discountable_$i" type=hidden value="$ref->{not_discountable}">
-<input name="new_part_payment_id_$i" type=hidden value="$ref->{part_payment_id}">
-<input name="new_partnotes_$i" type="hidden" value="| . Q($ref->{"partnotes"}) . qq|">
-
-<input name="new_id_$i" type=hidden value=$ref->{id}>
-
 |;
-    if ($lizenzen) {
+map({ print($cgi->hidden("-name" => "new_$__$i", "-value" => $ref->{$_})); } 
+        qw(bin listprice inventory_accno income_accno expense_accno unit weight assembly taxaccounts partsgroup 
+           formel logdescription not_discountable part_payment_id partnodes id));
+if ($lizenzen) {
       print qq|
-<input name="new_lizenzen_$i" type=hidden value="$ref->{lizenzen}">
+<input name="new_lizenzen_$i" type="hidden" value="$ref->{lizenzen}">
 |;
     }
 
   }
 
   print qq|
-<tr><td colspan=8><hr size=3 noshade></td></tr>
+<tr><td colspan="8"><hr size="3" noshade></td></tr>
 </table>
 
-<input name=lastndx type=hidden value=$i>
+<input name="lastndx" type="hidden" value="$i">
 
 |;
 
@@ -703,14 +668,14 @@ sub select_item {
   # save all other form variables
   foreach $key (keys %${form}) {
     $form->{$key} =~ s/\"/&quot;/g;
-    print qq|<input name=$key type=hidden value="$form->{$key}">\n|;
+    print qq|<input name="$key" type="hidden" value="$form->{$key}">\n|;
   }
 
   print qq|
-<input type=hidden name=nextsub value=item_selected>
+<input type="hidden" name="nextsub" value="item_selected">
 
 <br>
-<input class=submit type=submit name=action value="|
+<input class="submit" type="submit" name="action" value="|
     . $locale->text('Continue') . qq|">
 </form>
 
@@ -842,36 +807,38 @@ sub new_item {
   print qq|
 <body>
 
-<h4 class=error>| . $locale->text('Item not on file!') . qq|
+<h4 class="error">| . $locale->text('Item not on file!') . qq|
 
 <p>
 | . $locale->text('What type of item is this?') . qq|</h4>
 
-<form method=post action=ic.pl>
+<form method="post" action="ic.pl">
 
 <p>
 
-  <input class=radio type=radio name=item value=part checked>&nbsp;|
+  <input class="radio" type="radio" name="item" value="part" checked>&nbsp;|
     . $locale->text('Part') . qq|<br>
-  <input class=radio type=radio name=item value=service>&nbsp;|
-    . $locale->text('Service')
-
-    . qq|
-<input type=hidden name=previousform value="$previousform">
-<input type=hidden name=partnumber value="$form->{"partnumber_$i"}">
-<input type=hidden name=description value="$form->{"description_$i"}">
-<input type=hidden name=rowcount value=$form->{rowcount}>
-<input type=hidden name=taxaccount2 value=$form->{taxaccounts}>
-<input type=hidden name=vc value=$form->{vc}>
-
-<input type=hidden name=path value=$form->{path}>
-<input type=hidden name=login value=$form->{login}>
-<input type=hidden name=password value=$form->{password}>
+  <input class="radio" type="radio" name="item" value="service">&nbsp;|
+    . $locale->text('Service');
+print $cgi->hidden("-name" => "previousform", "-value" => $previousform);
+map({ print($cgi->hidden("-name" => $_, "-value" => $form->{$_})); } 
+     ("partnumber_$i", "description_$i", "rowcount", "taxaccounts", "vc", "path", "login", "password"));
+
+#<input type="hidden" name="partnumber" value="$form->{"partnumber_$i"}">
+#<input type="hidden" name="description" value="$form->{"description_$i"}">
+#<input type="hidden" name="rowcount" value="$form->{rowcount}">
+#<input type="hidden" name="taxaccount2" value="$form->{taxaccounts}">
+#<input type="hidden" name="vc" value="$form->{vc}">
+#
+#<input type="hidden" name="path" value="$form->{path}">
+#<input type="hidden" name="login" value="$form->{login}">
+#<input type="hidden" name="password" value="$form->{password}">
 
-<input type=hidden name=nextsub value=add>
+print qq|
+<input type="hidden" name="nextsub" value="add">
 
 <p>
-<input class=submit type=submit name=action value="|
+<input class="submit" type="submit" name="action" value="|
     . $locale->text('Continue') . qq|">
 </form>
 
@@ -2079,85 +2046,86 @@ sub ship_to {
   print qq|
 <body>
 
-<form method=post action=$form->{script}>
+<form method="post" action="$form->{script}">
 
-<table width=100%>
+<table width="100%">
   <tr>
     <td>
       <table>
-       <tr class=listheading>
-         <th class=listheading colspan=2 width=50%>|
+       <tr class="listheading">
+         <th class="listheading" colspan="2" width="50%">|
     . $locale->text('Billing Address') . qq|</th>
-         <th class=listheading width=50%>|
+         <th class="listheading" width="50%">|
     . $locale->text('Shipping Address') . qq|</th>
        </tr>
        <tr height="5"></tr>
        <tr>
-         <th align=right nowrap>$number</th>
+         <th align="right" nowrap>$number</th>
          <td>$form->{"$form->{vc}number"}</td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Company Name') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Company Name') . qq|</th>
          <td>$form->{name}</td>
-         <td><input name=shiptoname size=35 value="$form->{shiptoname}"></td>
+         <td><input name="shiptoname" size="35" value="$form->{shiptoname}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Department') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Department') . qq|</th>
          <td>$form->{department_1}</td>
-         <td><input name=shiptodepartment_1 size=35 value="$form->{shiptodepartment_1}"></td>
+         <td><input name="shiptodepartment_1" size="35" value="$form->{shiptodepartment_1}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>&nbsp;</th>
+         <th align="right" nowrap>&nbsp;</th>
          <td>$form->{department_2}</td>
-         <td><input name=shiptodepartment_2 size=35 value="$form->{shiptodepartment_2}"></td>
+         <td><input name="shiptodepartment_2" size="35" value="$form->{shiptodepartment_2}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Street') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Street') . qq|</th>
          <td>$form->{street}</td>
-         <td><input name=shiptostreet size=35 value="$form->{shiptostreet}"></td>
+         <td><input name="shiptostreet" size="35" value="$form->{shiptostreet}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Zipcode') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Zipcode') . qq|</th>
          <td>$form->{zipcode}</td>
-         <td><input name=shiptozipcode size=35 value="$form->{shiptozipcode}"></td>
+         <td><input name="shiptozipcode" size="35" value="$form->{shiptozipcode}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('City') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('City') . qq|</th>
          <td>$form->{city}</td>
-         <td><input name=shiptocity size=35 value="$form->{shiptocity}"></td>
+         <td><input name="shiptocity" size="35" value="$form->{shiptocity}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Country') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Country') . qq|</th>
          <td>$form->{country}</td>
-         <td><input name=shiptocountry size=35 value="$form->{shiptocountry}"></td>
+         <td><input name="shiptocountry" size="35" value="$form->{shiptocountry}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Contact') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Contact') . qq|</th>
          <td>$form->{contact}</td>
-         <td><input name=shiptocontact size=35 value="$form->{shiptocontact}"></td>
+         <td><input name="shiptocontac"t size="35" value="$form->{shiptocontact}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Phone') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Phone') . qq|</th>
          <td>$form->{phone}</td>
-         <td><input name=shiptophone size=20 value="$form->{shiptophone}"></td>
+         <td><input name="shiptophone" size="20" value="$form->{shiptophone}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('Fax') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('Fax') . qq|</th>
          <td>$form->{fax}</td>
-         <td><input name=shiptofax size=20 value="$form->{shiptofax}"></td>
+         <td><input name="shiptofax" size="20" value="$form->{shiptofax}"></td>
        </tr>
        <tr>
-         <th align=right nowrap>| . $locale->text('E-mail') . qq|</th>
+         <th align="right" nowrap>| . $locale->text('E-mail') . qq|</th>
          <td>$form->{email}</td>
-         <td><input name=shiptoemail size=35 value="$form->{shiptoemail}"></td>
+         <td><input name="shiptoemail" size="35" value="$form->{shiptoemail}"></td>
        </tr>
       </table>
     </td>
   </tr>
 </table>
+| . $cgi->hidden("-name" => "nexsub", "-value" => $nextsub);
+;
+
 
-<input type=hidden name=nextsub value=$nextsub>
-|;
 
   # delete shipto
   map({ delete $form->{$_} } (@shipto_vars, qw(header)));
@@ -2165,15 +2133,15 @@ sub ship_to {
 
   foreach $key (keys %$form) {
     $form->{$key} =~ s/\"/&quot;/g;
-    print qq|<input type=hidden name=$key value="$form->{$key}">\n|;
+    print qq|<input type="hidden" name="$key" value="$form->{$key}">\n|;
   }
 
   print qq|
 
-<hr size=3 noshade>
+<hr size="3" noshade>
 
 <br>
-<input class=submit type=submit name=action value="|
+<input class="submit" type="submit" name="action" value="|
     . $locale->text('Continue') . qq|">
 </form>
 
diff --git a/bin/mozilla/is.pl b/bin/mozilla/is.pl
index 51f3762..8c12493 100644 (file)
--- a/bin/mozilla/is.pl
+++ b/bin/mozilla/is.pl
@@ -349,15 +349,15 @@ sub form_header {
   } else {
     $form->{selecttaxzone} =~ s/ selected//g;
     if ($form->{taxzone_id} ne "") {
-      $form->{selecttaxzone} =~ s/value=$form->{taxzone_id}/value=$form->{taxzone_id} selected/;
+      $form->{selecttaxzone} =~ s/value=\"$form->{taxzone_id}\"/value=\"$form->{taxzone_id}\" selected/;
     }
   }
 
   $taxzone = qq|
              <tr>
-               <th align=right>| . $locale->text('Steuersatz') . qq|</th>
-               <td><select name=taxzone_id>$form->{selecttaxzone}</select></td>
-               <input type=hidden name=selecttaxzone value="$form->{selecttaxzone}">
+               <th align="right">| . $locale->text('Steuersatz') . qq|</th>
+               <td><select name="taxzone_id">$form->{selecttaxzone}</select></td>
+               <input type="hidden" name="selecttaxzone" value="$form->{selecttaxzone}">
              </tr>|;
 
   my @old_project_ids = ($form->{"globalproject_id"});
@@ -451,30 +451,30 @@ sub form_header {
   if ($form->{currency} ne $form->{defaultcurrency}) {
     if ($form->{forex}) {
       $exchangerate .=
-          qq|<th align=right>|
+          qq|<th align="right">|
         . $locale->text('Exchangerate')
-        . qq|</th><td>$form->{exchangerate}<input type=hidden name=exchangerate value=$form->{exchangerate}></td>|;
+        . qq|</th><td>$form->{exchangerate}<input type="hidden" name="exchangerate" value="$form->{exchangerate}"></td>|;
     } else {
       $exchangerate .=
-          qq|<th align=right>|
+          qq|<th align="right">|
         . $locale->text('Exchangerate')
-        . qq|</th><td><input name=exchangerate size=10 value=$form->{exchangerate}></td>|;
+        . qq|</th><td><input name="exchangerate" size="10" value="$form->{exchangerate}"></td>|;
     }
   }
   $exchangerate .= qq|
-<input type=hidden name=forex value=$form->{forex}>
+<input type="hidden" name="forex" value="$form->{forex}">
 |;
 
   $customer =
     ($form->{selectcustomer})
-    ? qq|<select name=customer>$form->{selectcustomer}</select>\n<input type=hidden name="selectcustomer" value="$form->{selectcustomer}">|
-    : qq|<input name=customer value="$form->{customer}" size=35>|;
+    ? qq|<select name="customer">$form->{selectcustomer}</select>\n<input type="hidden" name="selectcustomer" value="$form->{selectcustomer}">|
+    : qq|<input name="customer" value="$form->{customer}" size="35">|;
 
   $department = qq|
               <tr>
                <th align="right" nowrap>| . $locale->text('Department') . qq|</th>
-               <td colspan=3><select name=department>$form->{selectdepartment}</select>
-               <input type=hidden name=selectdepartment value="$form->{selectdepartment}">
+               <td colspan="3"><select name="department">$form->{selectdepartment}</select>
+               <input type="hidden" name="selectdepartment" value="$form->{selectdepartment}">
                </td>
              </tr>
 | if $form->{selectdepartment};
@@ -484,9 +484,9 @@ sub form_header {
   if ($form->{business}) {
     $business = qq|
              <tr>
-               <th align=right>| . $locale->text('Business') . qq|</th>
+               <th align="right">| . $locale->text('Business') . qq|</th>
                <td>$form->{business}</td>
-               <th align=right>| . $locale->text('Trade Discount') . qq|</th>
+               <th align="right">| . $locale->text('Trade Discount') . qq|</th>
                <td>|
       . $form->format_amount(\%myconfig, $form->{tradediscount} * 100)
       . qq| %</td>
@@ -497,12 +497,12 @@ sub form_header {
   if ($form->{max_dunning_level}) {
     $dunning = qq|
              <tr>
-                <td colspan=4>
+                <td colspan="4">
                 <table>
                   <tr>
-               <th align=right>| . $locale->text('Max. Dunning Level') . qq|:</th>
+               <th align="right">| . $locale->text('Max. Dunning Level') . qq|:</th>
                <td><b>$form->{max_dunning_level}</b></td>
-               <th align=right>| . $locale->text('Dunning Amount') . qq|:</th>
+               <th align="right">| . $locale->text('Dunning Amount') . qq|:</th>
                <td><b>|
       . $form->format_amount(\%myconfig, $form->{dunning_amount},2)
       . qq|</b></td>
@@ -523,11 +523,10 @@ sub form_header {
   
       # with JavaScript Calendar
       $button1 = qq|
-        <td><input name=invdate id=invdate size=11 title="$myconfig{dateformat}" value=$form->{invdate}></td>
-        <td><input type=button name=invdate id="trigger1" value=|
-        . $locale->text('button') . qq|></td>
-        |;
-  
+        <td><input name="invdate" id="invdate" size="11" title="$myconfig{dateformat}" value="$form->{invdate}"></td>
+        <td><input type="button" name="invdate" id="trigger1" value="|
+        . $locale->text('button') . qq|"></td>|;
+       
       #write Trigger
       $jsscript =
         Form->write_trigger(\%myconfig,     "1",
@@ -537,28 +536,28 @@ sub form_header {
   
       # without JavaScript Calendar
       $button1 =
-        qq|<td><input name=invdate size=11 title="$myconfig{dateformat}" value=$form->{invdate}></td>|;
+        qq|<td><input name="invdate" size="11" title="$myconfig{dateformat}" value="$form->{invdate}"></td>|;
       $button2 =
-        qq|<td width="13"><input name=duedate size=11 title="$myconfig{dateformat}" value=$form->{duedate}></td>|;
+        qq|<td width="13"><input name="duedate" size="11" title="$myconfig{dateformat}" value="$form->{duedate}"></td>|;
     }
   } else {
     if ($form->{jsscript}) {
   
       # with JavaScript Calendar
       $button1 = qq|
-        <td><input name=invdate id=invdate size=11 title="$myconfig{dateformat}" value=$form->{invdate}></td>
-        <td><input type=button name=invdate id="trigger1" value=|
-        . $locale->text('button') . qq|></td>
+        <td><input name="invdate" id="invdate" size="11" title="$myconfig{dateformat}" value="$form->{invdate}"></td>
+        <td><input type="button" name="invdate" id="trigger1" value="|
+        . $locale->text('button') . qq|"></td>
         |;
       $button2 = qq|
-        <td width="13"><input name=duedate id=duedate size=11 title="$myconfig{dateformat}" value=$form->{duedate}></td>
-        <td width="4"><input type=button name=duedate id="trigger2" value=|
-        . $locale->text('button') . qq|></td></td>
+        <td width="13"><input name="duedate" id="duedate" size="11" title="$myconfig{dateformat}" value="$form->{duedate}"></td>
+        <td width="4"><input type="button" name="duedate" id="trigger2" value="|
+        . $locale->text('button') . qq|"></td></td>
       |;
       $button3 = qq|
-        <td width="13"><input name=deliverydate id=deliverydate size=11 title="$myconfig{dateformat}" value=$form->{deliverydate}></td>
-        <td width="4"><input type=button name=deliverydate id="trigger3" value=|
-        . $locale->text('button') . qq|></td></td>
+        <td width="13"><input name="deliverydate" id="deliverydate" size="11" title="$myconfig{dateformat}" value="$form->{deliverydate}"></td>
+        <td width="4"><input type="button" name="deliverydate" id="trigger3" value="|
+        . $locale->text('button') . qq|"></td></td>
       |;
   
       #write Trigger
@@ -573,7 +572,7 @@ sub form_header {
   
       # without JavaScript Calendar
       $button1 =
-        qq|<td><input name=invdate size=11 title="$myconfig{dateformat}" value=$form->{invdate}></td>|;
+        qq|<td><input name="invdate" size="11" title="$myconfig{dateformat}" value="$form->{invdate}"></td>|;
       $button2 =
         qq|<td width="13"><input name=duedate size=11 title="$myconfig{dateformat}" value=$form->{duedate}></td>|;
     }
@@ -610,69 +609,45 @@ sub form_header {
 <script type="text/javascript" src="js/vendor_selection.js"></script>
 <script type="text/javascript" src="js/calculate_qty.js"></script>
 
-<form method=post name="invoice" action=$form->{script}>
-
-
-<input type=hidden name=id value=$form->{id}>
-<input type=hidden name=action value=$form->{action}>
-
-<input type=hidden name=type value=$form->{type}>
-<input type=hidden name=media value=$form->{media}>
-<input type=hidden name=format value=$form->{format}>
-
-<input type=hidden name=queued value="$form->{queued}">
-<input type=hidden name=printed value="$form->{printed}">
-<input type=hidden name=emailed value="$form->{emailed}">
+<form method="post" name="invoice" action="$form->{script}">
+| ;
+map({print $cgi->hidden("-name" => $_ , "-value" => $form->{$_});} 
+     qw(id action type media format queued printed emailed title vc discount 
+        creditlimit creditremaining tradediscount business closedto locked shipped storno storno_id)) ;
+print ($form->{saved_message} ? qq|<p>$form->{saved_message}</p>| : "") ;
+print qq|
 
-<input type=hidden name=title value="$form->{title}">
-<input type=hidden name=vc value=$form->{vc}>
+<input type="hidden" name="lizenzen" value="$lizenzen">
 
-<input type=hidden name=discount value=$form->{discount}>
-<input type=hidden name=creditlimit value=$form->{creditlimit}>
-<input type=hidden name=creditremaining value=$form->{creditremaining}>
-
-<input type=hidden name=tradediscount value=$form->{tradediscount}>
-<input type=hidden name=business value=$form->{business}>
-
-<input type=hidden name=closedto value=$form->{closedto}>
-<input type=hidden name=locked value=$form->{locked}>
-
-<input type=hidden name=shipped value=$form->{shipped}>
-<input type=hidden name=lizenzen value=$lizenzen>
-<input type=hidden name=storno value=$form->{storno}>
-<input type=hidden name=storno_id value=$form->{storno_id}>
-
-| . ($form->{saved_message} ? qq|<p>$form->{saved_message}</p>| : "") . qq|
-
-<table width=100%>
-  <tr class=listtop>
-    <th class=listtop>$form->{title}</th>
+<table width="100%">
+  <tr class="listtop">
+    <th class="listtop">$form->{title}</th>
   </tr>
   <tr height="5"></tr>
   <tr>
     <td>
-      <table width=100%>
-       <tr valign=top>
+      <table width="100%">
+       <tr valign="top">
          <td>
            <table>
              <tr>
-               <th align=right nowrap>| . $locale->text('Customer') . qq|</th>
-               <td colspan=3>$customer</td>
-    <input type=hidden name=customer_klass value=$form->{customer_klass}>
-               <input type=hidden name=customer_id value=$form->{customer_id}>
-               <input type=hidden name=oldcustomer value="$form->{oldcustomer}">
-                <th align=richt nowrap>|
+               <th align="right" nowrap>| . $locale->text('Customer') . qq|</th>
+               <td colspan="3">$customer</td>
+    <input type="hidden" name="customer_klass" value="$form->{customer_klass}">
+               <input type="hidden" name="customer_id" value="$form->{customer_id}">
+               <input type="hidden" name="oldcustomer" value="$form->{oldcustomer}">
+                <th align="right" nowrap>|
     . $locale->text('Contact Person') . qq|</th>
-                <td colspan=3>$contact</td>
+                <td colspan="3">$contact</td>
              </tr>
              <tr>
                <td></td>
-               <td colspan=3>
+               <td colspan="3">
                  <table>
                    <tr>
                      <th nowrap>| . $locale->text('Credit Limit') . qq|</th>
                      <td>$form->{creditlimit}</td>
-                     <td width=20%></td>
+                     <td width="20%"></td>
                      <th nowrap>| . $locale->text('Remaining') . qq|</th>
                      <td class="plus$n">$form->{creditremaining}</td>
                    </tr>
@@ -683,28 +658,29 @@ sub form_header {
              $business
               $dunning
              <tr>
-               <th align=right nowrap>| . $locale->text('Record in') . qq|</th>
-               <td colspan=3><select name=AR style="width:280px;">$form->{selectAR}</select></td>
-               <input type=hidden name=selectAR value="$form->{selectAR}">
+               <th align="right" nowrap>| . $locale->text('Record in') . qq|</th>
+               <td colspan="3"><select name="AR" style="width:280px;">$form->{selectAR}</select></td>
+               <input type="hidden" name="selectAR" value="$form->{selectAR}">
              </tr>
               $taxzone
              $department
              <tr>
-               <th align=right nowrap>| . $locale->text('Currency') . qq|</th>
-               <td><select name=currency>$form->{selectcurrency}</select></td>
-               <input type=hidden name=selectcurrency value="$form->{selectcurrency}">
-               <input type=hidden name=defaultcurrency value=$form->{defaultcurrency}>
-               <input type=hidden name=fxgain_accno value=$form->{fxgain_accno}>
-               <input type=hidden name=fxloss_accno value=$form->{fxloss_accno}>
+               <th align="right" nowrap>| . $locale->text('Currency') . qq|</th>
+               <td><select name="currency">$form->{selectcurrency}</select></td>
+               <input type="hidden" name="selectcurrency" value="$form->{selectcurrency}">
+               <input type="hidden" name="defaultcurrency" value="$form->{defaultcurrency}">
+               <input type="hidden" name="fxgain_accno" value="$form->{fxgain_accno}">
+               <input type="hidden" name="fxloss_accno" value="$form->{fxloss_accno}">
                $exchangerate
              </tr>
              <tr>
-               <th align=right nowrap>| . $locale->text('Shipping Point') . qq|</th>
-               <td colspan=3><input name=shippingpoint size=35 value="$form->{shippingpoint}"></td>
-             </tr>
+               <th align="right" nowrap>| . $locale->text('Shipping Point') . qq|</th>
+               <td colspan="3"> | .
+               $cgi->textfield("-name" => "shippingpoint", "-size" => 35, "-value" => $form->{shippingpoint}) .
+         qq|</tr>
              <tr>
-               <th align=right nowrap>| . $locale->text('Ship via') . qq|</th>
-               <td colspan=3><input name=shipvia size=35 value="$form->{shipvia}"></td>
+               <th align="right" nowrap>| . $locale->text('Ship via') . qq|</th>
+               <td colspan="3"><input name="shipvia" size="35" value="$form->{shipvia}"></td>
              </tr>|;
 #               <tr>
 #                 <td colspan=4>
@@ -728,46 +704,46 @@ sub form_header {
 #               </tr>
 print qq|          </table>
          </td>
-         <td align=right>
+         <td align="right">
            <table>
              <tr>
-               <th align=right nowrap>| . $locale->text('Employee') . qq|</th>
-               <td colspan=2><select name=employee>$form->{selectemployee}</select></td>
-               <input type=hidden name=selectemployee value="$form->{selectemployee}">
+               <th align="right" nowrap>| . $locale->text('Employee') . qq|</th>
+               <td colspan="2"><select name="employee">$form->{selectemployee}</select></td>
+               <input type="hidden" name="selectemployee" value="$form->{selectemployee}">
                 <td></td>
              </tr>
         $salesman
 |;
 if ($form->{type} eq "credit_note") {
 print qq|     <tr>
-               <th align=right nowrap>| . $locale->text('Credit Note Number') . qq|</th>
-               <td><input name=invnumber size=11 value="$form->{invnumber}"></td>
+               <th align="right" nowrap>| . $locale->text('Credit Note Number') . qq|</th>
+               <td><input name="invnumber" size="11" value="$form->{invnumber}"></td>
              </tr>
              <tr>
-               <th align=right>| . $locale->text('Credit Note Date') . qq|</th>
+               <th align="right">| . $locale->text('Credit Note Date') . qq|</th>
                 $button1
              </tr>|;
 } else {
 print qq|     <tr>
-               <th align=right nowrap>| . $locale->text('Invoice Number') . qq|</th>
-               <td><input name=invnumber size=11 value="$form->{invnumber}"></td>
+               <th align="right" nowrap>| . $locale->text('Invoice Number') . qq|</th>
+               <td><input name="invnumber" size="11" value="$form->{invnumber}"></td>
              </tr>
              <tr>
-               <th align=right>| . $locale->text('Invoice Date') . qq|</th>
+               <th align="right">| . $locale->text('Invoice Date') . qq|</th>
                 $button1
              </tr>
              <tr>
-               <th align=right>| . $locale->text('Due Date') . qq|</th>
+               <th align="right">| . $locale->text('Due Date') . qq|</th>
                 $button2
              </tr>
              <tr>
-               <th align=right>| . $locale->text('Delivery Date') . qq|</th>
+               <th align="right">| . $locale->text('Delivery Date') . qq|</th>
                 $button3
              </tr>|;
 }
 print qq|     <tr>
-               <th align=right nowrap>| . $locale->text('Order Number') . qq|</th>
-               <td><input name=ordnumber size=11 value="$form->{ordnumber}"></td>
+               <th align="right" nowrap>| . $locale->text('Order Number') . qq|</th>
+               <td><input name="ordnumber" size="11" value="$form->{ordnumber}"></td>
              </tr>
         <tr>
           <th align="right" nowrap>| . $locale->text('Order Date') . qq|</th>
@@ -775,8 +751,8 @@ print qq|     <tr>
           <td><input type="button" name="b_orddate" id="trigger_orddate" value="?"></td>
         </tr>
              <tr>
-               <th align=right nowrap>| . $locale->text('Quotation Number') . qq|</th>
-               <td><input name=quonumber size=11 value="$form->{quonumber}"></td>
+               <th align="right" nowrap>| . $locale->text('Quotation Number') . qq|</th>
+               <td><input name="quonumber" size="11" value="$form->{quonumber}"></td>
              </tr>
         <tr>
           <th align="right" nowrap>| . $locale->text('Quotation Date') . qq|</th>
@@ -784,8 +760,8 @@ print qq|     <tr>
           <td><input type="button" name="b_quodate" id="trigger_quodate" value="?"></td>
         </tr>
              <tr>
-               <th align=right nowrap>| . $locale->text('Customer Order Number') . qq|</th>
-               <td><input name=cusordnumber size=11 value="$form->{cusordnumber}"></td>
+               <th align="right" nowrap>| . $locale->text('Customer Order Number') . qq|</th>
+               <td><input name="cusordnumber" size="11" value="$form->{cusordnumber}"></td>
              </tr>
              <tr>
           <th align="right" nowrap>| . $locale->text('Project Number') . qq|</th>
@@ -801,37 +777,22 @@ print qq|     <tr>
     <td>
     </td>
   </tr>
-
+| . 
 $jsscript
-
+. qq|
 <!-- shipto are in hidden variables -->
-
-<input type=hidden name=shiptoname value="$form->{shiptoname}">
-<input type=hidden name=shiptostreet value="$form->{shiptostreet}">
-<input type=hidden name=shiptozipcode value="$form->{shiptozipcode}">
-<input type=hidden name=shiptocity value="$form->{shiptocity}">
-<input type=hidden name=shiptocountry value="$form->{shiptocountry}">
-<input type=hidden name=shiptocontact value="$form->{shiptocontact}">
-<input type=hidden name=shiptophone value="$form->{shiptophone}">
-<input type=hidden name=shiptofax value="$form->{shiptofax}">
-<input type=hidden name=shiptoemail value="$form->{shiptoemail}">
-
-<!-- email variables -->
-<input type=hidden name=message value="$form->{message}">
-<input type=hidden name=email value="$form->{email}">
-<input type=hidden name=subject value="$form->{subject}">
-<input type=hidden name=cc value="$form->{cc}">
-<input type=hidden name=bcc value="$form->{bcc}">
-<input type=hidden name=webdav value=$webdav>
-<input type=hidden name=taxaccounts value="$form->{taxaccounts}">
-|;
-
-  foreach $item (split / /, $form->{taxaccounts}) {
-    print qq|
-<input type=hidden name="${item}_rate" value="$form->{"${item}_rate"}">
-<input type=hidden name="${item}_description" value="$form->{"${item}_description"}">
-<input type=hidden name="${item}_taxnumber" value="$form->{"${item}_taxnumber"}">
-|;
+| ;
+map({ print($cgi->hidden("-name" => $_, "-value" => $form->{$_})); } 
+       qw(shiptoname shiptostreet shiptozipcode shiptocity shiptocountry 
+          shiptocontact shiptophone shiptofax shiptoemail));
+print qq|<!-- email variables --> |;
+map({ print($cgi->hidden("-name" => $_, "-value" => $form->{$_})); } 
+    qw(message email subject cc bcc taxaccounts));
+print qq|<input type="hidden" name="webdav" value="| . $webdav . qq|">|;
+
+  foreach $item (split(/ /, $form->{taxaccounts})) {
+    map({ print($cgi->hidden("-name" => $_, "-value" => $form->{$_})); } 
+    ("${item}_rate", "${item}_description", "${item}_taxnumber"));
   }
   $lxdebug->leave_sub();
 }
@@ -849,16 +810,16 @@ sub form_footer {
   }
   $rows = ($rows > $introws) ? $rows : $introws;
   $notes =
-    qq|<textarea name=notes rows=$rows cols=26 wrap=soft>$form->{notes}</textarea>|;
+    qq|<textarea name="notes" rows="$rows" cols="26" wrap="soft">$form->{notes}</textarea>|;
   $intnotes =
-    qq|<textarea name=intnotes rows=$rows cols=35 wrap=soft>$form->{intnotes}</textarea>|;
+    qq|<textarea name="intnotes" rows="$rows" cols="35" wrap="soft">$form->{intnotes}</textarea>|;
 
   $form->{taxincluded} = ($form->{taxincluded}) ? "checked" : "";
 
   $taxincluded = "";
   if ($form->{taxaccounts}) {
     $taxincluded = qq|
-               <input name=taxincluded class=checkbox type=checkbox value=1 $form->{taxincluded}> <b>|
+               <input name="taxincluded" class="checkbox" type="checkbox" value=$form->{taxincluded}> <b>|
       . $locale->text('Tax Included') . qq|</b><br><br>|;
   }
 
@@ -876,9 +837,9 @@ sub form_footer {
 
         $tax .= qq|
              <tr>
-                <th align=right>$form->{"${item}_description"}&nbsp;|
+                <th align="right">$form->{"${item}_description"}&nbsp;|
                                     . $form->{"${item}_rate"} * 100 .qq|%</th>
-               <td align=right>$form->{"${item}_total"}</td>
+               <td align="right">$form->{"${item}_total"}</td>
              </tr>
 |;
       }
@@ -889,8 +850,8 @@ sub form_footer {
 
     $subtotal = qq|
              <tr>
-               <th align=right>| . $locale->text('Subtotal') . qq|</th>
-               <td align=right>$form->{invsubtotal}</td>
+               <th align="right">| . $locale->text('Subtotal') . qq|</th>
+               <td align="right">$form->{invsubtotal}</td>
              </tr>
 |;
 
@@ -916,13 +877,13 @@ sub form_footer {
 
         $tax .= qq|
              <tr>
-               <th align=right>Enthaltene $form->{"${item}_description"}&nbsp;|
+               <th align="right">Enthaltene $form->{"${item}_description"}&nbsp;|
                                    . $form->{"${item}_rate"} * 100 .qq|%</th>
-               <td align=right>$form->{"${item}_total"}</td>
+               <td align="right">$form->{"${item}_total"}</td>
              </tr>
              <tr>
-               <th align=right>Nettobetrag</th>
-               <td align=right>$form->{"${item}_netto"}</td>
+               <th align="right">Nettobetrag</th>
+               <td align="right">$form->{"${item}_netto"}</td>
              </tr>
 |;
       }
@@ -937,31 +898,31 @@ sub form_footer {
   print qq|
   <tr>
     <td>
-      <table width=100%>
-       <tr valign=bottom>
+      <table width="100%">
+       <tr valign="bottom">
          <td>
            <table>
              <tr>
-               <th align=left>| . $locale->text('Notes') . qq|</th>
-               <th align=left>| . $locale->text('Internal Notes') . qq|</th>
-                <th align=right>| . $locale->text('Payment Terms') . qq|</th>
+               <th align="left">| . $locale->text('Notes') . qq|</th>
+               <th align="left">| . $locale->text('Internal Notes') . qq|</th>
+                <th align="right">| . $locale->text('Payment Terms') . qq|</th>
              </tr>
-             <tr valign=top>
+             <tr valign="top">
                <td>$notes</td>
                <td>$intnotes</td>
-                <td><select name=payment_id onChange="if (this.value) set_duedate(['payment_id__' + this.value],['duedate'])">$payment
+                <td><select name="payment_id" onChange="if (this.value) set_duedate(['payment_id__' + this.value],['duedate'])">$payment
                 </select></td>
              </tr>
            </table>
          </td>
-         <td align=right width=100%>
+         <td align="right" width="100%">
            $taxincluded
-           <table width=100%>
+           <table width="100%">
              $subtotal
              $tax
              <tr>
-               <th align=right>| . $locale->text('Total') . qq|</th>
-               <td align=right>$form->{invtotal}</td>
+               <th align="right">| . $locale->text('Total') . qq|</th>
+               <td align="right">$form->{invtotal}</td>
              </tr>
            </table>
          </td>
@@ -973,20 +934,20 @@ sub form_footer {
   if ($webdav) {
     $webdav_list = qq|
   <tr>
-    <td><hr size=3 noshade></td>
+    <td><hr size="3" noshade></td>
   </tr>
   <tr>
-    <th class=listtop align=left>Dokumente im Webdav-Repository</th>
+    <th class="listtop" align="left">Dokumente im Webdav-Repository</th>
   </tr>
-    <table width=100%>
-      <td align=left width=30%><b>Dateiname</b></td>
-      <td align=left width=70%><b>Webdavlink</b></td>
+    <table width="100%">
+      <td align="left" width="30%"><b>Dateiname</b></td>
+      <td align="left" width="70%"><b>Webdavlink</b></td>
 |;
     foreach $file (keys %{ $form->{WEBDAV} }) {
       $webdav_list .= qq|
       <tr>
-        <td align=left>$file</td>
-        <td align=left><a href="$form->{WEBDAV}{$file}">$form->{WEBDAV}{$file}</a></td>
+        <td align="left">$file</td>
+        <td align="left"><a href="$form->{WEBDAV}{$file}">$form->{WEBDAV}{$file}</a></td>
       </tr>
 |;
     }
@@ -1001,9 +962,9 @@ if ($form->{type} eq "credit_note") {
   print qq|
   <tr>
     <td>
-      <table width=100%>
-       <tr class=listheading>
-         <th colspan=6 class=listheading>|
+      <table width="100%">
+       <tr class="listheading">
+         <th colspan="6" class="listheading">|
     . $locale->text('Payments') . qq|</th>
        </tr>
 |;
@@ -1011,9 +972,9 @@ if ($form->{type} eq "credit_note") {
   print qq|
   <tr>
     <td>
-      <table width=100%>
-       <tr class=listheading>
-         <th colspan=6 class=listheading>|
+      <table width="100%">
+       <tr class="listheading">
+         <th colspan="6" class="listheading">|
     . $locale->text('Incoming Payments') . qq|</th>
        </tr>
 |;
@@ -1064,30 +1025,26 @@ if ($form->{type} eq "credit_note") {
     $exchangerate = qq|&nbsp;|;
     if ($form->{currency} ne $form->{defaultcurrency}) {
       if ($form->{"forex_$i"}) {
-        $exchangerate =
-          qq|<input type=hidden name="exchangerate_$i" value=$form->{"exchangerate_$i"}>$form->{"exchangerate_$i"}|;
+        $exchangerate = qq|<input type="hidden" name="exchangerate_$i" value="$form->{"exchangerate_$i"}">$form->{"exchangerate_$i"}|;
       } else {
-        $exchangerate =
-          qq|<input name="exchangerate_$i" size=10 value=$form->{"exchangerate_$i"}>|;
+        $exchangerate = qq|<input name="exchangerate_$i" size="10" value="$form->{"exchangerate_$i"}">|;
       }
     }
 
-    $exchangerate .= qq|
-<input type=hidden name="forex_$i" value=$form->{"forex_$i"}>
-|;
+    $exchangerate .= qq|<input type="hidden" name="forex_$i" value="$form->{"forex_$i"}">|;
 
     $column_data{"paid_$i"} =
-      qq|<td align=center><input name="paid_$i" size=11 value=$form->{"paid_$i"}></td>|;
-    $column_data{"exchangerate_$i"} = qq|<td align=center>$exchangerate</td>|;
+      qq|<td align="center"><input name="paid_$i" size="11" value="$form->{"paid_$i"}"></td>|;
+    $column_data{"exchangerate_$i"} = qq|<td align="center">$exchangerate</td>|;
     $column_data{"AR_paid_$i"}      =
-      qq|<td align=center><select name="AR_paid_$i">$form->{"selectAR_paid_$i"}</select></td>|;
+      qq|<td align="center"><select name="AR_paid_$i">$form->{"selectAR_paid_$i"}</select></td>|;
     $column_data{"datepaid_$i"} =
-      qq|<td align=center><input id="datepaid_$i" name="datepaid_$i"  size=11 title="$myconfig{dateformat}" value=$form->{"datepaid_$i"}>
+      qq|<td align="center"><input id="datepaid_$i" name="datepaid_$i"  size="11" title="$myconfig{dateformat}" value=$form->{"datepaid_$i"}>
          <input type="button" name="datepaid_$i" id="trigger_datepaid_$i" value="?"></td>|;
     $column_data{"source_$i"} =
-      qq|<td align=center><input name="source_$i" size=11 value="$form->{"source_$i"}"></td>|;
+      qq|<td align=center><input name="source_$i" size="11" value="$form->{"source_$i"}"></td>|;
     $column_data{"memo_$i"} =
-      qq|<td align=center><input name="memo_$i" size=11 value="$form->{"memo_$i"}"></td>|;
+      qq|<td align="center"><input name="memo_$i" size="11" value="$form->{"memo_$i"}"></td>|;
 
     map { print qq|$column_data{"${_}_$i"}\n| } @column_index;
     print "
@@ -1095,16 +1052,13 @@ if ($form->{type} eq "credit_note") {
     push(@triggers, "datepaid_$i", "BL", "trigger_datepaid_$i");
   }
 
-  print qq|
-<input type=hidden name=paidaccounts value=$form->{paidaccounts}>
-<input type=hidden name=selectAR_paid value="$form->{selectAR_paid}">
-<input type=hidden name=oldinvtotal value=$form->{oldinvtotal}>
-<input type=hidden name=oldtotalpaid value=$totalpaid>
+  map({ print($cgi->hidden("-name" => $_, "-value" => $form->{$_})); } qw(paidaccounts selectAR_paid oldinvtotal)); 
+  print qq|<input type="hidden" name="oldtotalpaid" value="$totalpaid">
     </table>
     </td>
   </tr>
   <tr>
-    <td><hr size=3 noshade></td>
+    <td><hr size="3" noshade></td>
   </tr>
   <tr>
     <td>
@@ -1125,31 +1079,31 @@ if ($form->{type} eq "credit_note") {
     my $show_storno = !$form->{storno} && !IS->has_storno(\%myconfig, $form, "ar");
 
     print qq|
-    <input class=submit type=submit accesskey="u" name=action id=update_button value="|
+    <input class="submit" type="submit" accesskey="u" name="action" id="update_button" value="|
       . $locale->text('Update') . qq|">
-    <input class=submit type=submit name=action value="|
+    <input class="submit" type="submit" name="action" value="|
       . $locale->text('Ship to') . qq|">
-    <input class=submit type=submit name=action value="|
+    <input class="submit" type="submit" name="action" value="|
       . $locale->text('Print') . qq|">
-    <input class=submit type=submit name=action value="|
+    <input class="submit" type="submit" name="action" value="|
       . $locale->text('E-mail') . qq|"> |;
-    print qq|<input class=submit type=submit name=action value="|
+    print qq|<input class="submit" type="submit" name="action" value="|
       . $locale->text('Storno') . qq|"> | if ($show_storno);
-    print qq|<input class=submit type=submit name=action value="|
+    print qq|<input class="submit" type="submit" name="action" value="|
       . $locale->text('Post Payment') . qq|">
 |;
-    print qq|<input class=submit type=submit name=action value="|
+    print qq|<input class="submit" type="submit" name="action" value="|
       . $locale->text('Use As Template') . qq|">
 |;
   if ($form->{id} && !($form->{type} eq "credit_note")) {
     print qq|
-    <input class=submit type=submit name=action value="|
+    <input class="submit" type="submit" name="action" value="|
       . $locale->text('Credit Note') . qq|">
 |;
   }
     if ($form->{radier}) {
     print qq|
-    <input class=submit type=submit name=action value="|
+    <input class="submit" type="submit" name="action" value="|
       . $locale->text('Delete') . qq|">
 |;
   }
@@ -1157,24 +1111,24 @@ if ($form->{type} eq "credit_note") {
 
     if ($invdate > $closedto) {
       print qq|
-      <input class=submit type=submit name=action value="|
+      <input class="submit" type="submit" name="action" value="|
         . $locale->text('Order') . qq|">
 |;
     }
 
   } else {
     if ($invdate > $closedto) {
-      print qq|<input class=submit type=submit name=action id=update_button value="|
+      print qq|<input class="submit" type="submit" name="action" id="update_button" value="|
         . $locale->text('Update') . qq|">
-      <input class=submit type=submit name=action value="|
+      <input class="submit" type="submit" name="action" value="|
         . $locale->text('Ship to') . qq|">
-      <input class=submit type=submit name=action value="|
+      <input class="submit" type="submit" name="action" value="|
         . $locale->text('Preview') . qq|">
-      <input class=submit type=submit name=action value="|
+      <input class="submit" type="submit" name="action" value="|
         . $locale->text('E-mail') . qq|">
-      <input class=submit type=submit name=action value="|
+      <input class="submit" type="submit" name="action" value="|
         . $locale->text('Print and Post') . qq|">
-      <input class=submit type=submit name=action value="|
+      <input class="submit" type="submit" name="action" value="|
         . $locale->text('Post') . qq|"> | .
         NTI($cgi->submit('-name' => 'action', '-value' => $locale->text('Save draft'),
                          '-class' => 'submit'));
@@ -1196,17 +1150,13 @@ if ($form->{type} eq "credit_note") {
   print $form->write_trigger(\%myconfig, scalar(@triggers) / 3, @triggers) .
     qq|
 
-<input type=hidden name=rowcount value=$form->{rowcount}>
-
-<input name=callback type=hidden value="$form->{callback}">
-|
+<input type="hidden" name="rowcount" value="$form->{rowcount}">
+| .
+$cgi->hidden("-name" => "callback", "-value" => $form->{callback}) 
 . $cgi->hidden('-name' => 'draft_id', '-default' => [$form->{draft_id}])
-. $cgi->hidden('-name' => 'draft_description', '-default' => [$form->{draft_description}])
-. qq|
-<input type=hidden name=path value=$form->{path}>
-<input type=hidden name=login value=$form->{login}>
-<input type=hidden name=password value=$form->{password}>
-
+. $cgi->hidden('-name' => 'draft_description', '-default' => [$form->{draft_description}]);
+map({ print $cgi->hidden("-name" => $_ , "-value" => $form->{$_});} qw(path login password));
+print qq|
 </form>
 
 </body>
@@ -1566,7 +1516,7 @@ sub delete {
   print qq|
 <body>
 
-<form method=post action=$form->{script}>
+<form method="post" action="$form->{script}">
 |;
 
   # delete action variable
@@ -1574,11 +1524,11 @@ sub delete {
 
   foreach $key (keys %$form) {
     $form->{$key} =~ s/\"/&quot;/g;
-    print qq|<input type=hidden name=$key value="$form->{$key}">\n|;
+    print qq|<input type="hidden" name="$key" value="$form->{$key}">\n|;
   }
 
   print qq|
-<h2 class=confirm>| . $locale->text('Confirm!') . qq|</h2>
+<h2 class="confirm">| . $locale->text('Confirm!') . qq|</h2>
 
 <h4>|
     . $locale->text('Are you sure you want to delete Invoice Number')
@@ -1586,7 +1536,7 @@ sub delete {
 </h4>
 
 <p>
-<input name=action class=submit type=submit value="|
+<input name="action" class="submit" type="submit" value="|
     . $locale->text('Yes') . qq|">
 </form>
 |;
Unnamed repository; edit this file 'description' to name the repository.