From: Moritz Bunkus <m.bunkus@linet-services.de>
Date: Wed, 8 Jun 2016 14:05:09 +0000 (+0200)
Subject: generic_translations: DB-Upgrade in Perl geschrieben wg. Constraint-Namen
X-Git-Tag: release-3.4.1~88
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=086e9880b6aeb6c3e95bcf4a4a84b985909346df;p=kivitendo-erp.git

generic_translations: DB-Upgrade in Perl geschrieben wg. Constraint-Namen

In alten PostgreSQL-Versionen hießen Foreign-Key-Constraints oft noch so
was wie »$1«. Da sich das Upgrade-Script also bzgl. des Namens nicht
sicher sein kann, gibt's momentan nur die Möglichkeit, einmal alle
Foreign-Keys zu einer Tabelle wegzuwerfen und diese neu anzulegen.

Dafür wiederum haben wir Support-Funktionen in SL::DBUpgrade2::Base, die
wie nutzen können. Also Umstellung des Scripts auf Perl.
---

diff --git a/sql/Pg-upgrade2/delete_from_generic_translations_on_language_deletion.pl b/sql/Pg-upgrade2/delete_from_generic_translations_on_language_deletion.pl
new file mode 100644
index 000000000..24ee4ebad
--- /dev/null
+++ b/sql/Pg-upgrade2/delete_from_generic_translations_on_language_deletion.pl
@@ -0,0 +1,35 @@
+# @tag: delete_from_generic_translations_on_language_deletion
+# @description: Übersetzungen automatisch löschen, wenn die dazugehörige Sprache gelöscht wird
+# @depends: release_3_4_0
+package SL::DBUpgrade2::delete_from_generic_translations_on_language_deletion;
+
+use strict;
+use utf8;
+
+use parent qw(SL::DBUpgrade2::Base);
+
+sub run {
+  my ($self) = @_;
+
+  $self->drop_constraints(table => 'generic_translations');
+
+  $self->db_query(<<SQL);
+    ALTER TABLE generic_translations
+    ADD CONSTRAINT generic_translations_language_id_fkey
+      FOREIGN KEY (language_id)
+      REFERENCES language (id)
+      ON DELETE CASCADE
+SQL
+
+  $self->db_query(<<SQL);
+    DELETE FROM generic_translations
+    WHERE language_id NOT IN (
+      SELECT id
+      FROM language
+    )
+SQL
+
+  return 1;
+}
+
+1;
diff --git a/sql/Pg-upgrade2/delete_from_generic_translations_on_language_deletion.sql b/sql/Pg-upgrade2/delete_from_generic_translations_on_language_deletion.sql
deleted file mode 100644
index 94cca1b08..000000000
--- a/sql/Pg-upgrade2/delete_from_generic_translations_on_language_deletion.sql
+++ /dev/null
@@ -1,15 +0,0 @@
--- @tag: delete_from_generic_translations_on_language_deletion
--- @description: Übersetzungen automatisch löschen, wenn die dazugehörige Sprache gelöscht wird
--- @depends: release_3_4_0
-ALTER TABLE generic_translations
-  DROP CONSTRAINT generic_translations_language_id_fkey,
-  ADD CONSTRAINT generic_translations_language_id_fkey
-    FOREIGN KEY (language_id)
-    REFERENCES language (id)
-    ON DELETE CASCADE;
-
-DELETE FROM generic_translations
-WHERE language_id NOT IN (
-  SELECT id
-  FROM language
-);