From: G. Richardson <information@kivitendo-premium.de>
Date: Sat, 4 Jan 2014 19:47:51 +0000 (+0100)
Subject: Dialogbuchen: Bug in updateTaxes behoben und Code vereinfacht
X-Git-Tag: release-3.1.0beta1~22^2~62^2
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=0c31c55d2a8ff03f2d6252d7a6cd1f4fded5ec12;p=kivitendo-erp.git

Dialogbuchen: Bug in updateTaxes behoben und Code vereinfacht

im Javascript hieß die Variable selected_index, im Template
select_index. Beide wurden umbenannt in default_tax_id.

Der Value des Konto-Dropdowns enthält Daten in der Form "accno--tax_id".

Diese beiden Information werden per JS geparsed, und reichen schon aus,
damit der der ajax-Aufruf bei Wechsel des Kontos das entsprechende
Steuerdropdown austauschen und mit der Defaultsteuer des neuen Kontos
vorbelegen kann.
---

diff --git a/templates/webpages/gl/form_header.html b/templates/webpages/gl/form_header.html
index ec175696d..98bb8f067 100644
--- a/templates/webpages/gl/form_header.html
+++ b/templates/webpages/gl/form_header.html
@@ -8,18 +8,15 @@ function updateTaxes(row)
 {
   var accno  = document.getElementById('accno_' + row);
   var taxkey = accno.options[accno.selectedIndex].value;
-  var reg = /--([0-9]*)/;
+  var reg = /^(.*?)--(\d*)$/;
   var found = reg.exec(taxkey);
-  var index = found[1];
-  index = parseInt(index);
-  var tax = 'taxchart_' + row;
-  var taxkeyposition = taxkey.lastIndexOf(found[0]);
-  var account = taxkey.substr(0, taxkeyposition);
+  var account = found[1];
+  var default_tax_id = found[2];
 
   $.ajax({
     url: 'gl.pl?action=get_tax_dropdown',
     data: { accno: account,
-            selected_index: index},
+            selected_tax_id: default_tax_id},
     dataType: 'html',
     success: function (new_html) {
                                 $("#taxchart_" + row).html(new_html);
diff --git a/templates/webpages/gl/update_tax_accounts.html b/templates/webpages/gl/update_tax_accounts.html
index 940d34dfe..d3c9586b2 100644
--- a/templates/webpages/gl/update_tax_accounts.html
+++ b/templates/webpages/gl/update_tax_accounts.html
@@ -1,3 +1,4 @@
+[% USE L %]
 [% FOR row = TAX_ACCOUNTS %]
-<option value='[% row.id %]--[% row.rate %]' [% IF row.id == select_index %]selected[% END %]>[% row.taxdescription %] %</option>
+<option value='[% row.id %]--[% row.rate %]'[% IF row.id == selected_tax_id%] selected[% END %]>[% row.taxdescription %] %</option>
 [% END %]