From: Sven Schöling <s.schoeling@linet-services.de>
Date: Mon, 15 Jun 2015 13:46:59 +0000 (+0200)
Subject: Tests: Indirekte Objektnotation für Instanzierung verbieten.
X-Git-Tag: release-3.3.0beta~50
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=258119bf167d625d33dfe672d5379a0945e11f27;p=kivitendo-erp.git

Tests: Indirekte Objektnotation für Instanzierung verbieten.
---

diff --git a/t/structure/no_indirect_object_notation.t b/t/structure/no_indirect_object_notation.t
new file mode 100644
index 000000000..f0a54d9f6
--- /dev/null
+++ b/t/structure/no_indirect_object_notation.t
@@ -0,0 +1,58 @@
+use strict;
+use lib 't';
+use Support::Files;
+use Test::More;
+
+if (eval { require PPI; 1 }) {
+  plan tests => scalar(@Support::Files::testitems);
+} else {
+  plan skip_all => "PPI not installed";
+}
+
+my @testitems = @Support::Files::testitems;
+
+foreach my $file (@testitems) {
+  my $clean = 1;
+  my $source;
+  {
+    # due to a bug in PPI it cannot determine the encoding of a source file by
+    # use utf8; normaly this would be no problem but some people instist on
+    # putting strange stuff into the source. as a workaround read in the source
+    # with :utf8 layer and pass it to PPI by reference
+    # there are still some latin chars, but it's not the purpose of this test
+    # to find them, so warnings about it will be ignored
+    local $^W = 0; # don't care about invalid chars in comments
+    local $/ = undef;
+    open my $fh, '<:utf8', $file or die $!;
+    $source = <$fh>;
+  }
+
+  my $doc = PPI::Document->new(\$source) or do {
+    print "?: PPI error for file $file: " . PPI::Document::errstr() . "\n";
+    ok 0, $file;
+    next;
+  };
+  my $stmts = $doc->find(sub { $_[1]->isa('PPI::Token::Word') && $_[1]->content eq 'new' });
+
+  for my $stmt (@{ $stmts || [] }) {
+    my @schildren = $stmt->parent->schildren;
+    for (0..$#schildren-1) {
+      my $this = $schildren[$_];
+      my $next = $schildren[$_+1];
+
+      next unless $this->isa('PPI::Token::Word');
+      next unless $this->content eq 'new';
+      next unless $next->isa('PPI::Token::Word');
+
+      # suspicious. 2 barewords in a row, with the first being 'new'
+      # but maybe its somethiing like: Obj->new param1 => ...
+      # check if the one before exists and is a ->
+      next if $_ == 0 || ($schildren[$_-1]->isa('PPI::Token::Operator') && $schildren[$_-1]->content eq '->');
+
+      $clean = 0;
+      print "?: @{[ $this->content, $next->content ]} \n";
+    }
+  }
+
+  ok $clean, $file;
+}