From: Martin Helmling martin.helmling@octosoft.eu <martin.helmling@octosoft.eu>
Date: Wed, 4 Jan 2017 09:30:20 +0000 (+0100)
Subject: Abfangen von leerer warehouse_id bevor Objekt gesucht wird
X-Git-Tag: release-3.5.4~1773
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=3a8e5bda9aeca9faf1a5278bc14324104d4db5c8;hp=f2cee1250cf2604954dbc8fac64f0d1643393ecd;p=kivitendo-erp.git

Abfangen von leerer warehouse_id bevor Objekt gesucht wird

Will man kein Default Lager einstellen kommt es zu einem Rose Fehler.
Nun wird verfahren wie wenn Lager nicht gefunden wird.
---

diff --git a/SL/Controller/Part.pm b/SL/Controller/Part.pm
index 6b40493f4..23b4eff1e 100644
--- a/SL/Controller/Part.pm
+++ b/SL/Controller/Part.pm
@@ -457,20 +457,23 @@ sub action_reorder_items {
 sub action_warehouse_changed {
   my ($self) = @_;
 
-  $self->warehouse(SL::DB::Manager::Warehouse->find_by_or_create(id => $::form->{warehouse_id}));
-  die unless ref($self->warehouse) eq 'SL::DB::Warehouse';
-
-  if ( $self->warehouse->id and @{$self->warehouse->bins} ) {
-    $self->bin($self->warehouse->bins->[0]);
-    $self->js
-      ->html('#bin', $self->build_bin_select)
-      ->focus('#part_bin_id');
-  } else {
-    # no warehouse was selected, empty the bin field and reset the id
-    $self->js
-        ->val('#part_bin_id', undef)
-        ->html('#bin', '');
-  };
+  if ($::form->{warehouse_id} ) {
+    $self->warehouse(SL::DB::Manager::Warehouse->find_by_or_create(id => $::form->{warehouse_id}));
+    die unless ref($self->warehouse) eq 'SL::DB::Warehouse';
+
+    if ( $self->warehouse->id and @{$self->warehouse->bins} ) {
+      $self->bin($self->warehouse->bins->[0]);
+      $self->js
+        ->html('#bin', $self->build_bin_select)
+        ->focus('#part_bin_id');
+      return $self->js->render;
+    }
+  }
+
+  # no warehouse was selected, empty the bin field and reset the id
+  $self->js
+       ->val('#part_bin_id', undef)
+       ->html('#bin', '');
 
   return $self->js->render;
 }