From: Sven Schöling <s.schoeling@linet-services.de>
Date: Tue, 2 Aug 2016 08:50:25 +0000 (+0200)
Subject: ARAP: single-dbh
X-Git-Tag: release-3.5.4~2089
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=5ad7e1ed10430c3e9fbe4e9c9cfcbd409e547251;p=kivitendo-erp.git

ARAP: single-dbh
---

diff --git a/SL/ARAP.pm b/SL/ARAP.pm
index 977eefb4a..4d5c564aa 100644
--- a/SL/ARAP.pm
+++ b/SL/ARAP.pm
@@ -4,6 +4,7 @@ use SL::AM;
 use SL::Common;
 use SL::DBUtils;
 use SL::MoreCommon;
+use SL::DB;
 use Data::Dumper;
 
 use strict;
@@ -19,7 +20,7 @@ sub close_orders_if_billed {
   my $myconfig  = \%main::myconfig;
   my $form      = $main::form;
 
-  my $dbh       = $params{dbh} || $form->get_standard_dbh($myconfig);
+  my $dbh       = $params{dbh} || SL::DB->client->dbh;
 
   # First, find all order IDs from which this invoice has been
   # created. Either directly by a conversion from an order to this invoice
@@ -150,10 +151,10 @@ sub close_orders_if_billed {
 
   # Close orders that have been billed fully.
   if (scalar @close_oe_ids) {
-    my $query = qq|UPDATE oe SET closed = TRUE WHERE id IN (| . join(', ', ('?') x scalar @close_oe_ids) . qq|)|;
-    do_query($form, $dbh, $query, @close_oe_ids);
-
-    $dbh->commit unless $params{dbh};
+    SL::DB->client->with_transaction(sub {
+      my $query = qq|UPDATE oe SET closed = TRUE WHERE id IN (| . join(', ', ('?') x scalar @close_oe_ids) . qq|)|;
+      do_query($form, $dbh, $query, @close_oe_ids);
+    });
   }
 
   $main::lxdebug->leave_sub();