From: Nik Okuntseff Date: Sat, 1 Dec 2018 17:32:37 +0000 (+0000) Subject: Resuming refactoring for subgroup support. X-Git-Tag: timetracker_1.19-1~508 X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=5be0f37534b82691a7707cde3aeb3d0b41fd71e5;p=timetracker.git Resuming refactoring for subgroup support. --- diff --git a/WEB-INF/templates/clients.tpl b/WEB-INF/templates/clients.tpl index a31a8cd0..2e8b2b82 100644 --- a/WEB-INF/templates/clients.tpl +++ b/WEB-INF/templates/clients.tpl @@ -6,6 +6,15 @@ {if $user->can('manage_clients')} + {if $group_dropdown} +{$forms.clientsForm.open} {* clientsForm consists only of one dropdown group control *} + + + + +
{$i18n.label.group}: {$forms.clientsForm.group.control}
+{$forms.clientsForm.close} + {/if} {if $inactive_clients} diff --git a/WEB-INF/templates/footer.tpl b/WEB-INF/templates/footer.tpl index 071a29a4..1a9987d8 100644 --- a/WEB-INF/templates/footer.tpl +++ b/WEB-INF/templates/footer.tpl @@ -12,7 +12,7 @@
{$i18n.form.clients.active_clients}
-
 Anuko Time Tracker 1.18.29.4556 | Copyright © Anuko | +  Anuko Time Tracker 1.18.29.4557 | Copyright © Anuko | {$i18n.footer.credits} | {$i18n.footer.license} | {$i18n.footer.improve} diff --git a/clients.php b/clients.php index 6bf48097..ca83efd9 100644 --- a/clients.php +++ b/clients.php @@ -39,13 +39,45 @@ if (!$user->isPluginEnabled('cl')) { header('Location: feature_disabled.php'); exit(); } +if ($request->isPost()) { + $groupChanged = $request->getParameter('group_changed'); // Reused in multiple places below. + if ($groupChanged && !($user->can('manage_subgroups') && $user->isGroupValid($request->getParameter('group')))) { + header('Location: access_denied.php'); // Group changed, but no rght or wrong group id. + exit(); + } +} + +// Determine group for which we display this page. +if ($request->isPost() && $groupChanged) { + $group_id = $request->getParameter('group'); + $user->setOnBehalfGroup($group_id); +} else { + $group_id = $user->getGroup(); +} + +$form = new Form('clientsForm'); +if ($user->can('manage_subgroups')) { + $groups = $user->getGroupsForDropdown(); + if (count($groups) > 1) { + $form->addInput(array('type'=>'combobox', + 'onchange'=>'document.clientsForm.group_changed.value=1;document.clientsForm.submit();', + 'name'=>'group', + 'style'=>'width: 250px;', + 'value'=>$group_id, + 'data'=>$groups, + 'datakeys'=>array('id','name'))); + $form->addInput(array('type'=>'hidden','name'=>'group_changed')); + $smarty->assign('group_dropdown', 1); + } +} if($user->can('manage_clients')) { - $active_clients = ttTeamHelper::getActiveClients($user->group_id, true); - $inactive_clients = ttTeamHelper::getInactiveClients($user->group_id, true); + $active_clients = ttTeamHelper::getActiveClients($user->getGroup(), true); + $inactive_clients = ttTeamHelper::getInactiveClients($user->getGroup(), true); } else $active_clients = $user->getAssignedClients(); +$smarty->assign('forms', array($form->getName()=>$form->toArray())); $smarty->assign('active_clients', $active_clients); $smarty->assign('inactive_clients', $inactive_clients); $smarty->assign('title', $i18n->get('title.clients'));