From: Sven Schöling <s.schoeling@linet-services.de>
Date: Wed, 9 Dec 2009 15:32:50 +0000 (+0100)
Subject: Neuer Subtest in 002goodperl.t: .pl und .pm Dateien sollen keine HTML Tags enthalten.
X-Git-Tag: release-2.6.1beta1~72^2~18
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=8332f18114bf31468d886c634cfc889647bae8ef;p=kivitendo-erp.git

Neuer Subtest in 002goodperl.t: .pl und .pm Dateien sollen keine HTML Tags enthalten.

Test ist recht simpel, funktioniert aber um das meiste aufzudenken.
---

diff --git a/t/002goodperl.t b/t/002goodperl.t
index cc3971372..f081ac719 100644
--- a/t/002goodperl.t
+++ b/t/002goodperl.t
@@ -32,7 +32,7 @@ use lib 't';
 
 use Support::Files;
 
-use Test::More tests => scalar @Support::Files::testitems * 2;
+use Test::More tests => scalar @Support::Files::testitems * 3;
 
 my @testitems = @Support::Files::testitems; # get the files to test.
 
@@ -103,4 +103,35 @@ foreach my $file (@testitems) {
     }
 }
 
+
+# note, the html checker is not really thorough.
+# in particular it will not find standard tags with parameters.
+# the estimate wether a file is dirty or not is still pretty helpful, as it will catch most of the closing tags.
+# if you are in doubt about a specific file, you still have to check it manually.
+my $tags = qr/b|i|u|h[1-6]|a href.*|input|form|br|textarea|table|tr|td|th|body|head|html|p|button|select|option|script/;
+foreach my $file (@testitems) {
+    my $found_html_count = 0;
+    my $found_html       = '';
+    $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
+    next if (!$file); # skip null entries
+    if (! open (FILE, $file)) {
+        ok(0,"could not open $file --WARNING");
+        next;
+    }
+    while (my $file_line = <FILE>) {
+        if ($file_line =~ m/(<\/?$tags>)/) {
+            $found_html_count++;
+            $found_html .= $1;
+        }
+    }
+    close (FILE);
+    if (!$found_html_count) {
+        ok(1,"$file does not contain HTML");
+    } else {
+    TODO: { local $TODO = q(Templating is not final.);
+        ok(0,"$file contains at least $found_html_count html tags.");
+      }
+    }
+}
+
 exit 0;