From: Nik Okuntseff <support@anuko.com>
Date: Mon, 28 Mar 2016 16:27:17 +0000 (+0000)
Subject: Refactoring, reorganized code a bit
X-Git-Tag: timetracker_1.19-1~1777
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=abe3a7f279615f45b4bf0072a1b041ff651eeebc;p=timetracker.git

Refactoring, reorganized code a bit
---

diff --git a/WEB-INF/lib/ttReportHelper.class.php b/WEB-INF/lib/ttReportHelper.class.php
index 96dd24f0..a7044224 100644
--- a/WEB-INF/lib/ttReportHelper.class.php
+++ b/WEB-INF/lib/ttReportHelper.class.php
@@ -383,42 +383,41 @@ class ttReportHelper {
 
     // Obtain items for report.
     $res = $mdb2->query($sql);
-    if (!is_a($res, 'PEAR_Error')) {
-      while ($val = $res->fetchRow()) {
-        if ($convertTo12Hour) {
-          if($val['start'] != '')
-            $val['start'] = ttTimeHelper::to12HourFormat($val['start']);
-          if($val['finish'] != '')
-            $val['finish'] = ttTimeHelper::to12HourFormat($val['finish']);
-        }
-        if (isset($val['cost'])) {
-          if ('.' != $user->decimal_mark)
-            $val['cost'] = str_replace('.', $user->decimal_mark, $val['cost']);
-        }
-        if (isset($val['expense'])) {
-          if ('.' != $user->decimal_mark)
-            $val['expense'] = str_replace('.', $user->decimal_mark, $val['expense']);
-        }
-        if ('no_grouping' != $group_by_option) {
-          $val['grouped_by'] = $val[$group_by_option];
-          if ('date' == $group_by_option) {
-            // This is needed to get the date in user date format.
-            $o_date = new DateAndTime(DB_DATEFORMAT, $val['grouped_by']);
-            $val['grouped_by'] = $o_date->toString($user->date_format);
-            unset($o_date);
-          }
+    if (is_a($res, 'PEAR_Error')) die($res->getMessage());
+
+    while ($val = $res->fetchRow()) {
+      if ($convertTo12Hour) {
+        if($val['start'] != '')
+          $val['start'] = ttTimeHelper::to12HourFormat($val['start']);
+        if($val['finish'] != '')
+          $val['finish'] = ttTimeHelper::to12HourFormat($val['finish']);
+      }
+      if (isset($val['cost'])) {
+        if ('.' != $user->decimal_mark)
+          $val['cost'] = str_replace('.', $user->decimal_mark, $val['cost']);
+      }
+      if (isset($val['expense'])) {
+        if ('.' != $user->decimal_mark)
+          $val['expense'] = str_replace('.', $user->decimal_mark, $val['expense']);
+      }
+      if ('no_grouping' != $group_by_option) {
+        $val['grouped_by'] = $val[$group_by_option];
+        if ('date' == $group_by_option) {
+          // This is needed to get the date in user date format.
+          $o_date = new DateAndTime(DB_DATEFORMAT, $val['grouped_by']);
+          $val['grouped_by'] = $o_date->toString($user->date_format);
+          unset($o_date);
         }
+      }
 
-        // This is needed to get the date in user date format.
-        $o_date = new DateAndTime(DB_DATEFORMAT, $val['date']);
-        $val['date'] = $o_date->toString($user->date_format);
-        unset($o_date);
+      // This is needed to get the date in user date format.
+      $o_date = new DateAndTime(DB_DATEFORMAT, $val['date']);
+      $val['date'] = $o_date->toString($user->date_format);
+      unset($o_date);
 
-        $row = $val;
-        $report_items[] = $row;
-      }
-    } else
-      die($res->getMessage());
+      $row = $val;
+      $report_items[] = $row;
+    }
 
     return $report_items;
   }