From: Jan Büren <jan@kivitendo-premium.de>
Date: Mon, 4 Jun 2018 09:04:57 +0000 (+0200)
Subject: SelfTest false positive vermeiden
X-Git-Tag: release-3.5.4~398
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=b4cc349b7fe50744832261c8b415bd146bde5520;p=kivitendo-erp.git

SelfTest false positive vermeiden

$self->all_passed enthält nicht mehr den Zustand, ob alle
Tests erfolgreich waren. Als Workaround auf zwei negativ
Status-Meldungen prüfen, die bei Problemen gesetzt sind.
---

diff --git a/SL/BackgroundJob/SelfTest.pm b/SL/BackgroundJob/SelfTest.pm
index b34b71d65..d4465721f 100644
--- a/SL/BackgroundJob/SelfTest.pm
+++ b/SL/BackgroundJob/SelfTest.pm
@@ -63,8 +63,9 @@ sub run {
              $self->aggreg->failed,
              $self->aggreg->todo_passed,
   );
-
-  if (!$self->aggreg->all_passed || $self->config->{send_email_on_success}) {
+  # if (!$self->aggreg->all_passed || $self->config->{send_email_on_success}) {
+  # all_passed is not set or calculated (anymore). it is safe to check only for probs or errors
+  if ($self->aggreg->has_problems || $self->aggreg->has_errors || $self->config->{send_email_on_success}) {
     $self->_send_email;
   }