From: Moritz Bunkus <m.bunkus@linet-services.de>
Date: Thu, 29 Mar 2007 06:31:13 +0000 (+0000)
Subject: Falsche Verwendung einer neu eingeführten Datenbankhilfsfunktion, die zu einer Endlos... 
X-Git-Tag: release-2.4.3^2~560
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=e33a252f4725047d717297044b218d075abca3d8;p=kivitendo-erp.git

Falsche Verwendung einer neu eingeführten Datenbankhilfsfunktion, die zu einer Endlosschleife geführt hat.
---

diff --git a/SL/IR.pm b/SL/IR.pm
index e99a108cf..9a6ca9ddc 100644
--- a/SL/IR.pm
+++ b/SL/IR.pm
@@ -1013,13 +1013,15 @@ sub get_vendor {
 
   $query = qq|SELECT o.amount,
                 (SELECT e.sell FROM exchangerate e 
-                 WHERE e.curr = o.curr AND e.transdate = o.transdate)
+                 WHERE e.curr = o.curr AND e.transdate = o.transdate) AS exch
 	      FROM oe o WHERE o.vendor_id = ?  
                 AND o.quotation = '0' AND o.closed = '0'|;
-  while (my ($amount, $exch) = selectfirst_array_query($form, $dbh, $query, $form->{vendor_id})) {
+  my $sth = prepare_execute_query($form, $dbh, $query, $form->{vendor_id});
+  while (my ($amount, $exch) = $sth->fetchrow_array()) {
     $exch = 1 unless $exch;
     $form->{creditremaining} -= $amount * $exch;
   }
+  $sth->finish();
 
   # get shipto if we do not convert an order or invoice
   if (!$form->{shipto}) {