From: Moritz Bunkus <m.bunkus@linet-services.de>
Date: Wed, 9 Nov 2016 10:06:05 +0000 (+0100)
Subject: ActionBar: Setup in is.pl in eigene Funktion ausgelagert
X-Git-Tag: release-3.5.4~1369
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=e46a3e2747cf08aa2e4d76af6b38267060015fa7;p=kivitendo-erp.git

ActionBar: Setup in is.pl in eigene Funktion ausgelagert
---

diff --git a/bin/mozilla/is.pl b/bin/mozilla/is.pl
index 46f4d5716..c2e696854 100644
--- a/bin/mozilla/is.pl
+++ b/bin/mozilla/is.pl
@@ -252,6 +252,117 @@ sub prepare_invoice {
   $main::lxdebug->leave_sub();
 }
 
+sub setup_is_action_bar {
+  my $form                    = $::form;
+  my $change_never            = $::instance_conf->get_is_changeable == 0;
+  my $change_on_same_day_only = $::instance_conf->get_is_changeable == 2 && ($form->current_date(\%::myconfig) ne $form->{gldate});
+  my @req_trans_desc          = qw(kivi.SalesPurchase.check_transaction_description) x!!$::instance_conf->get_require_transaction_description_ps;
+
+  for my $bar ($::request->layout->get('actionbar')) {
+    $bar->add_actions([ t8('Update'),
+      submit    => [ '#form', { action_update => 1 } ],
+      disabled  => $form->{locked} ? t8('The billing period has already been locked.') : undef,
+      id        => 'update_button',
+      accesskey => 'enter',
+    ]);
+
+    $bar->add_actions("combobox");
+    $bar->actions->[-1]->add_actions([ t8('Post'),
+      submit   => [ '#form', { action_post => 1 } ],
+      checks   => [ @req_trans_desc ],
+      disabled => $form->{locked}                           ? t8('The billing period has already been locked.')
+                : $form->{storno}                           ? t8('A canceled invoice cannot be posted.')
+                : ($form->{id} && $change_never)            ? t8('Changing invoices has been disabled in the configuration.')
+                : ($form->{id} && $change_on_same_day_only) ? t8('Invoices can only be changed on the day they are posted.')
+                :                                             undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Post Payment'),
+      submit   => [ '#form', { action_post_payment => 1 } ],
+      checks   => [ @req_trans_desc ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('mark as paid'),
+      submit   => [ '#form', { action_mark_as_paid => 1 } ],
+      confirm  => t8('This will remove the invoice from showing as unpaid even if the unpaid amount does not match the amount. Proceed?'),
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]) if $::instance_conf->get_is_show_mark_as_paid;
+
+
+    $bar->add_actions("combobox");
+    $bar->actions->[-1]->add_actions([ t8('Storno'),
+      submit   => [ '#form', { action_storno => 1 } ],
+      confirm  => t8('Do you really want to cancel this invoice?'),
+      checks   => [ @req_trans_desc ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Delete'),
+      submit   => [ '#form', { action_delete => 1 } ],
+      confirm  => t8('Do you really want to delete this object?'),
+      checks   => [ @req_trans_desc ],
+      disabled => !$form->{id}             ? t8('This invoice has not been posted yet.')
+                : $form->{locked}          ? t8('The billing period has already been locked.')
+                : $change_never            ? t8('Changing invoices has been disabled in the configuration.')
+                : $change_on_same_day_only ? t8('Invoices can only be changed on the day they are posted.')
+                :                            undef,
+    ]);
+
+    $bar->add_actions('separator');
+
+    $bar->add_actions('combobox');
+    $bar->actions->[-1]->add_actions([ t8('Workflow'),
+      disabled => 1,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Use As New'),
+      submit   => [ '#form', { action_use_as_new    => 1 } ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Credit Note'),
+      submit   => [ '#form', { action_credit_note    => 1 } ],
+      checks   => [ @req_trans_desc ],
+      disabled => $form->{type} eq "credit_note" ? t8('Credit notes cannot be converted into other credit notes.')
+                : !$form->{id}                   ? t8('This invoice has not been posted yet.')
+                :                                  undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Sales Order'),
+      submit   => [ '#form', { action_sales_order   => 1 } ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+
+    $bar->add_actions('combobox');
+    $bar->actions->[-1]->add_actions([ t8('Export'),
+      disabled => 1,
+    ]);
+    $bar->actions->[-1]->add_actions([ ($form->{id} ? t8('Print') : t8('Preview')),
+      submit   => [ '#form', { action_print => 1 } ],
+      checks   => [ @req_trans_desc ],
+      disabled => !$form->{id} && $form->{locked} ? t8('The billing period has already been locked.') : undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('E Mail'),
+      submit   => [ '#form', { action_print => 1 } ],
+      checks   => [ @req_trans_desc ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+    $bar->add_actions('combobox');
+    $bar->actions->[-1]->add_actions([ t8('more'),
+      disabled => 1,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('History'),
+      call     => [ 'set_history_window', $form->{id} * 1, 'id' ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Follow-Up'),
+      call     => [ 'follow_up_window' ],
+      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
+    ]);
+    $bar->actions->[-1]->add_actions([ t8('Drafts'),
+      call     => [ 'kivi.Draft.popup', 'is', 'invoice', $form->{draft_id}, $form->{draft_description} ],
+      disabled => $form->{id}     ? t8('This invoice has already been posted.')
+                : $form->{locked} ? t8('The billing period has already been locked.')
+                :                   undef,
+    ]);
+  }
+}
+
 sub form_header {
   $main::lxdebug->enter_sub();
 
@@ -359,112 +470,7 @@ sub form_header {
   $TMPL_VAR{payment_terms_obj} = get_payment_terms_for_invoice();
   $form->{duedate}             = $TMPL_VAR{payment_terms_obj}->calc_date(reference_date => $form->{invdate}, due_date => $form->{duedate})->to_kivitendo if $TMPL_VAR{payment_terms_obj};
 
-  my @req_trans_desc = qw(kivi.SalesPurchase.check_transaction_description) x!!$::instance_conf->get_require_transaction_description_ps;
-
-  my $change_never            = $::instance_conf->get_is_changeable == 0;
-  my $change_on_same_day_only = $::instance_conf->get_is_changeable == 2 && ($form->current_date(\%myconfig) ne $form->{gldate});
-
-  for my $bar ($::request->layout->get('actionbar')) {
-    $bar->add_actions([ t8('Update'),
-      submit => [ '#form', { action_update         => 1 } ],
-      disabled => $form->{locked} ? t8('The billing period has already been locked.') : undef,
-      id => 'update_button',
-      accesskey => '13',
-    ]);
-    $bar->add_actions("combobox");
-    $bar->actions->[-1]->add_actions([ t8('Post'),
-      submit => [ '#form', { action_post           => 1 } ],
-      checks => [ @req_trans_desc ],
-      disabled => $form->{locked}                           ? t8('The billing period has already been locked.')
-                : $form->{storno}                           ? t8('A canceled invoice cannot be posted.')
-                : ($form->{id} && $change_never)            ? t8('Changing invoices has been disabled in the configuration.')
-                : ($form->{id} && $change_on_same_day_only) ? t8('Invoices can only be changed on the day they are posted.')
-                :                                             undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Post Payment'),
-      submit => [ '#form', { action_post_payment    => 1 } ],
-      checks => [ @req_trans_desc ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('mark as paid'),
-      submit => [ '#form', { action_mark_as_paid    => 1 } ],
-      confirm => t8('This will remove the invoice from showing as unpaid even if the unpaid amount does not match the amount. Proceed?'),
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]) if $::instance_conf->get_is_show_mark_as_paid;
-
-    $bar->add_actions("combobox");
-    $bar->actions->[-1]->add_actions([ t8('Storno'),
-      submit => [ '#form', { action_storno         => 1 } ],
-      confirm => t8('Do you really want to cancel this invoice?'),
-      checks => [ @req_trans_desc ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Delete'),
-      submit => [ '#form', { action_delete         => 1 } ],
-      confirm => t8('Do you really want to delete this object?'),
-      checks => [ @req_trans_desc ],
-      disabled => !$form->{id}             ? t8('This invoice has not been posted yet.')
-                : $form->{locked}          ? t8('The billing period has already been locked.')
-                : $change_never            ? t8('Changing invoices has been disabled in the configuration.')
-                : $change_on_same_day_only ? t8('Invoices can only be changed on the day they are posted.')
-                :                            undef,
-    ]);
-    $bar->add_actions('separator');
-
-    $bar->add_actions('combobox');
-    $bar->actions->[-1]->add_actions([ t8('Workflow'),
-      disabled => 1,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Use As New'),
-      submit => [ '#form', { action_use_as_new    => 1 } ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Credit Note'),
-      submit => [ '#form', { action_credit_note    => 1 } ],
-      checks => [ @req_trans_desc ],
-      disabled => $form->{type} eq "credit_note" ? t8('Credit notes cannot be converted into other credit notes.')
-                : !$form->{id}                   ? t8('This invoice has not been posted yet.')
-                :                                  undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Sales Order'),
-      submit => [ '#form', { action_sales_order   => 1 } ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-
-    $bar->add_actions('combobox');
-    $bar->actions->[-1]->add_actions([ t8('Export'),
-      disabled => 1,
-    ]);
-    $bar->actions->[-1]->add_actions([ ($form->{id} ? t8('Print') : t8('Preview')),
-      submit => [ '#form', { action_print          => 1 } ],
-      checks => [ @req_trans_desc ],
-      disabled => !$form->{id} && $form->{locked} ? t8('The billing period has already been locked.') : undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('E Mail'),
-      submit => [ '#form', { action_print          => 1 } ],
-      checks => [ @req_trans_desc ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-    $bar->add_actions('combobox');
-    $bar->actions->[-1]->add_actions([ t8('more'),
-      disabled => 1,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('History'),
-      call     => [ 'set_history_window', $form->{id} * 1, 'id' ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Follow-Up'),
-      call     => [ 'follow_up_window' ],
-      disabled => !$form->{id} ? t8('This invoice has not been posted yet.') : undef,
-    ]);
-    $bar->actions->[-1]->add_actions([ t8('Drafts'),
-      call     => [ 'kivi.Draft.popup', 'is', 'invoice', $form->{draft_id}, $form->{draft_description} ],
-      disabled => $form->{id}     ? t8('This invoice has already been posted.')
-                : $form->{locked} ? t8('The billing period has already been locked.')
-                :                   undef,
-    ]);
-
-  }
+  setup_is_action_bar();
 
   $form->header();