From: Moritz Bunkus Date: Tue, 16 Mar 2010 09:03:35 +0000 (+0100) Subject: Bei fehlendem Newline an YAML-Code nicht meckern X-Git-Tag: release-2.6.3~61^2~7^2~1^2~2^2 X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=f1bfb69b13865d0a0d336d19364e2684ec76a181;p=kivitendo-erp.git Bei fehlendem Newline an YAML-Code nicht meckern Google Chrome scheint Newlines am Ende von Variablen unter bestimmten Umständen zu entfernen. Diese zu ergänzen ist trivial; da muss das YAML-Modul keine Fehler melden. --- diff --git a/modules/override/YAML/Loader.pm b/modules/override/YAML/Loader.pm index 969867d90..b926f553b 100644 --- a/modules/override/YAML/Loader.pm +++ b/modules/override/YAML/Loader.pm @@ -13,8 +13,8 @@ use constant COMMENT => "\x07YAML\x07COMMENT\x07"; # Common YAML character sets my $ESCAPE_CHAR = '[\\x00-\\x08\\x0b-\\x0d\\x0e-\\x1f]'; my $FOLD_CHAR = '>'; -my $LIT_CHAR = '|'; -my $LIT_CHAR_RX = "\\$LIT_CHAR"; +my $LIT_CHAR = '|'; +my $LIT_CHAR_RX = "\\$LIT_CHAR"; sub load { my $self = shift; @@ -30,10 +30,11 @@ sub _parse { $self->{stream} =~ s|\015\012|\012|g; $self->{stream} =~ s|\015|\012|g; $self->line(0); - $self->die('YAML_PARSE_ERR_BAD_CHARS') + $self->die('YAML_PARSE_ERR_BAD_CHARS') if $self->stream =~ /$ESCAPE_CHAR/; - $self->die('YAML_PARSE_ERR_NO_FINAL_NEWLINE') - if length($self->stream) and + # $self->die('YAML_PARSE_ERR_NO_FINAL_NEWLINE') + $self->{stream} .= "\n" + if length($self->stream) and $self->{stream} !~ s/(.)\n\Z/$1/s; $self->lines([split /\x0a/, $self->stream, -1]); $self->line(1); @@ -88,7 +89,7 @@ sub _parse { $directives{YAML} ||= '1.0'; $directives{TAB} ||= 'NONE'; - ($self->{major_version}, $self->{minor_version}) = + ($self->{major_version}, $self->{minor_version}) = split /\./, $directives{YAML}, 2; $self->die('YAML_PARSE_ERR_BAD_MAJOR_VERSION', $directives{YAML}) if $self->major_version ne '1'; @@ -111,7 +112,7 @@ sub _parse_node { $self->preface(''); my ($node, $type, $indicator, $escape, $chomp) = ('') x 5; my ($anchor, $alias, $explicit, $implicit, $class) = ('') x 5; - ($anchor, $alias, $explicit, $implicit, $preface) = + ($anchor, $alias, $explicit, $implicit, $preface) = $self->_parse_qualifiers($preface); if ($anchor) { $self->anchor2node->{$anchor} = CORE::bless [], 'YAML-anchor2node'; @@ -119,7 +120,7 @@ sub _parse_node { $self->inline(''); while (length $preface) { my $line = $self->line - 1; - if ($preface =~ s/^($FOLD_CHAR|$LIT_CHAR_RX)(-|\+)?\d*\s*//) { + if ($preface =~ s/^($FOLD_CHAR|$LIT_CHAR_RX)(-|\+)?\d*\s*//) { $indicator = $1; $chomp = $2 if defined($2); } @@ -137,20 +138,20 @@ sub _parse_node { } else { $node = do {my $sv = "*$alias"}; - push @{$self->anchor2node->{$alias}}, [\$node, $self->line]; + push @{$self->anchor2node->{$alias}}, [\$node, $self->line]; } } elsif (length $self->inline) { $node = $self->_parse_inline(1, $implicit, $explicit); if (length $self->inline) { - $self->die('YAML_PARSE_ERR_SINGLE_LINE'); + $self->die('YAML_PARSE_ERR_SINGLE_LINE'); } } elsif ($indicator eq $LIT_CHAR) { $self->{level}++; $node = $self->_parse_block($chomp); $node = $self->_parse_implicit($node) if $implicit; - $self->{level}--; + $self->{level}--; } elsif ($indicator eq $FOLD_CHAR) { $self->{level}++; @@ -227,7 +228,7 @@ sub _parse_qualifiers { } elsif ($preface =~ s/^\&([^ ,:]+)\s*//) { $token = $1; - $self->die('YAML_PARSE_ERR_BAD_ANCHOR') + $self->die('YAML_PARSE_ERR_BAD_ANCHOR') unless $token =~ /^[a-zA-Z0-9]+$/; $self->die('YAML_PARSE_ERR_MANY_ANCHOR') if $anchor; $self->die('YAML_PARSE_ERR_ANCHOR_ALIAS') if $alias; @@ -242,10 +243,10 @@ sub _parse_qualifiers { $alias = $token; } } - return ($anchor, $alias, $explicit, $implicit, $preface); + return ($anchor, $alias, $explicit, $implicit, $preface); } -# Morph a node to it's explicit type +# Morph a node to it's explicit type sub _parse_explicit { my $self = shift; my ($node, $explicit) = @_; @@ -315,7 +316,7 @@ sub _parse_mapping { $key = $self->_parse_node(); $key = "$key"; } - # If "default" key (equals sign) + # If "default" key (equals sign) elsif ($self->{content} =~ s/^\=\s*//) { $key = VALUE; } @@ -331,7 +332,7 @@ sub _parse_mapping { $self->content($self->inline); $self->inline(''); } - + unless ($self->{content} =~ s/^:\s*//) { $self->die('YAML_LOAD_ERR_BAD_MAP_ELEMENT'); } @@ -387,7 +388,7 @@ sub _parse_inline { my ($top, $top_implicit, $top_explicit) = (@_, '', '', ''); $self->{inline} =~ s/^\s*(.*)\s*$/$1/; # OUCH - mugwump my ($node, $anchor, $alias, $explicit, $implicit) = ('') x 5; - ($anchor, $alias, $explicit, $implicit, $self->{inline}) = + ($anchor, $alias, $explicit, $implicit, $self->{inline}) = $self->_parse_qualifiers($self->inline); if ($anchor) { $self->anchor2node->{$anchor} = CORE::bless [], 'YAML-anchor2node'; @@ -403,7 +404,7 @@ sub _parse_inline { } else { $node = do {my $sv = "*$alias"}; - push @{$self->anchor2node->{$alias}}, [\$node, $self->line]; + push @{$self->anchor2node->{$alias}}, [\$node, $self->line]; } } elsif ($self->inline =~ /^\{/) { @@ -487,7 +488,7 @@ sub _parse_inline_seq { my $value = $self->_parse_inline(); push @$node, $value; next if $self->inline =~ /^\s*\]/; - $self->die('YAML_PARSE_ERR_INLINE_SEQUENCE') + $self->die('YAML_PARSE_ERR_INLINE_SEQUENCE') unless $self->{inline} =~ s/^\,\s*//; } return $node; @@ -604,7 +605,7 @@ sub _parse_throwaway_comments { # 3) Find the next _content_ line # A) Skip over any throwaways (Comments/blanks) # B) Set $self->indent, $self->content, $self->line -# 4) Expand tabs appropriately +# 4) Expand tabs appropriately sub _parse_next_line { my $self = shift; my ($type) = @_; @@ -646,7 +647,7 @@ sub _parse_next_line { $offset = $self->offset->[++$level]; } # Determine the offset for a new collection level - elsif ($type == COLLECTION and + elsif ($type == COLLECTION and $self->preface =~ /^(\s*(\!\S*|\&\S+))*\s*$/) { $self->_parse_throwaway_comments(); if ($self->eos) { @@ -664,7 +665,7 @@ sub _parse_next_line { } $offset = $self->offset->[++$level]; } - + if ($type == LEAF) { while (@{$self->lines} and $self->lines->[0] =~ m{^( *)(\#)} and @@ -678,13 +679,13 @@ sub _parse_next_line { else { $self->_parse_throwaway_comments(); } - return if $self->eos; - + return if $self->eos; + if ($self->lines->[0] =~ /^---(\s|$)/) { $self->done(1); return; } - if ($type == LEAF and + if ($type == LEAF and $self->lines->[0] =~ /^ {$offset}(.*)$/ ) { $self->indent($offset); @@ -699,7 +700,7 @@ sub _parse_next_line { while ($self->offset->[$level] > length($1)) { $level--; } - $self->die('YAML_PARSE_ERR_INCONSISTENT_INDENTATION') + $self->die('YAML_PARSE_ERR_INCONSISTENT_INDENTATION') if $self->offset->[$level] != length($1); $self->indent(length($1)); $self->content($2); @@ -713,13 +714,13 @@ sub _parse_next_line { #============================================================================== # Printable characters for escapes -my %unescapes = +my %unescapes = ( z => "\x00", a => "\x07", t => "\x09", n => "\x0a", v => "\x0b", f => "\x0c", r => "\x0d", e => "\x1b", '\\' => '\\', ); - + # Transform all the backslash style escape characters to their literal meaning sub _unescape { my $self = shift;