From: Jan Büren <jan@kivitendo.de>
Date: Tue, 23 Nov 2021 11:14:00 +0000 (+0100)
Subject: _convert_pdf_to_png: Mehr Warnungen - quotemeta für Dateinamen mit whitespace
X-Git-Tag: kivitendo-mebil_0.1-0~10^2~2^2~289
X-Git-Url: http://wagnertech.de/git?a=commitdiff_plain;h=fb2c3df2944acfc62f3688040131147694717b39;p=kivitendo-erp.git

_convert_pdf_to_png: Mehr Warnungen - quotemeta für Dateinamen mit whitespace
---

diff --git a/SL/Controller/File.pm b/SL/Controller/File.pm
index 9005d79d6..7cd9406d0 100644
--- a/SL/Controller/File.pm
+++ b/SL/Controller/File.pm
@@ -679,7 +679,12 @@ sub _convert_pdf_to_png {
 
   my $size    = $params{size} // 64;
   my $sfile   = SL::SessionFile::Random->new();
-  my $command = 'pdftoppm -singlefile -scale-to ' . $size . ' -png' . ' ' . $filename . ' ' . $sfile->file_name;
+  unless (-f $filename) {
+    $::lxdebug->message(LXDebug::WARN(), "_convert_pdf_to_png failed, no file found: $filename");
+    return;
+  }
+  # quotemeta for storno case "storno\ zu\ 1020" *nix only
+  my $command = 'pdftoppm -singlefile -scale-to ' . $size . ' -png' . ' ' . quotemeta($filename) . ' ' . $sfile->file_name;
 
   if (system($command) == -1) {
     $::lxdebug->message(LXDebug::WARN(), "SL::File::_convert_pdf_to_png: system call failed: " . $ERRNO);
@@ -687,6 +692,7 @@ sub _convert_pdf_to_png {
   }
   if ($CHILD_ERROR) {
     $::lxdebug->message(LXDebug::WARN(), "SL::File::_convert_pdf_to_png: pdftoppm failed with error code: " . ($CHILD_ERROR >> 8));
+    $::lxdebug->message(LXDebug::WARN(), "SL::File::_convert_pdf_to_png: File: $filename");
     return;
   }