From 7328cbd6ab400a613f6c160beffbdb3abb44c8ad Mon Sep 17 00:00:00 2001
From: Moritz Bunkus <m.bunkus@linet-services.de>
Date: Wed, 11 May 2011 13:22:28 +0200
Subject: [PATCH] Per default Drag&Drop nur auf Item mit Klasse 'dragdrop'
 zulassen

---
 SL/Template/Plugin/L.pm                          | 9 ++++++---
 templates/webpages/am/edit_units.html            | 2 +-
 templates/webpages/am/list_price_factors.html    | 6 +++++-
 templates/webpages/am/list_warehouses.html       | 2 +-
 templates/webpages/amcvar/list_cvar_configs.html | 6 +++++-
 5 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/SL/Template/Plugin/L.pm b/SL/Template/Plugin/L.pm
index 0d159dc85..b78ebb015 100644
--- a/SL/Template/Plugin/L.pm
+++ b/SL/Template/Plugin/L.pm
@@ -438,6 +438,7 @@ JAVASCRIPT
 JAVASCRIPT
   }
 
+  $params{handle}     = '.dragdrop' unless exists $params{handle};
   $attributes{handle} = "'$params{handle}'" if $params{handle};
 
   my $attr_str = join(', ', map { "${_}: $attributes{$_}" } keys %attributes);
@@ -697,9 +698,11 @@ element (see C<$params{with}>).
 =item C<handle>
 
 An optional jQuery selector specifying which part of the child element
-is dragable. If nothing is given then the whole child element is
-dragable, and clicks through to underlying elements like inputs or
-links might not work.
+is dragable. If the parameter is not given then it defaults to
+C<.dragdrop> matching DOM elements with the class C<dragdrop>.  If the
+parameter is set and empty then the whole child element is dragable,
+and clicks through to underlying elements like inputs or links might
+not work.
 
 =item C<dont_recolor>
 
diff --git a/templates/webpages/am/edit_units.html b/templates/webpages/am/edit_units.html
index 9d228d5da..c9495e14e 100644
--- a/templates/webpages/am/edit_units.html
+++ b/templates/webpages/am/edit_units.html
@@ -145,7 +145,7 @@
 
  </form>
 
- [% L.sortable_element('#unit_list tbody', 'url' => 'controller.pl?action=Unit/reorder', 'with' => 'unit_id', handle => '.dragdrop') %]
+ [% L.sortable_element('#unit_list tbody', url => 'controller.pl?action=Unit/reorder', with => 'unit_id') %]
 
 </body>
 </html>
diff --git a/templates/webpages/am/list_price_factors.html b/templates/webpages/am/list_price_factors.html
index c220a8dd0..0f3c0135c 100644
--- a/templates/webpages/am/list_price_factors.html
+++ b/templates/webpages/am/list_price_factors.html
@@ -11,12 +11,15 @@
 
  <p>
   <table width="100%" id="price_factor_list">
+   <thead>
    <tr class="listheading">
     <th align="center"><img src="image/updown.png" alt="[ LxERP.t8('reorder item') %]"></th>
     <th width="80%">[% 'Description' | $T8 %]</th>
     <th width="20%">[% 'Factor' | $T8 %]</th>
    </tr>
+   </thead>
 
+   <tbody>
    [% FOREACH factor = PRICE_FACTORS %]
    <tr class="listrow[% loop.count % 2 %]" id="price_factor_id_[% factor.id %]">
     <td align="center" class="dragdrop"><img src="image/updown.png" alt="[ LxERP.t8('reorder item') %]"></td>
@@ -24,6 +27,7 @@
     <td>[% HTML.escape(factor.factor) %]</td>
    </tr>
    [% END %]
+   </tbody>
   </table>
  </p>
 
@@ -38,7 +42,7 @@
   </form>
  </p>
 
- [% L.sortable_element('#price_factor_list tbody', 'url' => 'controller.pl?action=PriceFactor/reorder', 'with' => 'price_factor_id', handle => '.dragdrop') %]
+ [% L.sortable_element('#price_factor_list tbody', url => 'controller.pl?action=PriceFactor/reorder', with => 'price_factor_id') %]
 
 </body>
 </html>
diff --git a/templates/webpages/am/list_warehouses.html b/templates/webpages/am/list_warehouses.html
index b791e7de8..d4e0e0f74 100644
--- a/templates/webpages/am/list_warehouses.html
+++ b/templates/webpages/am/list_warehouses.html
@@ -39,7 +39,7 @@
   </form>
  </p>
 
- [% L.sortable_element('#warehouse_list tbody', 'url' => 'controller.pl?action=Warehouse/reorder', 'with' => 'warehouse_id', handle => '.dragdrop') %]
+ [% L.sortable_element('#warehouse_list tbody', url => 'controller.pl?action=Warehouse/reorder', with => 'warehouse_id') %]
 
 </body>
 </html>
diff --git a/templates/webpages/amcvar/list_cvar_configs.html b/templates/webpages/amcvar/list_cvar_configs.html
index b2e4b9ab8..4c76eb66e 100644
--- a/templates/webpages/amcvar/list_cvar_configs.html
+++ b/templates/webpages/amcvar/list_cvar_configs.html
@@ -25,6 +25,7 @@
 
   <p>
    <table width="100%" id="cvarcfg_list">
+    <thead>
     <tr class="listheading">
      <th align="center"><img src="image/updown.png" alt="[ LxERP.t8('reorder item') %]"></th>
      <th width="20%">[% 'Name' | $T8 %]</th>
@@ -36,7 +37,9 @@
      <th width="20%">[% 'Editable' | $T8 %]</th>
      [%- END %]
     </tr>
+    </thead>
 
+    <tbody>
     [%- FOREACH cfg = CONFIGS %]
     <tr class="listrow[% loop.count % 2 %]" id="cvarcfg_id_[% cfg.id %]">
      <td align="center" class="dragdrop"><img src="image/updown.png" alt="[ LxERP.t8('reorder item') %]"></td>
@@ -79,6 +82,7 @@
      [%- END %]
     </tr>
     [%- END %]
+    </tbody>
    </table>
   </p>
 
@@ -89,7 +93,7 @@
   </p>
  </form>
 
- [% L.sortable_element('#cvarcfg_list tbody', 'url' => 'controller.pl?action=CustomVariableConfig/reorder', 'with' => 'cvarcfg_id', handle => '.dragdrop') %]
+ [% L.sortable_element('#cvarcfg_list tbody', url => 'controller.pl?action=CustomVariableConfig/reorder', with => 'cvarcfg_id') %]
 
 </body>
 </html>
-- 
2.20.1