From 97eb7f688801d7f545c710270379a9a4d86d92dc Mon Sep 17 00:00:00 2001 From: Moritz Bunkus Date: Fri, 1 Apr 2016 17:12:52 +0200 Subject: [PATCH] =?utf8?q?ReportGenerator:=20Unterst=C3=BCtzung=20f=C3=BCr?= =?utf8?q?=20raw=5Fheader=5Fdata-Attribut=20in=20Spaltendefinitionen?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Zuerst wurde dieses Attribut in Anlehnung an das Attribut bei den Positionszeilen "raw_data" genannt. Leider kollidiert "raw_data" mit der Benutzung des ReportGenerators aus dem Controller-Helfer-Modul SL::Controller::ReportGenerator. Dieser verwendet "raw_data" in den Spaltendefinitionen bereits für Defaults für die Erzeugung der Positionszeilen. Daher nun die Umbenennung des neuen Attributes nach "raw_header_data". --- SL/ReportGenerator.pm | 2 +- bin/mozilla/ar.pl | 2 +- templates/webpages/report_generator/html_report.html | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/SL/ReportGenerator.pm b/SL/ReportGenerator.pm index 368e695a3..451e9c002 100644 --- a/SL/ReportGenerator.pm +++ b/SL/ReportGenerator.pm @@ -287,7 +287,7 @@ sub prepare_html_content { 'align' => $column->{align}, 'link' => $column->{link}, 'text' => $column->{text}, - 'raw_data' => $column->{raw_data}, + 'raw_header_data' => $column->{raw_header_data}, 'show_sort_indicator' => $name eq $opts->{sort_indicator_column}, 'sort_indicator_direction' => $opts->{sort_indicator_direction}, }; diff --git a/bin/mozilla/ar.pl b/bin/mozilla/ar.pl index 54e80106d..e051b17a7 100644 --- a/bin/mozilla/ar.pl +++ b/bin/mozilla/ar.pl @@ -949,7 +949,7 @@ sub ar_transactions { $href = build_std_url('action=ar_transactions', grep { $form->{$_} } @hidden_variables); my %column_defs = ( - 'ids' => { raw_data => $::request->presenter->checkbox_tag("", id => "check_all", checkall => "[data-checkall=1]"), align => 'center' }, + 'ids' => { raw_header_data => $::request->presenter->checkbox_tag("", id => "check_all", checkall => "[data-checkall=1]"), align => 'center' }, 'transdate' => { 'text' => $locale->text('Date'), }, 'id' => { 'text' => $locale->text('ID'), }, 'type' => { 'text' => $locale->text('Type'), }, diff --git a/templates/webpages/report_generator/html_report.html b/templates/webpages/report_generator/html_report.html index 2be80a3c5..9a3d93480 100644 --- a/templates/webpages/report_generator/html_report.html +++ b/templates/webpages/report_generator/html_report.html @@ -35,8 +35,8 @@ [%- IF col.align %] align="[% HTML.escape(col.align) %]" style="text-align: [% HTML.escape(col.align) %]"[% END -%] [%- IF col.colspan && col.colspan > 1 %] colspan="[% HTML.escape(col.colspan) %]"[% END -%] > - [%- IF col.raw_data %] - [% col.raw_data %] + [%- IF col.raw_header_data %] + [% col.raw_header_data %] [% ELSE %] [%- IF col.link -%][%- END -%] [%- col.text -%] -- 2.20.1