From b4cc349b7fe50744832261c8b415bd146bde5520 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jan=20B=C3=BCren?= Date: Mon, 4 Jun 2018 11:04:57 +0200 Subject: [PATCH] SelfTest false positive vermeiden MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit $self->all_passed enthält nicht mehr den Zustand, ob alle Tests erfolgreich waren. Als Workaround auf zwei negativ Status-Meldungen prüfen, die bei Problemen gesetzt sind. --- SL/BackgroundJob/SelfTest.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/SL/BackgroundJob/SelfTest.pm b/SL/BackgroundJob/SelfTest.pm index b34b71d65..d4465721f 100644 --- a/SL/BackgroundJob/SelfTest.pm +++ b/SL/BackgroundJob/SelfTest.pm @@ -63,8 +63,9 @@ sub run { $self->aggreg->failed, $self->aggreg->todo_passed, ); - - if (!$self->aggreg->all_passed || $self->config->{send_email_on_success}) { + # if (!$self->aggreg->all_passed || $self->config->{send_email_on_success}) { + # all_passed is not set or calculated (anymore). it is safe to check only for probs or errors + if ($self->aggreg->has_problems || $self->aggreg->has_errors || $self->config->{send_email_on_success}) { $self->_send_email; } -- 2.20.1