Merge branch 'b-3.6.1' of ../kivitendo-erp_20220811

[kivitendo-erp.git] / sql / Pg-upgrade2 / orderitems_delivery_order_items_positions.pl

diff --git a/sql/Pg-upgrade2/orderitems_delivery_order_items_positions.pl b/sql/Pg-upgrade2/orderitems_delivery_order_items_positions.pl
index cda9200..97d1a31 100644 (file)
--- a/sql/Pg-upgrade2/orderitems_delivery_order_items_positions.pl
+++ b/sql/Pg-upgrade2/orderitems_delivery_order_items_positions.pl
@@ -1,7 +1,6 @@
 # @tag: orderitems_delivery_order_items_positions
 # @description: Spalte für Positionen der Einträge in Angeboten/Auftträgen und Lieferscheinen.
 # @depends: release_3_1_0
-# @encoding: utf-8
 package SL::DBUpgrade2::orderitems_delivery_order_items_positions;
 
 use strict;
@@ -25,8 +24,10 @@ sub run {
 
     my $order_id_col = $order_id_cols{ $table };
     $query = qq|SELECT * FROM $table ORDER BY $order_id_col, id|;
+    my $query2 = qq|UPDATE $table SET position = ? WHERE id = ?|;
 
     my $sth = $self->dbh->prepare($query);
+    my $sth2 = $self->dbh->prepare($query2);
     $sth->execute || $::form->dberror($query);
 
     # set new position field in order of ids, starting by one for each order
@@ -40,10 +41,10 @@ sub run {
       }
       $last_order_id = $ref->{ $order_id_col };
 
-      $query = qq|UPDATE $table SET position = ? WHERE id = ?|;
-      $self->db_query($query, bind => [ $position, $ref->{id} ]);
+      $sth2->execute($position, $ref->{id});
     }
     $sth->finish;
+    $sth2->finish;
 
 
     $query = qq|ALTER TABLE $table ALTER COLUMN position SET NOT NULL|;