X-Git-Url: http://wagnertech.de/git?p=kivitendo-erp.git;a=blobdiff_plain;f=SL%2FDB%2FBankTransaction.pm;fp=SL%2FDB%2FBankTransaction.pm;h=b07cdf11f6ede506508ca1aafc2f20a520f1b12b;hp=e8c98cb64e810eb275fdc2b05db8e2192eba1843;hb=b293ff8ad52fc76ba0c44783e3982418114d6b08;hpb=d4925a8b60f04674885e30d9316dc0263f8b9a84 diff --git a/SL/DB/BankTransaction.pm b/SL/DB/BankTransaction.pm index e8c98cb64..b07cdf11f 100644 --- a/SL/DB/BankTransaction.pm +++ b/SL/DB/BankTransaction.pm @@ -99,13 +99,16 @@ sub get_agreement_with_invoice { $bank_code = $invoice->vendor->bank_code if ! $invoice->is_sales; $iban = $invoice->vendor->iban if ! $invoice->is_sales; $account_number = $invoice->vendor->account_number if ! $invoice->is_sales; - if ( $bank_code eq $self->remote_bank_code && $account_number eq $self->remote_account_number ) { - $agreement += $points{remote_account_number}; - $rule_matches .= 'remote_account_number(' . $points{'remote_account_number'} . ') '; - } - if ( $iban eq $self->remote_account_number ) { - $agreement += $points{remote_account_number}; - $rule_matches .= 'remote_account_number(' . $points{'remote_account_number'} . ') '; + + # check only valid remote_account_number (with some content) + if ($self->remote_account_number) { + if ($bank_code eq $self->remote_bank_code && $account_number eq $self->remote_account_number) { + $agreement += $points{remote_account_number}; + $rule_matches .= 'remote_account_number(' . $points{'remote_account_number'} . ') '; + } elsif ($iban eq $self->remote_account_number) { # elsif -> do not add twice + $agreement += $points{remote_account_number}; + $rule_matches .= 'remote_account_number(' . $points{'remote_account_number'} . ') '; + } } my $datediff = $self->transdate->{utc_rd_days} - $invoice->transdate->{utc_rd_days};