BankTransaction: weniger im Controller rechnen -> ausgelagert in Objekt

[mfinanz.git] / SL / Controller / LoginScreen.pm

diff --git a/SL/Controller/LoginScreen.pm b/SL/Controller/LoginScreen.pm
index 385ce6fdd5f2568885f3aea94dacc5d7a09ba24a..673c6b43c3b3cfa6ac56500ad11cc325f6014c16 100644 (file)
--- a/SL/Controller/LoginScreen.pm
+++ b/SL/Controller/LoginScreen.pm
@@ -13,6 +13,7 @@ use SL::DB::AuthUser;
 use SL::DB::Employee;
 use SL::Locale::String qw(t8);
 use SL::User;
 use SL::DB::Employee;
 use SL::Locale::String qw(t8);
 use SL::User;

+use SL::Version;

 
 use Rose::Object::MakeMethods::Generic (
   'scalar --get_set_init' => [ qw(clients default_client_id) ],
 
 use Rose::Object::MakeMethods::Generic (
   'scalar --get_set_init' => [ qw(clients default_client_id) ],


@@ -32,7 +33,7 @@ sub action_user_login {
   return if $self->_redirect_to_main_script_if_already_logged_in;
 
   # Otherwise show the login form.
   return if $self->_redirect_to_main_script_if_already_logged_in;
 
   # Otherwise show the login form.

-  $self->show_login_form(error => error_state($::form->{error}));
+  $self->show_login_form(error_state($::form->{error}));

 }
 
 sub action_logout {
 }
 
 sub action_logout {


@@ -56,9 +57,8 @@ sub action_login {
   }
 
   %::myconfig      = $login ? $::auth->read_user(login => $login) : ();
   }
 
   %::myconfig      = $login ? $::auth->read_user(login => $login) : ();

-  $::form->{login} = $login;

   $::locale        = Locale->new($::myconfig{countrycode}) if $::myconfig{countrycode};
   $::locale        = Locale->new($::myconfig{countrycode}) if $::myconfig{countrycode};

-  SL::Dispatcher::AuthHandler::User->new->handle(countrycode => $::myconfig{countrycode});
+  SL::Dispatcher::AuthHandler::User->new->handle;

 
   $::request->layout(SL::Layout::Dispatcher->new(style => $::myconfig{menustyle}));
 
 
   $::request->layout(SL::Layout::Dispatcher->new(style => $::myconfig{menustyle}));
 


@@ -68,7 +68,8 @@ sub action_login {
   # Auth DB needs update? If so log the user out forcefully.
   if (User::LOGIN_AUTH_DBUPDATE_AVAILABLE() == $result) {
     $::auth->destroy_session;
   # Auth DB needs update? If so log the user out forcefully.
   if (User::LOGIN_AUTH_DBUPDATE_AVAILABLE() == $result) {
     $::auth->destroy_session;

-    return $self->render('login_screen/auth_db_needs_update');
+    # must be without layout because menu rights might not exist yet
+    return $self->render('login_screen/auth_db_needs_update', { layout => 0 });

   }
 
   # Basic client tables available? If not tell the user to create them
   }
 
   # Basic client tables available? If not tell the user to create them


@@ -79,7 +80,7 @@ sub action_login {
   }
 
   # Database update available?
   }
 
   # Database update available?

-  ::end_of_request() if User::LOGIN_DBUPDATE_AVAILABLE() == $result;
+  $::dispatcher->end_request if User::LOGIN_DBUPDATE_AVAILABLE() == $result;

 
   # Other login errors.
   if (User::LOGIN_OK() != $result) {
 
   # Other login errors.
   if (User::LOGIN_OK() != $result) {


@@ -111,8 +112,6 @@ sub keep_auth_vars_in_form {
 sub _redirect_to_main_script {
   my ($self) = @_;
 
 sub _redirect_to_main_script {
   my ($self) = @_;
 

-  $self->_ensure_employees_for_authorized_users_exist;
-

   return $self->redirect_to($::form->{callback}) if $::form->{callback};
 
   $self->redirect_to(controller => "login.pl", action => 'company_logo');
   return $self->redirect_to($::form->{callback}) if $::form->{callback};
 
   $self->redirect_to(controller => "login.pl", action => 'company_logo');


@@ -129,6 +128,19 @@ sub _redirect_to_main_script_if_already_logged_in {
   my %user = $::auth->read_user(login => $login);
   return if ($user{login} || '') ne $login;
 
   my %user = $::auth->read_user(login => $login);
   return if ($user{login} || '') ne $login;
 

+  # Check if there's a client set in the session -- and whether or not
+  # the user still has access to the client.
+  my $client_id = $::auth->get_session_value('client_id');
+  return if !$client_id;
+
+  if (!$::auth->set_client($client_id)) {
+    $::auth->punish_wrong_login;
+    $::auth->destroy_session;
+    $::auth->create_or_refresh_session;
+    $self->show_login_form(error => t8('Incorrect username or password or no access to selected client!'));
+    return 1;
+  }
+

   # Check if the session is logged in correctly.
   return if SL::Auth::OK() != $::auth->authenticate($login, undef);
 
   # Check if the session is logged in correctly.
   return if SL::Auth::OK() != $::auth->authenticate($login, undef);
 


@@ -140,28 +152,14 @@ sub _redirect_to_main_script_if_already_logged_in {
   return 1;
 }
 
   return 1;
 }
 

-sub _ensure_employees_for_authorized_users_exist {
-  my ($self) = @_;
-
-  my %employees_by_login = map { ($_->login => $_) } @{ SL::DB::Manager::Employee->get_all };
-
-  foreach my $user (@{ SL::DB::AuthClient->new(id => $::auth->client->{id})->load->users || [] }) {
-    my $user_config = $user->config_values;
-    my $employee    = $employees_by_login{$user->login} || SL::DB::Employee->new(login => $user->login);
-
-    $employee->update_attributes(
-      name      => $user_config->{name},
-      workphone => $user_config->{tel},
-      deleted   => 0,
-    );
-  }
-}
-

 sub error_state {
 sub error_state {

-  return {
-    session  => $::locale->text('The session is invalid or has expired.'),
-    password => $::locale->text('Incorrect username or password or no access to selected client!'),
-  }->{$_[0]};
+  my %states = (
+    session  => { warning => t8('The session has expired. Please log in again.')                   },
+    password => { error   => t8('Incorrect username or password or no access to selected client!') },
+    action   => { warning => t8('The action is missing or invalid.')                               },
+  );
+
+  return %{ $states{$_[0]} || {} };

 }
 
 sub set_layout {
 }
 
 sub set_layout {


@@ -181,8 +179,7 @@ sub init_default_client_id {
 sub show_login_form {
   my ($self, %params) = @_;
 
 sub show_login_form {
   my ($self, %params) = @_;
 

-  $::request->layout->focus('#auth_login');
-  $self->render('login_screen/user_login', %params);
+  $self->render('login_screen/user_login', %params, version => SL::Version->get_version );

 }
 
 1;
 }
 
 1;