Mandantenkonfiguration: Felder bearbeiten können, die zuvor nur in myconfig standen

[mfinanz.git] / SL / Controller / ClientConfig.pm

diff --git a/SL/Controller/ClientConfig.pm b/SL/Controller/ClientConfig.pm
index aaed72fc5ce256234135fb7a779fdc7b8c7734eb..a3fdb9caf7e0d2063c6829bc9f9f0deec5c96133 100644 (file)
--- a/SL/Controller/ClientConfig.pm
+++ b/SL/Controller/ClientConfig.pm
@@ -3,77 +3,177 @@ package SL::Controller::ClientConfig;
 use strict;
 use parent qw(SL::Controller::Base);
 
 use strict;
 use parent qw(SL::Controller::Base);
 

+use List::Util qw(first);
+
+use SL::DB::Chart;
+use SL::DB::Currency;

 use SL::DB::Default;
 use SL::DB::Default;

+use SL::DB::Language;
+use SL::DB::Unit;

 use SL::Helper::Flash;
 use SL::Helper::Flash;

+use SL::Locale::String qw(t8);

 
 __PACKAGE__->run_before('check_auth');
 
 
 __PACKAGE__->run_before('check_auth');
 

+use Rose::Object::MakeMethods::Generic (
+  'scalar --get_set_init' => [ qw(defaults all_warehouses all_weightunits all_languages all_currencies posting_options payment_options accounting_options inventory_options profit_options accounts) ],
+);

 
 sub action_edit {
   my ($self, %params) = @_;
 
 sub action_edit {
   my ($self, %params) = @_;

+  $self->edit_form;
+}

 
 

-  $self->{posting_options} = [ { title => $::locale->text("never"), value => 0 },
-                               { title => $::locale->text("every time"), value => 1 },
-                               { title => $::locale->text("on the same day"), value => 2 }, ];
-  $self->{payment_options} = [ { title => $::locale->text("never"), value => 0 },
-                               { title => $::locale->text("every time"), value => 1 },
-                               { title => $::locale->text("on the same day"), value => 2 }, ];
-  $self->{accounting_options} = [ { title => $::locale->text("accrual"), value => "accrual" },
-                                  { title => $::locale->text("cash"), value => "cash" }, ];
-  $self->{inventory_options} = [ { title => $::locale->text("perpetual"), value => "perpetual" },
-                                 { title => $::locale->text("periodic"), value => "periodic" }, ];
-  $self->{profit_options} = [ { title => $::locale->text("balance"), value => "balance" },
-                              { title => $::locale->text("income"), value => "income" }, ];
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(is_changeable ir_changeable ar_changeable ap_changeable gl_changeable);
-
-  $self->{payments_changeable} = SL::DB::Default->get->payments_changeable;
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(is_show_mark_as_paid ir_show_mark_as_paid ar_show_mark_as_paid ap_show_mark_as_paid);
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(accounting_method inventory_system profit_determination);
+sub action_save {
+  my ($self, %params)      = @_;
+
+  my $defaults             = delete($::form->{defaults}) || {};
+  my $entered_currencies   = delete($::form->{currencies}) || [];
+  my $original_currency_id = $self->defaults->currency_id;
+
+  # undef several fields if an empty value has been selected.
+  foreach (qw(warehouse_id bin_id warehouse_id_ignore_onhand bin_id_ignore_onhand)) {
+    undef $defaults->{$_} if !$defaults->{$_};
+  }
+
+  $self->defaults->assign_attributes(%{ $defaults });
+
+  my %errors_idx;
+
+  # Handle currencies
+  my (%new_currency_names);
+  foreach my $existing_currency (@{ $self->all_currencies }) {
+    my $new_name     = $existing_currency->name;
+    my $new_currency = first { $_->{id} == $existing_currency->id } @{ $entered_currencies };
+    $new_name        = $new_currency->{name} if $new_currency;
+
+    if (!$new_name) {
+      $errors_idx{0} = t8('Currency names must not be empty.');
+    } elsif ($new_currency_names{$new_name}) {
+      $errors_idx{1} = t8('Currency names must be unique.');
+    }
+
+    if ($new_name) {
+      $new_currency_names{$new_name} = 1;
+      $existing_currency->name($new_name);
+    }
+  }
+
+  if ($::form->{new_currency} && $new_currency_names{ $::form->{new_currency} }) {
+    $errors_idx{1} = t8('Currency names must be unique.');
+  }
+
+  my @errors = map { $errors_idx{$_} } sort keys %errors_idx;
+
+  if (@errors) {
+    flash('error', @errors);
+    return $self->edit_form;
+  }
+
+  # Save currencies. As the names must be unique we cannot simply save
+  # them as they are -- the user might want to swap to names. So make
+  # them unique first and assign the actual names in a second step.
+  my %currency_names_by_id = map { ($_->id => $_->name) } @{ $self->all_currencies };
+  $_->update_attributes(name => '__039519735__' . $_->{id})        for @{ $self->all_currencies };
+  $_->update_attributes(name => $currency_names_by_id{ $_->{id} }) for @{ $self->all_currencies };
+
+  # Create new currency if required
+  my $new_currency;
+  if ($::form->{new_currency}) {
+    $new_currency = SL::DB::Currency->new(name => $::form->{new_currency});
+    $new_currency->save;
+  }
+
+  # If the user wants the new currency to be the default then replace
+  # the ID placeholder with the proper value. However, if no new
+  # currency has been created then don't change the value at all.
+  if (-1 == $self->defaults->currency_id) {
+    $self->defaults->currency_id($new_currency ? $new_currency->id : $original_currency_id);
+  }
+
+  $self->defaults->save;
+
+  flash_later('info', t8('Client Configuration saved!'));

 
 

-  $self->{show_bestbefore}     = SL::DB::Default->get->show_bestbefore;
+  $self->redirect_to(action => 'edit');
+}

 
 

-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(datev_check_on_sales_invoice datev_check_on_purchase_invoice datev_check_on_ar_transaction datev_check_on_ap_transaction datev_check_on_gl_transaction);
-  # datev check: not implemented yet:
-  #check_on_cash_and_receipt = 0
-  #check_on_dunning = 0
-  #check_on_sepa_import = 0
+#
+# initializers
+#

 
 

-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(sales_order_show_delete purchase_order_show_delete sales_delivery_order_show_delete purchase_delivery_order_show_delete);
+sub init_defaults        { SL::DB::Default->get                                           }
+sub init_all_warehouses  { SL::DB::Manager::Warehouse->get_all_sorted                     }
+sub init_all_languages   { SL::DB::Manager::Language->get_all_sorted                      }
+sub init_all_currencies  { SL::DB::Manager::Currency->get_all_sorted                      }
+sub init_all_weightunits { SL::DB::Manager::Unit->find_by(name => 'g')->convertible_units }

 
 

-  $self->render('client_config/form', title => $::locale->text('Client Configuration'));
+sub init_posting_options {
+  [ { title => t8("never"),           value => 0           },
+    { title => t8("every time"),      value => 1           },
+    { title => t8("on the same day"), value => 2           }, ]

 }
 
 }
 

+sub init_payment_options {
+  [ { title => t8("never"),           value => 0           },
+    { title => t8("every time"),      value => 1           },
+    { title => t8("on the same day"), value => 2           }, ]
+}

 
 

-sub action_save {
-  my ($self, %params) = @_;
-
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(is_changeable ir_changeable ar_changeable ap_changeable gl_changeable);
+sub init_accounting_options {
+  [ { title => t8("Accrual"),         value => "accrual"   },
+    { title => t8("cash"),            value => "cash"      }, ]
+}

 
 

-  SL::DB::Default->get->update_attributes('payments_changeable' => $::form->{payments_changeable});
+sub init_inventory_options {
+  [ { title => t8("perpetual"),       value => "perpetual" },
+    { title => t8("periodic"),        value => "periodic"  }, ]
+}

 
 

-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(is_show_mark_as_paid ir_show_mark_as_paid ar_show_mark_as_paid ap_show_mark_as_paid);
+sub init_profit_options {
+  [ { title => t8("balance"),         value => "balance"   },
+    { title => t8("income"),          value => "income"    }, ]
+}

 
 

-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(accounting_method inventory_system profit_determination);
+sub init_accounts {
+  my %accounts;

 
 

-  SL::DB::Default->get->update_attributes('show_bestbefore'     => $::form->{show_bestbefore});
+  foreach my $chart (@{ SL::DB::Manager::Chart->get_all(where => [ link => { like => '%IC%' } ], sort_by => 'accno ASC') }) {
+    my %added;

 
 

-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(datev_check_on_sales_invoice datev_check_on_purchase_invoice datev_check_on_ar_transaction datev_check_on_ap_transaction datev_check_on_gl_transaction);
+    foreach my $link (split m/:/, $chart->link) {
+      my $key = lc($link =~ /cogs/ ? 'IC_expense' : $link =~ /sale/ ? 'IC_income' : $link);
+      next if $added{$key};

 
 

-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(sales_order_show_delete purchase_order_show_delete sales_delivery_order_show_delete purchase_delivery_order_show_delete);
+      $added{$key}      = 1;
+      $accounts{$key} ||= [];
+      push @{ $accounts{$key} }, $chart;
+    }
+  }

 
 

-  flash_later('info', $::locale->text('Client Configuration saved!'));
+  $accounts{fx_gain} = SL::DB::Manager::Chart->get_all(where => [ category => 'I', charttype => 'A' ], sort_by => 'accno ASC');
+  $accounts{fx_loss} = SL::DB::Manager::Chart->get_all(where => [ category => 'E', charttype => 'A' ], sort_by => 'accno ASC');
+  $accounts{ar_paid} = SL::DB::Manager::Chart->get_all(where => [ link => { like => '%AR_paid%' }   ], sort_by => 'accno ASC');

 
 

-  $self->redirect_to(action => 'edit');
+  return \%accounts;

 }
 
 }
 

-
-#################### private stuff ##########################
+#
+# filters
+#

 
 sub check_auth {
   $::auth->assert('admin');
 }
 
 
 sub check_auth {
   $::auth->assert('admin');
 }
 

+#
+# helpers
+#
+
+sub edit_form {
+  my ($self) = @_;
+  $self->render('client_config/form', title => t8('Client Configuration'),
+                make_chart_title => sub { $_[0]->accno . '--' . $_[0]->description });
+}
+

 1;
 1;