GetModels Sorted: tiebreaker für deterministisches sortieren

[mfinanz.git] / SL / DBUpgrade2 / Base.pm

diff --git a/SL/DBUpgrade2/Base.pm b/SL/DBUpgrade2/Base.pm
index 34afeae54504abbb6dc1b319f7b626908cf27961..594fb7fba4b07b94fa9b57783e23e172a41cafd2 100644 (file)
--- a/SL/DBUpgrade2/Base.pm
+++ b/SL/DBUpgrade2/Base.pm
@@ -11,6 +11,8 @@ use File::Basename ();
 use File::Copy ();
 use File::Path ();
 use List::MoreUtils qw(uniq);
 use File::Copy ();
 use File::Path ();
 use List::MoreUtils qw(uniq);

+use SL::DBUtils qw(selectfirst_hashref_query);
+use version;

 
 use Rose::Object::MakeMethods::Generic (
   scalar => [ qw(dbh myconfig) ],
 
 use Rose::Object::MakeMethods::Generic (
   scalar => [ qw(dbh myconfig) ],


@@ -57,8 +59,14 @@ sub db_query {
 sub db_errstr {
   my ($self, $handle) = @_;
 
 sub db_errstr {
   my ($self, $handle) = @_;
 

+  # DBD::Pg before 2.16.1 doesn't set the UTF-8 flag for error
+  # messages even if the connection has UTF-8 enabled. Therefore we
+  # have to convert it to Perl's internal encoding ourselves. See
+  # https://rt.cpan.org/Public/Bug/Display.html?id=53854
+

   my $error = $handle ? $handle->errstr : $self->dbh->errstr;
 
   my $error = $handle ? $handle->errstr : $self->dbh->errstr;
 

+  return $error if version->new("$DBD::Pg::VERSION")->numify >= version->new("2.16.1")->numify;

   return Encode::decode('utf-8', $error);
 }
 
   return Encode::decode('utf-8', $error);
 }
 


@@ -90,7 +98,9 @@ sub add_print_templates {
     croak "File '${src_dir}/$_' does not exist" unless -f "${src_dir}/$_";
   }
 
     croak "File '${src_dir}/$_' does not exist" unless -f "${src_dir}/$_";
   }
 

-  return 1 unless my $template_dir = $::instance_conf->reload->get_templates;
+  # can't use Rose or InstanceConf here because defaults might not be fully upgraded yet.
+  my $defaults = selectfirst_hashref_query($::form, $::form->get_standard_dbh, "SELECT * FROM defaults");
+  return 1 unless my $template_dir = $defaults->{template};

   $::lxdebug->message(LXDebug::DEBUG1(), "add_print_templates: template_dir $template_dir");
 
   foreach my $src_file (@files) {
   $::lxdebug->message(LXDebug::DEBUG1(), "add_print_templates: template_dir $template_dir");
 
   foreach my $src_file (@files) {


@@ -256,8 +266,10 @@ be used.
 =item C<db_errstr [$handle]>
 
 Returns the last database from C<$handle> error message encoded in
 =item C<db_errstr [$handle]>
 
 Returns the last database from C<$handle> error message encoded in

-Perl's internal encoding. The PostgreSQL DBD leaves the UTF-8 flag off
-for error messages even if the C<pg_enable_utf8> attribute is set.
+Perl's internal encoding. The PostgreSQL DBD before 2.16.1 leaves the
+UTF-8 flag off for error messages even if the C<pg_enable_utf8>
+attribute is set. For older versions the error string is already
+encoded correctly and is left unchanged.

 
 C<$handle> is optional and can be one of three things:
 
 
 C<$handle> is optional and can be one of three things: