BUG-Fix: Funktion "Erzeugnis fertigen" sucht Bestandteile im falschen Lager.

[mfinanz.git] / SL / Controller / Order.pm

diff --git a/SL/Controller/Order.pm b/SL/Controller/Order.pm
index c129999b088ebcda4e12f5eb6409d096eb971939..f6a731a9f06945966ada076229024b143d65582e 100644 (file)
--- a/SL/Controller/Order.pm
+++ b/SL/Controller/Order.pm
@@ -3,36 +3,26 @@ package SL::Controller::Order;
 use strict;
 use parent qw(SL::Controller::Base);
 
 use strict;
 use parent qw(SL::Controller::Base);
 

-use SL::Helper::Flash;
+use SL::Helper::Flash qw(flash_later);

 use SL::Presenter;
 use SL::Presenter;

-use SL::Locale::String;
+use SL::Locale::String qw(t8);

 use SL::SessionFile::Random;
 use SL::PriceSource;
 use SL::SessionFile::Random;
 use SL::PriceSource;

-use SL::Form;

 use SL::Webdav;
 use SL::Webdav;

-use SL::Template;

 
 use SL::DB::Order;
 
 use SL::DB::Order;

-use SL::DB::Customer;
-use SL::DB::Vendor;
-use SL::DB::TaxZone;
-use SL::DB::Employee;
-use SL::DB::Project;

 use SL::DB::Default;
 use SL::DB::Unit;
 use SL::DB::Default;
 use SL::DB::Unit;

-use SL::DB::Price;
-use SL::DB::PriceFactor;

 use SL::DB::Part;
 use SL::DB::Printer;
 use SL::DB::Language;
 
 use SL::DB::Part;
 use SL::DB::Printer;
 use SL::DB::Language;
 

-use SL::Helper::DateTime;

 use SL::Helper::CreatePDF qw(:all);
 use SL::Helper::PrintOptions;
 
 use SL::Controller::Helper::GetModels;
 
 use SL::Helper::CreatePDF qw(:all);
 use SL::Helper::PrintOptions;
 
 use SL::Controller::Helper::GetModels;
 

-use List::Util qw(max first);
+use List::Util qw(first);

 use List::MoreUtils qw(none pairwise first_index);
 use English qw(-no_match_vars);
 use File::Spec;
 use List::MoreUtils qw(none pairwise first_index);
 use English qw(-no_match_vars);
 use File::Spec;


@@ -857,7 +847,7 @@ sub _new_item {
 
 # recalculate prices and taxes
 #
 
 # recalculate prices and taxes
 #

-# Using the PriceTaxCalclulator. Store linetotals in the item objects.
+# Using the PriceTaxCalculator. Store linetotals in the item objects.

 sub _recalc {
   my ($self) = @_;
 
 sub _recalc {
   my ($self) = @_;
 


@@ -1068,36 +1058,44 @@ The aim is to provide the user a better expirience and a faster flow
 of work. Also the code should be more readable, more reliable and
 better to maintain.
 
 of work. Also the code should be more readable, more reliable and
 better to maintain.
 

-=head2 key features
+=head2 Key Features

 
 

-=over 2
+=over 4

 
 =item *
 
 =item *

+

 One input row, so that input happens every time at the same place.
 
 =item *
 One input row, so that input happens every time at the same place.
 
 =item *

+

 Use of pickers where possible.
 
 =item *
 Use of pickers where possible.
 
 =item *

+

 Possibility to enter more than one item at once.
 
 =item *
 Possibility to enter more than one item at once.
 
 =item *

+

 Save order only on "save" (and "save and delivery order"-workflow). No
 Save order only on "save" (and "save and delivery order"-workflow). No

-hidden save on "print" or "email". 
+hidden save on "print" or "email".

 
 =item *
 
 =item *

+

 Item list in a scrollable area, so that the workflow buttons stay at
 the bottom.
 
 =item *
 Item list in a scrollable area, so that the workflow buttons stay at
 the bottom.
 
 =item *

+

 Reordering item rows with drag and drop is possible. Sorting item rows is
 possible (by partnumber, description, qty, sellprice and discount for now).
 
 =item *
 Reordering item rows with drag and drop is possible. Sorting item rows is
 possible (by partnumber, description, qty, sellprice and discount for now).
 
 =item *

-No "update" is necessary. All entries and calculations are managed
-with ajax-calls and the page does only reload on "save".
+
+No C<update> is necessary. All entries and calculations are managed
+with ajax-calls and the page does only reload on C<save>.

 
 =item *
 
 =item *

+

 User can see changes immediately, because of the use of java script
 and ajax.
 
 User can see changes immediately, because of the use of java script
 and ajax.
 


@@ -1105,128 +1103,151 @@ and ajax.
 
 =head1 CODE
 
 
 =head1 CODE
 

-=head2 layout
+=head2 Layout

 
 

-=over 2
+=over 4

 
 

-=item *
-SL/Controller/Order.pm: the controller
+=item * C<SL/Controller/Order.pm>

 
 

-=item *
-template/webpages/order/form.html: main form
+the controller

 
 

-=item *
-template/webpages/order/tabs/basic_data.html: main tab for basic_data
+=item * C<template/webpages/order/form.html>

 
 

-This is the only tab here for now. "linked records" and "webdav" tabs are reused
-from generic code.
+main form

 
 

-=over 3
+=item * C<template/webpages/order/tabs/basic_data.html>

 
 

-=item *
-template/webpages/order/tabs/_item_input.html: the input line for items
+Main tab for basic_data.

 
 

-=item *
-template/webpages/order/tabs/_row.html: one row for already entered items
+This is the only tab here for now. "linked records" and "webdav" tabs are
+reused from generic code.

 
 

-=item *
-template/webpages/order/tabs/_tax_row.html: displaying tax information
+=over 4

 
 

-=item *
-template/webpages/order/tabs/_multi_items_dialog.html: dialog for entering more
-than one item at once
+=item * C<template/webpages/order/tabs/_item_input.html>

 
 

-=item *
-template/webpages/order/tabs/_multi_items_result.html: results for the filter in
-the multi items dialog
+The input line for items

 
 

-=item *
-template/webpages/order/tabs/_price_sources_dialog.html: dialog for selecting
-price and discount sources
+=item * C<template/webpages/order/tabs/_row.html>

 
 

-=item *
-template/webpages/order/tabs/_email_dialog.html: email dialog
+One row for already entered items
+
+=item * C<template/webpages/order/tabs/_tax_row.html>
+
+Displaying tax information
+
+=item * C<template/webpages/order/tabs/_multi_items_dialog.html>
+
+Dialog for entering more than one item at once
+
+=item * C<template/webpages/order/tabs/_multi_items_result.html>
+
+Results for the filter in the multi items dialog
+
+=item * C<template/webpages/order/tabs/_price_sources_dialog.html>
+
+Dialog for selecting price and discount sources
+
+=item * C<template/webpages/order/tabs/_email_dialog.html>
+
+Email dialog

 
 =back
 
 
 =back
 

-=item *
-js/kivi.Order.js: java script functions
+=item * C<js/kivi.Order.js>
+
+java script functions

 
 =back
 
 =head1 TODO
 
 
 =back
 
 =head1 TODO
 

-=over 2
+=over 4

 
 

-=item *
+=item * testing

 
 

-testing
+=item * currency

 
 

+=item * customer/vendor details ('D'-button)

 
 

-=item *
+=item * credit limit

 
 

-currency
+=item * more workflows (save as new / invoice)

 
 

+=item * price sources: little symbols showing better price / better discount

 
 

-=item *
+=item * custom shipto address

 
 

-customer/vendor details ('D'-button)
+=item * periodic invoices

 
 

+=item * more details on second row (marge, ...)

 
 

-=item *
+=item * language / part translations

 
 

-credit limit
+=item * access rights

 
 

+=item * preset salesman from customer

 
 

-=item *
+=item * display weights

 
 

-more workflows (save as new / invoice)
+=item * force project if enabled in client config

 
 

+=item * history

 
 

-=item *
+=item * mtime check
+
+=back

 
 

-price sources: little symbols showing better price / better discount
+=head1 KNOWN BUGS AND CAVEATS

 
 

+=over 4

 
 =item *
 
 
 =item *
 

-custom shipto address
-
+Customer discount is not displayed as a valid discount in price source popup
+(this might be a bug in price sources)

 
 =item *
 
 
 =item *
 

-periodic invoices
-
+No indication that double click expands second row, no exand all button

 
 =item *
 
 
 =item *
 

-more details on second row (marge, ...)
-
+Implementation of second row with a tbody for every item is not supported by
+our css.

 
 =item *
 
 
 =item *
 

-language / part translations
-
+As a consequence row striping does not currently work

 
 =item *
 
 
 =item *
 

-access rights
+Inline creation of parts is not currently supported

 
 

+=item *
+
+Table header is not sticky in the scrolling area.

 
 =item *
 
 
 =item *
 

-preset salesman from customer
+Sorting does not include C<position>, neither does reordering.

 
 

+This behavior was implemented intentionally. But we can discuss, which behavior
+should be implemented.

 
 =item *
 
 
 =item *
 

-display weights
+C<show_multi_items_dialog> does not use the currently inserted string for
+filtering.

 
 

+=item * Performance

 
 

-=item *
+Rendering a 50 items order takes twice as long as the old code.

 
 

-force project if enabled in client config
+90% of that is rendering the (hidden) second rows, and 50% of those again are
+checks for is_valid and C<INCLUDE> on the cvar input template.

 
 

+Suggestion: fetch second rows when asked for.

 
 =back
 
 
 =back