DO.pm: wo croak() genutzt wird auch Carp usen

[mfinanz.git] / SL / ReportGenerator.pm

diff --git a/SL/ReportGenerator.pm b/SL/ReportGenerator.pm
index 02c194070ca797be89ebdd08f3bbfd8b802175fb..451e9c002175b1b410dc6fe80bda1f726b127f23 100644 (file)
--- a/SL/ReportGenerator.pm
+++ b/SL/ReportGenerator.pm
@@ -1,11 +1,12 @@
 package SL::ReportGenerator;
 
 package SL::ReportGenerator;
 

-use IO::Wrap;
+use Data::Dumper;

 use List::Util qw(max);
 use Text::CSV_XS;
 use List::Util qw(max);
 use Text::CSV_XS;

-use Text::Iconv;
+#use PDF::API2;    # these two eat up to .75s on startup. only load them if we actually need them
+#use PDF::Table;

 
 

-use SL::Form;
+use strict;

 
 # Cause locales.pl to parse these files:
 # parse_html_template('report_generator/html_report')
 
 # Cause locales.pl to parse these files:
 # parse_html_template('report_generator/html_report')


@@ -22,6 +23,7 @@ sub new {
   $self->{options}  = {
     'std_column_visibility' => 0,
     'output_format'         => 'HTML',
   $self->{options}  = {
     'std_column_visibility' => 0,
     'output_format'         => 'HTML',

+    'controller_class   '   => '',

     'allow_pdf_export'      => 1,
     'allow_csv_export'      => 1,
     'html_template'         => 'report_generator/html_report',
     'allow_pdf_export'      => 1,
     'allow_csv_export'      => 1,
     'html_template'         => 'report_generator/html_report',


@@ -71,6 +73,12 @@ sub set_columns {
     $column->{visible} = $self->{options}->{std_column_visibility} unless defined $column->{visible};
   }
 
     $column->{visible} = $self->{options}->{std_column_visibility} unless defined $column->{visible};
   }
 

+  if( $::form->{report_generator_csv_options_for_import} ) {
+    foreach my $key (keys %{ $self->{columns} }) {
+      $self->{columns}{$key}{text} = $key;
+    }
+  }
+

   $self->set_column_order(sort keys %{ $self->{columns} });
 }
 
   $self->set_column_order(sort keys %{ $self->{columns} });
 }
 


@@ -113,7 +121,7 @@ sub add_data {
         $row->{$column}->{align}   = $self->{columns}->{$column}->{align} unless (defined $row->{$column}->{align});
       }
 
         $row->{$column}->{align}   = $self->{columns}->{$column}->{align} unless (defined $row->{$column}->{align});
       }
 

-      foreach my $field (qw(data link)) {
+      foreach my $field (qw(data link link_class)) {

         map { $row->{$_}->{$field} = [ $row->{$_}->{$field} ] if (ref $row->{$_}->{$field} ne 'ARRAY') } keys %{ $row };
       }
     }
         map { $row->{$_}->{$field} = [ $row->{$_}->{$field} ] if (ref $row->{$_}->{$field} ne 'ARRAY') } keys %{ $row };
       }
     }


@@ -202,14 +210,17 @@ sub set_custom_headers {
 sub get_attachment_basename {
   my $self     = shift;
   my $filename =  $self->{options}->{attachment_basename} || 'report';
 sub get_attachment_basename {
   my $self     = shift;
   my $filename =  $self->{options}->{attachment_basename} || 'report';

+
+  # FIXME: this is bonkers. add a real sluggify method somewhere or import one.

   $filename    =~ s|.*\\||;
   $filename    =~ s|.*/||;
   $filename    =~ s|.*\\||;
   $filename    =~ s|.*/||;

+  $filename    =~ s| |_|g;

 
   return $filename;
 }
 
 sub generate_with_headers {
 
   return $filename;
 }
 
 sub generate_with_headers {

-  my $self   = shift;
+  my ($self, %params) = @_;

   my $format = lc $self->{options}->{output_format};
   my $form   = $self->{form};
 
   my $format = lc $self->{options}->{output_format};
   my $form   = $self->{form};
 


@@ -220,16 +231,19 @@ sub generate_with_headers {
   if ($format eq 'html') {
     my $title      = $form->{title};
     $form->{title} = $self->{title} if ($self->{title});
   if ($format eq 'html') {
     my $title      = $form->{title};
     $form->{title} = $self->{title} if ($self->{title});

-    $form->header();
+    $form->header(no_layout => $params{no_layout});

     $form->{title} = $title;
 
     print $self->generate_html_content();
 
   } elsif ($format eq 'csv') {
     $form->{title} = $title;
 
     print $self->generate_html_content();
 
   } elsif ($format eq 'csv') {

+    # FIXME: don't do mini http in here

     my $filename = $self->get_attachment_basename();
     print qq|content-type: text/csv\n|;
     print qq|content-disposition: attachment; filename=${filename}.csv\n\n|;
     my $filename = $self->get_attachment_basename();
     print qq|content-type: text/csv\n|;
     print qq|content-disposition: attachment; filename=${filename}.csv\n\n|;

-    $self->generate_csv_content();
+    $::locale->with_raw_io(\*STDOUT, sub {
+      $self->generate_csv_content();
+    });

 
   } elsif ($format eq 'pdf') {
     $self->generate_pdf_content();
 
   } elsif ($format eq 'pdf') {
     $self->generate_pdf_content();


@@ -270,8 +284,10 @@ sub prepare_html_content {
 
     my $header = {
       'name'                     => $name,
 
     my $header = {
       'name'                     => $name,

+      'align'                    => $column->{align},

       'link'                     => $column->{link},
       'text'                     => $column->{text},
       'link'                     => $column->{link},
       'text'                     => $column->{text},

+      'raw_header_data'          => $column->{raw_header_data},

       'show_sort_indicator'      => $name eq $opts->{sort_indicator_column},
       'sort_indicator_direction' => $opts->{sort_indicator_direction},
     };
       'show_sort_indicator'      => $name eq $opts->{sort_indicator_column},
       'sort_indicator_direction' => $opts->{sort_indicator_direction},
     };


@@ -330,12 +346,13 @@ sub prepare_html_content {
           next;
         }
 
           next;
         }
 

-        my $col = $row->{$col_name};
+        my $col = $row->{$col_name} || { data => [] };

         $col->{CELL_ROWS} = [ ];
         foreach my $i (0 .. scalar(@{ $col->{data} }) - 1) {
           push @{ $col->{CELL_ROWS} }, {
         $col->{CELL_ROWS} = [ ];
         foreach my $i (0 .. scalar(@{ $col->{data} }) - 1) {
           push @{ $col->{CELL_ROWS} }, {

-            'data' => $self->html_format($col->{data}->[$i]),
+            'data' => '' . $self->html_format($col->{data}->[$i]),

             'link' => $col->{link}->[$i],
             'link' => $col->{link}->[$i],

+            link_class => $col->{link_class}->[$i],

           };
         }
 
           };
         }
 


@@ -369,9 +386,6 @@ sub prepare_html_content {
 
   my $allow_pdf_export = $opts->{allow_pdf_export};
 
 
   my $allow_pdf_export = $opts->{allow_pdf_export};
 

-  eval { require PDF::API2; require PDF::Table; };
-  $allow_pdf_export |= 1 if (! $@);
-

   my $variables = {
     'TITLE'                => $opts->{title},
     'TOP_INFO_TEXT'        => $self->html_format($opts->{top_info_text}),
   my $variables = {
     'TITLE'                => $opts->{title},
     'TOP_INFO_TEXT'        => $self->html_format($opts->{top_info_text}),


@@ -388,6 +402,8 @@ sub prepare_html_content {
     'EXPORT_VARIABLE_LIST' => join(' ', @{ $self->{export}->{variable_list} }),
     'EXPORT_NEXTSUB'       => $self->{export}->{nextsub},
     'DATA_PRESENT'         => $self->{data_present},
     'EXPORT_VARIABLE_LIST' => join(' ', @{ $self->{export}->{variable_list} }),
     'EXPORT_NEXTSUB'       => $self->{export}->{nextsub},
     'DATA_PRESENT'         => $self->{data_present},

+    'CONTROLLER_DISPATCH'  => $opts->{controller_class},
+    'TABLE_CLASS'          => $opts->{table_class},

   };
 
   return $variables;
   };
 
   return $variables;


@@ -397,7 +413,8 @@ sub generate_html_content {
   my $self      = shift;
   my $variables = $self->prepare_html_content();
 
   my $self      = shift;
   my $variables = $self->prepare_html_content();
 

-  return $self->{form}->parse_html_template($self->{options}->{html_template}, $variables);
+  my $stuff  = $self->{form}->parse_html_template($self->{options}->{html_template}, $variables);
+  return $stuff;

 }
 
 sub _cm2bp {
 }
 
 sub _cm2bp {


@@ -423,11 +440,13 @@ sub generate_pdf_content {
   my (@data, @column_props, @cell_props);
 
   my ($data_row, $cell_props_row);
   my (@data, @column_props, @cell_props);
 
   my ($data_row, $cell_props_row);

-  my @visible_columns = $self->get_visible_columns('HTML');
+  my @visible_columns = $self->get_visible_columns('PDF');

   my $num_columns     = scalar @visible_columns;
   my $num_header_rows = 1;
 
   my $num_columns     = scalar @visible_columns;
   my $num_header_rows = 1;
 

-  foreach $name (@visible_columns) {
+  my $font_encoding   = 'UTF-8';
+
+  foreach my $name (@visible_columns) {

     push @column_props, { 'justify' => $self->{columns}->{$name}->{align} eq 'right' ? 'right' : 'left' };
   }
 
     push @column_props, { 'justify' => $self->{columns}->{$name}->{align} eq 'right' ? 'right' : 'left' };
   }
 


@@ -437,8 +456,8 @@ sub generate_pdf_content {
     push @data,       $data_row;
     push @cell_props, $cell_props_row;
 
     push @data,       $data_row;
     push @cell_props, $cell_props_row;
 

-    foreach $name (@visible_columns) {
-      $column = $self->{columns}->{$name};
+    foreach my $name (@visible_columns) {
+      my $column = $self->{columns}->{$name};

 
       push @{ $data_row },       $column->{text};
       push @{ $cell_props_row }, {};
 
       push @{ $data_row },       $column->{text};
       push @{ $cell_props_row }, {};


@@ -454,8 +473,17 @@ sub generate_pdf_content {
       push @cell_props, $cell_props_row;
 
       foreach my $custom_header_col (@{ $custom_header_row }) {
       push @cell_props, $cell_props_row;
 
       foreach my $custom_header_col (@{ $custom_header_row }) {

-        push @{ $data_row },       $custom_header_col->{text};
-        push @{ $cell_props_row }, {};
+        push @{ $data_row }, $custom_header_col->{text};
+
+        my $num_output  = ($custom_header_col->{colspan} * 1 > 1) ? $custom_header_col->{colspan} : 1;
+        if ($num_output > 1) {
+          push @{ $data_row },       ('') x ($num_output - 1);
+          push @{ $cell_props_row }, { 'colspan' => $num_output };
+          push @{ $cell_props_row }, ({ }) x ($num_output - 1);
+
+        } else {
+          push @{ $cell_props_row }, {};
+        }

       }
     }
   }
       }
     }
   }


@@ -478,24 +506,27 @@ sub generate_pdf_content {
     }
 
     foreach my $row (@{ $row_set }) {
     }
 
     foreach my $row (@{ $row_set }) {

-      $data_row = [];
-      push @data, $data_row;
+      $data_row       = [];
+      $cell_props_row = [];
+
+      push @data,       $data_row;
+      push @cell_props, $cell_props_row;

 
       my $col_idx = 0;
       foreach my $col_name (@visible_columns) {
         my $col = $row->{$col_name};
 
       my $col_idx = 0;
       foreach my $col_name (@visible_columns) {
         my $col = $row->{$col_name};

-        push @{ $data_row }, join("\n", @{ $col->{data} });
+        push @{ $data_row }, join("\n", @{ $col->{data} || [] });

 
         $column_props[$col_idx]->{justify} = 'right' if ($col->{align} eq 'right');
 
 
         $column_props[$col_idx]->{justify} = 'right' if ($col->{align} eq 'right');
 

-        $col_idx++;
-      }
+        my $cell_props = { };
+        push @{ $cell_props_row }, $cell_props;

 
 

-      $cell_props_row = [];
-      push @cell_props, $cell_props_row;
+        if ($col->{colspan} && $col->{colspan} > 1) {
+          $cell_props->{colspan} = $col->{colspan};
+        }

 
 

-      foreach (0 .. $num_columns - 1) {
-        push @{ $cell_props_row }, { };
+        $col_idx++;

       }
     }
   }
       }
     }
   }


@@ -542,15 +573,15 @@ sub generate_pdf_content {
   $pdf->mediabox($paper_width, $paper_height);
 
   my $font              = $pdf->corefont(defined $pdfopts->{font_name} && $supported_fonts{lc $pdfopts->{font_name}} ? ucfirst $pdfopts->{font_name} : 'Verdana',
   $pdf->mediabox($paper_width, $paper_height);
 
   my $font              = $pdf->corefont(defined $pdfopts->{font_name} && $supported_fonts{lc $pdfopts->{font_name}} ? ucfirst $pdfopts->{font_name} : 'Verdana',

-                                         '-encoding' => $main::dbcharset || 'ISO-8859-15');
+                                         '-encoding' => $font_encoding);

   my $font_size         = $pdfopts->{font_size} || 7;
   my $title_font_size   = $font_size + 1;
   my $padding           = 1;
   my $font_height       = $font_size + 2 * $padding;
   my $title_font_height = $font_size + 2 * $padding;
 
   my $font_size         = $pdfopts->{font_size} || 7;
   my $title_font_size   = $font_size + 1;
   my $padding           = 1;
   my $font_height       = $font_size + 2 * $padding;
   my $title_font_height = $font_size + 2 * $padding;
 

-  my $header_height     = 2 * $title_font_height if ($opts->{title});
-  my $footer_height     = 2 * $font_height       if ($pdfopts->{number});
+  my $header_height     = $opts->{title}     ? 2 * $title_font_height : undef;
+  my $footer_height     = $pdfopts->{number} ? 2 * $font_height       : undef;

 
   my $top_text_height   = 0;
 
 
   my $top_text_height   = 0;
 


@@ -595,6 +626,8 @@ sub generate_pdf_content {
                 },
                 'column_props'          => \@column_props,
                 'cell_props'            => \@cell_props,
                 },
                 'column_props'          => \@column_props,
                 'cell_props'            => \@cell_props,

+                'max_word_length'       => 60,
+                'border'                => 0.5,

     );
 
   foreach my $page_num (1..$pdf->pages()) {
     );
 
   foreach my $page_num (1..$pdf->pages()) {


@@ -610,12 +643,13 @@ sub generate_pdf_content {
     }
 
     if ($opts->{title}) {
     }
 
     if ($opts->{title}) {

+      my $title    = $opts->{title};

       my $text_obj = $curpage->text();
 
       $text_obj->font($font, $title_font_size);
       my $text_obj = $curpage->text();
 
       $text_obj->font($font, $title_font_size);

-      $text_obj->translate(($paper_width - $margin_left - $margin_right) / 2 + $margin_left - $text_obj->advancewidth($opts->{title}) / 2,
+      $text_obj->translate(($paper_width - $margin_left - $margin_right) / 2 + $margin_left - $text_obj->advancewidth($title) / 2,

                            $paper_height - $margin_top);
                            $paper_height - $margin_top);

-      $text_obj->text($opts->{title}, '-underline' => 1);
+      $text_obj->text($title, '-underline' => 1);

     }
   }
 
     }
   }
 


@@ -640,7 +674,9 @@ sub generate_pdf_content {
     print qq|content-type: application/pdf\n|;
     print qq|content-disposition: attachment; filename=${filename}.pdf\n\n|;
 
     print qq|content-type: application/pdf\n|;
     print qq|content-disposition: attachment; filename=${filename}.pdf\n\n|;
 

-    print $content;
+    $::locale->with_raw_io(\*STDOUT, sub {
+      print $content;
+    });

   }
 }
 
   }
 }
 


@@ -666,19 +702,26 @@ sub _print_content {
   }
 }
 
   }
 }
 

-sub unescape_string {
-  my $self  = shift;
-  my $text  = shift;
-  my $iconv = $main::locale->{iconv};
+sub _handle_quoting_and_encoding {
+  my ($self, $text, $do_unquote) = @_;

 
 

-  $text     = $main::locale->unquote_special_chars('HTML', $text);
-  $text     = $main::locale->{iconv}->convert($text) if ($main::locale->{iconv});
+  $text = $main::locale->unquote_special_chars('HTML', $text) if $do_unquote;
+  $text = Encode::encode('UTF-8', $text);

 
   return $text;
 }
 
 sub generate_csv_content {
 
   return $text;
 }
 
 sub generate_csv_content {

-  my $self = shift;
+  my $self   = shift;
+  my $stdout = ($::dispatcher->get_standard_filehandles)[1];
+
+  # Text::CSV_XS seems to downgrade to bytes already (see
+  # SL/FCGIFixes.pm). Therefore don't let FCGI do that again.
+  $::locale->with_raw_io($stdout, sub { $self->_generate_csv_content($stdout) });
+}
+
+sub _generate_csv_content {
+  my ($self, $stdout) = @_;

 
   my %valid_sep_chars    = (';' => ';', ',' => ',', ':' => ':', 'TAB' => "\t");
   my %valid_escape_chars = ('"' => 1, "'" => 1);
 
   my %valid_sep_chars    = (';' => ';', ',' => ',', ':' => ':', 'TAB' => "\t");
   my %valid_escape_chars = ('"' => 1, "'" => 1);


@@ -698,12 +741,11 @@ sub generate_csv_content {
                                 'quote_char'  => $quote_char,
                                 'eol'         => $eol, });
 
                                 'quote_char'  => $quote_char,
                                 'eol'         => $eol, });
 

-  my $stdout          = wraphandle(\*STDOUT);

   my @visible_columns = $self->get_visible_columns('CSV');
 
   if ($opts->{headers}) {
     if (!$self->{custom_headers}) {
   my @visible_columns = $self->get_visible_columns('CSV');
 
   if ($opts->{headers}) {
     if (!$self->{custom_headers}) {

-      $csv->print($stdout, [ map { $self->unescape_string($self->{columns}->{$_}->{text}) } @visible_columns ]);
+      $csv->print($stdout, [ map { $self->_handle_quoting_and_encoding($self->{columns}->{$_}->{text}, 1) } @visible_columns ]);

 
     } else {
       foreach my $row (@{ $self->{custom_headers} }) {
 
     } else {
       foreach my $row (@{ $self->{custom_headers} }) {


@@ -711,7 +753,7 @@ sub generate_csv_content {
 
         foreach my $col (@{ $row }) {
           my $num_output = ($col->{colspan} && ($col->{colspan} > 1)) ? $col->{colspan} : 1;
 
         foreach my $col (@{ $row }) {
           my $num_output = ($col->{colspan} && ($col->{colspan} > 1)) ? $col->{colspan} : 1;

-          push @{ $fields }, ($self->unescape_string($col->{text})) x $num_output;
+          push @{ $fields }, ($self->_handle_quoting_and_encoding($col->{text}, 1)) x $num_output;

         }
 
         $csv->print($stdout, $fields);
         }
 
         $csv->print($stdout, $fields);


@@ -730,10 +772,10 @@ sub generate_csv_content {
           next;
         }
 
           next;
         }
 

-        my $num_output = ($col->{colspan} && ($col->{colspan} > 1)) ? $col->{colspan} : 1;
+        my $num_output = ($row->{$col}{colspan} && ($row->{$col}->{colspan} > 1)) ? $row->{$col}->{colspan} : 1;

         $skip_next     = $num_output - 1;
 
         $skip_next     = $num_output - 1;
 

-        push @data, join($eol, map { s/\r?\n/$eol/g; $_ } @{ $row->{$col}->{data} });
+        push @data, join($eol, map { s/\r?\n/$eol/g; $self->_handle_quoting_and_encoding($_, 0) } @{ $row->{$col}->{data} });

         push @data, ('') x $skip_next if ($skip_next);
       }
 
         push @data, ('') x $skip_next if ($skip_next);
       }
 


@@ -742,13 +784,17 @@ sub generate_csv_content {
   }
 }
 
   }
 }
 

+sub check_for_pdf_api {
+  return eval { require PDF::API2; 1; } ? 1 : 0;
+}
+

 1;
 
 __END__
 
 =head1 NAME
 
 1;
 
 __END__
 
 =head1 NAME
 

-SL::ReportGenerator.pm: the Lx-Office way of getting data in shape
+SL::ReportGenerator.pm: the kivitendo way of getting data in shape

 
 =head1 SYNOPSIS
 
 
 =head1 SYNOPSIS
 


@@ -759,7 +805,7 @@ SL::ReportGenerator.pm: the Lx-Office way of getting data in shape
      $report->add_data($row1, $row2, @more_rows);
      $report->generate_with_headers();
 
      $report->add_data($row1, $row2, @more_rows);
      $report->generate_with_headers();
 

-This creates a report object, sets a few columns, adds some data and generates a standard report. 
+This creates a report object, sets a few columns, adds some data and generates a standard report.

 Sorting of columns will be alphabetic, and options will be set to their defaults.
 The report will be printed including table headers, html headers and http headers.
 
 Sorting of columns will be alphabetic, and options will be set to their defaults.
 The report will be printed including table headers, html headers and http headers.
 


@@ -772,9 +818,9 @@ Then there are some options made by the user, such as hidden columns. You add mo
 Then it lacks usability. You want it to be able to sort the data. You add code for that.
 Then there are too many results, you need pagination, you want to print or export that data..... and so on.
 
 Then it lacks usability. You want it to be able to sort the data. You add code for that.
 Then there are too many results, you need pagination, you want to print or export that data..... and so on.
 

-The ReportGenerator class was designed because this exact scenario happened about half a dozen times in Lx-Office. 
-It's purpose is to manage all those formating, culling, sorting, and templating. 
-Which makes it almost as complicated to use as doing the work for yourself.
+The ReportGenerator class was designed because this exact scenario happened about half a dozen times in kivitendo.
+It's purpose is to manage all those formating, culling, sorting, and templating.
+Which makes it almost as complicated to use as doing the work by yourself.

 
 =head1 FUNCTIONS
 
 
 =head1 FUNCTIONS
 


@@ -794,16 +840,21 @@ Sets the order of columns. Any columns not present here are appended in alphabet
 
 =item set_sort_indicator $column,$direction
 
 
 =item set_sort_indicator $column,$direction
 

-Sets sorting ot the table by specifying a column and a direction, where the direction will be evaluated to ascending if true.
-Note that this is only for displaying. The data has to be presented already sorted.
+Sets sorting of the table by specifying a column and a direction, where the direction will be evaluated to ascending if true.
+Note that this is only for displaying. The data has to have already been sorted when it was added.

 
 =item add_data \@data
 
 =item add_data \%data
 
 
 =item add_data \@data
 
 =item add_data \%data
 

-Adds data to the report. A given hash_ref is interpreted as a single line of data, every array_ref as a collection of lines. 
-Every line will be expected to be in a kay => value format. Note that the rows have to be already sorted. 
-ReportGenerator does only colum sorting on its own, and provides links to sorting and visual cue as to which column was sorted by.
+Adds data to the report. A given hash_ref is interpreted as a single line of
+data, every array_ref as a collection of lines.  Every line will be expected to
+be in a key => value format. Note that the rows have to already have been
+sorted.
+
+The ReportGenerator is only able to display pre-sorted data and to indicate by
+which column and in which direction the data has been sorted via visual clues
+in the column headers. It also provides links to invert the sort direction.

 
 =item add_separator
 
 
 =item add_separator
 


@@ -812,12 +863,12 @@ Adds a separator line to the report.
 =item add_control \%data
 
 Adds a control element to the data. Control elements are an experimental feature to add functionality to a report the regular data cannot.
 =item add_control \%data
 
 Adds a control element to the data. Control elements are an experimental feature to add functionality to a report the regular data cannot.

-Every control element needs to set IS_CONTROL_DATA, in order to be recongnized by the template. 
+Every control element needs to set IS_CONTROL_DATA, in order to be recognized by the template.

 Currently the only control element is a colspan element, which can be used as a mini header further down the report.
 
 =item clear_data
 
 Currently the only control element is a colspan element, which can be used as a mini header further down the report.
 
 =item clear_data
 

-Deletes all data filled into the report, but keeps options set.
+Deletes all data added to the report, but keeps options set.

 
 =item set_options %options
 
 
 =item set_options %options
 


@@ -837,7 +888,7 @@ Returns the set attachment_basename option, or 'report' if nothing was set. See
 
 =item generate_with_headers
 
 
 =item generate_with_headers
 

-Parses the report, adds headers and prints it out. Headers depend on the option 'output_format', 
+Parses the report, adds headers and prints it out. Headers depend on the option 'output_format',

 for example 'HTML' will add proper table headers, html headers and http headers. See configuration for this option.
 
 =item get_visible_columns $format
 for example 'HTML' will add proper table headers, html headers and http headers. See configuration for this option.
 
 =item get_visible_columns $format


@@ -850,29 +901,21 @@ Escapes HTML characters in $value and substitutes newlines with '<br>'. Returns
 
 =item prepare_html_content $column,$name,@column_headers
 
 
 =item prepare_html_content $column,$name,@column_headers
 

-Parses the data, and sets internal data needed for certain output format. Must be called once before the template is invoked. 
-Should not be called extrenally, since all render and generate functions invoke it anyway.
- 
+Parses the data, and sets internal data needed for certain output format. Must be called once before the template is invoked.
+Should not be called externally, since all render and generate functions invoke it anyway.
+

 =item generate_html_content
 
 The html generation function. Is invoked by generate_with_headers.
 
 =item generate_pdf_content
 
 =item generate_html_content
 
 The html generation function. Is invoked by generate_with_headers.
 
 =item generate_pdf_content
 

-The PDF generation function. It is invoked by generate_with_headers, tests whether or not the Perl module PDF::API2 is installed and calls render_pdf_with_pdf_api2 if it is and render_pdf_with_html2ps otherwise.
+The PDF generation function. It is invoked by generate_with_headers and renders the PDF with the PDF::API2 library.

 
 =item generate_csv_content
 
 The CSV generation function. Uses XS_CSV to parse the information into csv.
 
 
 =item generate_csv_content
 
 The CSV generation function. Uses XS_CSV to parse the information into csv.
 

-=item render_pdf_with_pdf_api2
-
-PDF render function using the Perl module PDF::API2.
-
-=item render_pdf_with_html2ps
-
-PDF render function using the external application html2ps.
-

 =back
 
 =head1 CONFIGURATION
 =back
 
 =head1 CONFIGURATION


@@ -893,7 +936,7 @@ Output format. Used by generate_with_headers to determine the format. Supported
 
 =item allow_pdf_export
 
 
 =item allow_pdf_export
 

-Used to determine if a button for PDF export should be displayed. Default is yes. The PDF button is hidden if neither the Perl module PDF::API2 nor the external applications html2ps and Ghostscript are available regardless of this parameter's value.
+Used to determine if a button for PDF export should be displayed. Default is yes.

 
 =item allow_csv_export
 
 
 =item allow_csv_export
 


@@ -903,6 +946,12 @@ Used to determine if a button for CSV export should be displayed. Default is yes
 
 The template to be used for HTML reports. Default is 'report_generator/html_report'.
 
 
 The template to be used for HTML reports. Default is 'report_generator/html_report'.
 

+=item controller_class
+
+If this is used from a C<SL::Controller::Base> based controller class, pass the
+class name here and make sure C<SL::Controller::Helper::ReportGenerator> is
+used in the controller. That way the exports stay functional.
+

 =back
 
 =head2 PDF Options
 =back
 
 =head2 PDF Options


@@ -917,7 +966,7 @@ Paper size. Default is a4. Supported paper sizes are a3, a4, a5, letter and lega
 
 Landscape or portrait. Default is landscape.
 
 
 Landscape or portrait. Default is landscape.
 

-=item font_name 
+=item font_name

 
 Default is Verdana. Supported font names are Courier, Georgia, Helvetica, Times and Verdana. This option only affects the rendering with PDF::API2.
 
 
 Default is Verdana. Supported font names are Courier, Georgia, Helvetica, Times and Verdana. This option only affects the rendering with PDF::API2.