Items in Belegen können durch LinkedRecords angesprochen werden

[mfinanz.git] / SL / PriceSource.pm

diff --git a/SL/PriceSource.pm b/SL/PriceSource.pm
index ac419a6705486c63e8add17486654c96baa745b1..c8cdc6cd197a2201da5ee9ac6b56535aae91a272 100644 (file)
--- a/SL/PriceSource.pm
+++ b/SL/PriceSource.pm
@@ -4,6 +4,7 @@ use strict;
 use parent 'SL::DB::Object';
 use Rose::Object::MakeMethods::Generic (
   scalar => [ qw(record_item record) ],
 use parent 'SL::DB::Object';
 use Rose::Object::MakeMethods::Generic (
   scalar => [ qw(record_item record) ],

+  'array --get_set_init' => [ qw(all_price_sources) ],

 );
 
 use List::UtilsBy qw(min_by max_by);
 );
 
 use List::UtilsBy qw(min_by max_by);


@@ -11,12 +12,12 @@ use SL::PriceSource::ALL;
 use SL::PriceSource::Price;
 use SL::Locale::String;
 
 use SL::PriceSource::Price;
 use SL::Locale::String;
 

-sub all_price_sources {
+sub init_all_price_sources {

   my ($self) = @_;
 
   my ($self) = @_;
 

-  map {
+  [ map {

     $_->new(record_item => $self->record_item, record => $self->record)
     $_->new(record_item => $self->record_item, record => $self->record)

-  } SL::PriceSource::ALL->all_enabled_price_sources
+  } SL::PriceSource::ALL->all_enabled_price_sources ]

 }
 
 sub price_from_source {
 }
 
 sub price_from_source {


@@ -40,11 +41,11 @@ sub available_discounts {
 }
 
 sub best_price {
 }
 
 sub best_price {

-  min_by { $_->price } grep { $_->price > 0 } grep { $_ } map { $_->best_price } $_[0]->all_price_sources;
+  min_by { $_->price } max_by { $_->priority } grep { $_->price > 0 } grep { $_ } map { $_->best_price } $_[0]->all_price_sources;

 }
 
 sub best_discount {
 }
 
 sub best_discount {

-  max_by { $_->discount } grep { $_->discount } grep { $_ } map { $_->best_discount } $_[0]->all_price_sources;
+  max_by { $_->discount } max_by { $_->priority } grep { $_->discount } grep { $_ } map { $_->best_discount } $_[0]->all_price_sources;

 }
 
 sub empty_price {
 }
 
 sub empty_price {


@@ -71,16 +72,16 @@ together to calculate available prices for a position in a record.
 Each algorithm can access details of the record to realize dependencies on
 part, customer, vendor, date, quantity etc, which was previously not possible.
 
 Each algorithm can access details of the record to realize dependencies on
 part, customer, vendor, date, quantity etc, which was previously not possible.
 

-=head1 BACKGROUND AND PHILOSOPY
+=head1 BACKGROUND AND PHILOSOPHY

 
 sql ledger and subsequently Lx-Office had three prices per part: sellprice,
 listprice and lastcost. At the moment a part is loaded into a record, the
 
 sql ledger and subsequently Lx-Office had three prices per part: sellprice,
 listprice and lastcost. At the moment a part is loaded into a record, the

-applicable price is copied and after that free to be changed.
+applicable price is copied and after that it is free to be changed.

 
 

-Later on additional things joined. Various types of discount, vendor pricelists
+Later on additional things were added. Various types of discount, vendor pricelists

 and the infamous price groups. The problem is not that those didn't work, the
 and the infamous price groups. The problem is not that those didn't work, the

-problem is, that they had to guess to much when to change a price with the
-available price from database, and when to leave the user entered price.
+problem is, that they had to guess too much when to change a price with the
+available price from the database, and when to leave the user entered price.

 
 Unrelated to that, users asked for more ways to store special prices, based on
 qty (block pricing, bulk discount), based on date (special offers), based on
 
 Unrelated to that, users asked for more ways to store special prices, based on
 qty (block pricing, bulk discount), based on date (special offers), based on