} else {
# normal rename
+ my $res;
+
eval {
- my $res = $file->rename($::form->{to});
+ $res = $file->rename($::form->{to});
$main::lxdebug->message(LXDebug->DEBUG2(), "rename result=".$res);
- if ($res > SL::File::RENAME_OK) {
- $self->js->flash('error',
- $res == SL::File::RENAME_EXISTS ? $::locale->text('File still exists !')
- : $res == SL::File::RENAME_SAME ? $::locale->text('Same Filename !')
- : $::locale->text('File not exists !'))->render;
- return 1;
- }
1;
} or do {
$self->js->flash( 'error', t8('internal error (see details)'))
->flash_detail('error', $@)->render;
return;
+ };
+
+ if ($res != SL::File::RENAME_OK) {
+ $self->js->flash('error',
+ $res == SL::File::RENAME_EXISTS ? $::locale->text('File still exists !')
+ : $res == SL::File::RENAME_SAME ? $::locale->text('Same Filename !')
+ : $::locale->text('File not exists !'))
+ ->render;
+ return;
}
}
$self->is_global($::form->{is_global});
sub check_object_params {
my ($self) = @_;
- my $id = $::form->{object_id} +0;
- my $draftid = $::form->{draft_id} +0;
+ my $id = ($::form->{object_id} // 0) * 1;
+ my $draftid = ($::form->{draft_id} // 0) * 1;
my $gldoc = 0;
my $type = undef;
my @files;
$main::lxdebug->message(LXDebug->DEBUG2(), "do_list: object_id=".$self->object_id." object_type=".$self->object_type." file_type=".$self->file_type." json=".$json);
if ( $self->file_type eq 'document' ) {
+ my @object_types;
+ push @object_types, $self->object_type;
+ push @object_types, ('dunning','dunning1','dunning2','dunning3') if $self->object_type eq 'invoice';
@files = SL::File->get_all_versions(object_id => $self->object_id ,
- object_type => $self->object_type,
+ object_type => \@object_types,
file_type => $self->file_type );
$main::lxdebug->message(LXDebug->DEBUG2(), "cnt1=".scalar(@files));