Finanzcontrolling: Refactor Accessors, Warnungen vermeiden

[mfinanz.git] / SL / Controller / RequirementSpecVersion.pm

diff --git a/SL/Controller/RequirementSpecVersion.pm b/SL/Controller/RequirementSpecVersion.pm
index 9258698e8d1b2ad15fc0b4d4ebcf8876d32513ea..e97d2252b6effc7a020ac2d98390af750144387b 100644 (file)
--- a/SL/Controller/RequirementSpecVersion.pm
+++ b/SL/Controller/RequirementSpecVersion.pm
@@ -17,7 +17,7 @@ use SL::Locale::String;
 
 use Rose::Object::MakeMethods::Generic
 (
 
 use Rose::Object::MakeMethods::Generic
 (

-  'scalar --get_set_init' => [ qw(requirement_spec version js versioned_copies) ],
+  'scalar --get_set_init' => [ qw(requirement_spec version js) ],

 );
 
 __PACKAGE__->run_before('check_auth');
 );
 
 __PACKAGE__->run_before('check_auth');


@@ -72,13 +72,14 @@ sub action_create {
   return $self->js->error(@errors)->render($self) if @errors;
 
   my $db     = $self->requirement_spec->db;
   return $self->js->error(@errors)->render($self) if @errors;
 
   my $db     = $self->requirement_spec->db;

-  my @result = $self->version($self->requirement_spec->create_version(%attributes));
+  my @result = $self->requirement_spec->create_version(%attributes);

 
   if (!@result) {
     $::lxdebug->message(LXDebug::WARN(), "Error: " . $db->error);
     return $self->js->error($::locale->text('Saving failed. Error message from the database: #1'), $db->error)->render($self);
   }
 
 
   if (!@result) {
     $::lxdebug->message(LXDebug::WARN(), "Error: " . $db->error);
     return $self->js->error($::locale->text('Saving failed. Error message from the database: #1'), $db->error)->render($self);
   }
 

+  $self->version($result[0]);

   my $version_info_html = $self->render('requirement_spec/_version',     { output => 0 }, requirement_spec => $self->requirement_spec);
   my $version_list_html = $self->render('requirement_spec_version/list', { output => 0 });
 
   my $version_info_html = $self->render('requirement_spec/_version',     { output => 0 }, requirement_spec => $self->requirement_spec);
   my $version_list_html = $self->render('requirement_spec_version/list', { output => 0 });
 


@@ -95,7 +96,7 @@ sub action_create {
 
 sub check_auth {
   my ($self, %params) = @_;
 
 sub check_auth {
   my ($self, %params) = @_;

-  $::auth->assert('sales_quotation_edit');
+  $::auth->assert('requirement_spec_edit');

 }
 
 #
 }
 
 #


@@ -117,13 +118,6 @@ sub init_js {
   $self->js(SL::ClientJS->new);
 }
 
   $self->js(SL::ClientJS->new);
 }
 

-sub init_versioned_copies {
-  my ($self) = @_;
-  $self->versioned_copies([
-    sort { $b->mtime <=> $a->mtime } @{ $self->requirement_spec->versioned_copies }
-  ]);
-}
-

 sub has_item_changed {
   my ($previous, $current) = @_;
   croak "Missing previous/current" if !$previous || !$current;
 sub has_item_changed {
   my ($previous, $current) = @_;
   croak "Missing previous/current" if !$previous || !$current;