X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/mfinanz.git/blobdiff_plain/108753a78b203dbe0ccbe6438cc16c8df33c04d3..bca91008eddc6a1734a75fcd555f10d1c8ac65f6:/SL/Form.pm diff --git a/SL/Form.pm b/SL/Form.pm index e815fec12..bf126cb55 100644 --- a/SL/Form.pm +++ b/SL/Form.pm @@ -115,11 +115,6 @@ sub new { return $self; } -sub read_cgi_input { - my ($self) = @_; - SL::Request::read_cgi_input($self); -} - sub _flatten_variables_rec { $main::lxdebug->enter_sub(2); @@ -397,7 +392,7 @@ sub create_http_response { $cgi_params{'-charset'} = $params{charset} if ($params{charset}); $cgi_params{'-cookie'} = $session_cookie if ($session_cookie); - map { $cgi_params{'-' . $_} = $params{$_} if exists $params{$_} } qw(content_disposition content_length); + map { $cgi_params{'-' . $_} = $params{$_} if exists $params{$_} } qw(content_disposition content_length status); my $output = $cgi->header(%cgi_params); @@ -1037,9 +1032,10 @@ sub parse_template { copy(join('/', $self->{cwd}, $userspath, $self->{tmpfile}), $out =~ m|^/| ? $out : join('/', $self->{cwd}, $out)) if $template->uses_temp_file; if ($copy_to_webdav) { - my $error = Common::copy_file_to_webdav_folder($self); - chdir("$self->{cwd}"); - $self->error($error) if $error; + if (my $error = Common::copy_file_to_webdav_folder($self)) { + chdir("$self->{cwd}"); + $self->error($error); + } } if (!$self->{preview} && $self->doc_storage_enabled) @@ -1056,9 +1052,10 @@ sub parse_template { } if ($copy_to_webdav) { - my $error = Common::copy_file_to_webdav_folder($self); - chdir("$self->{cwd}"); - $self->error($error) if $error; + if (my $error = Common::copy_file_to_webdav_folder($self)) { + chdir("$self->{cwd}"); + $self->error($error); + } } if ( !$self->{preview} && $ext_for_format eq 'pdf' && $self->doc_storage_enabled) { @@ -1870,7 +1867,7 @@ sub add_shipto { my @values; foreach my $item (qw(name department_1 department_2 street zipcode city country gln - contact cp_gender phone fax email)) { + contact phone fax email)) { if ($self->{"shipto$item"}) { $shipto = 1 if ($self->{$item} ne $self->{"shipto$item"}); } @@ -1879,6 +1876,12 @@ sub add_shipto { return if !$shipto; + # shiptocp_gender only makes sense, if any other shipto attribute is set. + # Because shiptocp_gender is set to 'm' by default in forms + # it must not be considered above to decide if shiptos has to be added or + # updated, but must be inserted or updated as well in case. + push(@values, $self->{shiptocp_gender}); + my $shipto_id = $self->{shipto_id}; if ($self->{shipto_id}) {