X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/mfinanz.git/blobdiff_plain/44fb4fe8d98ced50689764dab64b4633016c9fe0..762f348476e09df5619fa11d7ec070209cb843f4:/SL/Controller/Order.pm?ds=inline diff --git a/SL/Controller/Order.pm b/SL/Controller/Order.pm index a32581d65..8023aa2b9 100644 --- a/SL/Controller/Order.pm +++ b/SL/Controller/Order.pm @@ -783,6 +783,8 @@ sub _make_item { $item->assign_attributes(%$attr); $item->longdescription($item->part->notes) if $is_new && !defined $attr->{longdescription}; + # item fields that currently can't be set in in row but are needed: + $item->lastcost($item->part->lastcost); return $item; } @@ -1204,10 +1206,6 @@ java script functions =item * -C is not displayed until an order is saved - -=item * - Customer discount is not displayed as a valid discount in price source popup (this might be a bug in price sources) @@ -1236,9 +1234,22 @@ Table header is not sticky in the scrolling area. Sorting does not include C, neither does reordering. +This behavior was implemented intentionally. But we can discuss, which behavior +should be implemented. + =item * -C does not use the currently inserted string for filtering. +C does not use the currently inserted string for +filtering. + +=item * Performance + +Rendering a 50 items order takes twice as long as the old code. + +90% of that is rendering the (hidden) second rows, and 50% of those again are +checks for is_valid and C on the cvar input template. + +Suggestion: fetch second rows when asked for. =back