X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/mfinanz.git/blobdiff_plain/91b948e473f5b731a6886e4b2cd4c526a42ace4e..368f144b970a4b307a50d82bb398e704d65eec43:/SL/Controller/ClientConfig.pm

diff --git a/SL/Controller/ClientConfig.pm b/SL/Controller/ClientConfig.pm
index e16b090b7..3585e6a8e 100644
--- a/SL/Controller/ClientConfig.pm
+++ b/SL/Controller/ClientConfig.pm
@@ -5,116 +5,85 @@ use parent qw(SL::Controller::Base);
 
 use SL::DB::Default;
 use SL::Helper::Flash;
+use SL::Locale::String qw(t8);
 
 __PACKAGE__->run_before('check_auth');
 
+use Rose::Object::MakeMethods::Generic (
+  'scalar --get_set_init' => [ qw(defaults all_warehouses posting_options payment_options accounting_options inventory_options profit_options) ],
+);
 
 sub action_edit {
   my ($self, %params) = @_;
-
-  $self->{posting_options} = [ { title => $::locale->text("never"), value => 0 },
-                               { title => $::locale->text("every time"), value => 1 },
-                               { title => $::locale->text("on the same day"), value => 2 }, ];
-  $self->{payment_options} = [ { title => $::locale->text("never"), value => 0 },
-                               { title => $::locale->text("every time"), value => 1 },
-                               { title => $::locale->text("on the same day"), value => 2 }, ];
-  $self->{accounting_options} = [ { title => $::locale->text("Accrual"), value => "accrual" },
-                                  { title => $::locale->text("cash"), value => "cash" }, ];
-  $self->{inventory_options} = [ { title => $::locale->text("perpetual"), value => "perpetual" },
-                                 { title => $::locale->text("periodic"), value => "periodic" }, ];
-  $self->{profit_options} = [ { title => $::locale->text("balance"), value => "balance" },
-                              { title => $::locale->text("income"), value => "income" }, ];
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(is_changeable ir_changeable ar_changeable ap_changeable gl_changeable);
-
-  $self->{payments_changeable} = SL::DB::Default->get->payments_changeable;
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(is_show_mark_as_paid ir_show_mark_as_paid ar_show_mark_as_paid ap_show_mark_as_paid);
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(accounting_method inventory_system profit_determination);
-
-  $self->{show_bestbefore}     = SL::DB::Default->get->show_bestbefore;
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(datev_check_on_sales_invoice datev_check_on_purchase_invoice datev_check_on_ar_transaction datev_check_on_ap_transaction datev_check_on_gl_transaction);
-  # datev check: not implemented yet:
-  #check_on_cash_and_receipt = 0
-  #check_on_dunning = 0
-  #check_on_sepa_import = 0
-
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(sales_order_show_delete purchase_order_show_delete sales_delivery_order_show_delete purchase_delivery_order_show_delete);
-
-  # All warehouse / transfer default values
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(transfer_default transfer_default_use_master_default_bin transfer_default_ignore_onhand
-                                                    warehouse_id_ignore_onhand bin_id_ignore_onhand warehouse_id bin_id);
-
-  # for the default warehouse and bin we get the list and
-  # set a empty value with warehouse_id and bin_id = 0
-  map { $self->{$_} = SL::DB::Default->get->$_ } qw(warehouse_id bin_id);
-  $::form->get_lists('warehouses' => { 'key'    => 'WAREHOUSES',
-                                       'bins'   => 'BINS', });
-  $self->{WAREHOUSES} = $::form->{WAREHOUSES};
-  # leerer lagerplatz mit id 0
-  my $no_default_bin_entry = { 'id' => '0', description => '--', 'BINS' => [ { id => '0', description => ''} ] };
-  push @ { $self->{WAREHOUSES} }, $no_default_bin_entry;
-
-  # set defaults to empty
-  if (my $max = scalar @{ $self->{WAREHOUSES} }) {
-    $self->{warehouse_id} ||= $self->{WAREHOUSES}->[$max -1]->{id};
-    $self->{bin_id}       ||= $self->{WAREHOUSES}->[$max -1]->{BINS}->[0]->{id};
-    $self->{warehouse_id_ignore_onhand} ||= $self->{WAREHOUSES}->[$max -1]->{id};
-    $self->{bin_id_ignore_onhand}       ||= $self->{WAREHOUSES}->[$max -1]->{BINS}->[0]->{id};
-  }
-
-  $self->{show_weight} = SL::DB::Default->get->show_weight;
-
-  $self->render('client_config/form', title => $::locale->text('Client Configuration'));
+  $self->edit_form;
 }
 
-
 sub action_save {
   my ($self, %params) = @_;
 
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(is_changeable ir_changeable ar_changeable ap_changeable gl_changeable);
+  my $defaults = delete($::form->{defaults}) || {};
 
-  SL::DB::Default->get->update_attributes('payments_changeable' => $::form->{payments_changeable});
+  # undef several fields if an empty value has been selected.
+  foreach (qw(warehouse_id bin_id warehouse_id_ignore_onhand bin_id_ignore_onhand)) {
+    undef $defaults->{$_} if !$defaults->{$_};
+  }
 
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(is_show_mark_as_paid ir_show_mark_as_paid ar_show_mark_as_paid ap_show_mark_as_paid);
+  $self->defaults->update_attributes(%{ $defaults });
 
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(accounting_method inventory_system profit_determination);
+  flash_later('info', t8('Client Configuration saved!'));
 
-  SL::DB::Default->get->update_attributes('show_bestbefore'     => $::form->{show_bestbefore});
+  $self->redirect_to(action => 'edit');
+}
 
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(datev_check_on_sales_invoice datev_check_on_purchase_invoice datev_check_on_ar_transaction datev_check_on_ap_transaction datev_check_on_gl_transaction);
+#
+# initializers
+#
 
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(sales_order_show_delete purchase_order_show_delete sales_delivery_order_show_delete purchase_delivery_order_show_delete);
+sub init_defaults       { SL::DB::Default->get }
+sub init_all_warehouses { SL::DB::Manager::Warehouse->get_all_sorted }
 
-  # undef warehouse_id if the empty value is selected
-  if ( ($::form->{warehouse_id} == 0) && ($::form->{bin_id} == 0) ) {
-    undef $::form->{warehouse_id};
-    undef $::form->{bin_id};
-  }
-  # undef warehouse_id_ignore_onhand if the empty value is selected
-  if ( ($::form->{warehouse_id_ignore_onhand} == 0) && ($::form->{bin_id_ignore_onhand} == 0) ) {
-    undef $::form->{warehouse_id_ignore_onhand};
-    undef $::form->{bin_id_ignore_onhand};
-  }
-
-  # All warehouse / transfer default values
-  map { SL::DB::Default->get->update_attributes($_ => $::form->{$_}); } qw(transfer_default transfer_default_use_master_default_bin transfer_default_ignore_onhand
-                                                                            warehouse_id_ignore_onhand bin_id_ignore_onhand warehouse_id bin_id);
+sub init_posting_options {
+  [ { title => t8("never"),           value => 0           },
+    { title => t8("every time"),      value => 1           },
+    { title => t8("on the same day"), value => 2           }, ]
+}
 
-  SL::DB::Default->get->update_attributes('show_weight'     => $::form->{show_weight});
+sub init_payment_options {
+  [ { title => t8("never"),           value => 0           },
+    { title => t8("every time"),      value => 1           },
+    { title => t8("on the same day"), value => 2           }, ]
+}
 
-  flash_later('info', $::locale->text('Client Configuration saved!'));
+sub init_accounting_options {
+  [ { title => t8("Accrual"),         value => "accrual"   },
+    { title => t8("cash"),            value => "cash"      }, ]
+}
 
-  $self->redirect_to(action => 'edit');
+sub init_inventory_options {
+  [ { title => t8("perpetual"),       value => "perpetual" },
+    { title => t8("periodic"),        value => "periodic"  }, ]
 }
 
+sub init_profit_options {
+  [ { title => t8("balance"),         value => "balance"   },
+    { title => t8("income"),          value => "income"    }, ]
+}
 
-#################### private stuff ##########################
+#
+# filters
+#
 
 sub check_auth {
   $::auth->assert('admin');
 }
 
+#
+# helpers
+#
+
+sub edit_form {
+  my ($self) = @_;
+  $self->render('client_config/form', title => t8('Client Configuration'));
+}
+
 1;