X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/mfinanz.git/blobdiff_plain/aa014f1111f1244dcb9b8cb232240a00ff129e99..a6372bfafa12301c00d77f7b806810177ced0e15:/SL/Controller/CsvImport/Order.pm diff --git a/SL/Controller/CsvImport/Order.pm b/SL/Controller/CsvImport/Order.pm index 1702192f1..e50b197c8 100644 --- a/SL/Controller/CsvImport/Order.pm +++ b/SL/Controller/CsvImport/Order.pm @@ -24,7 +24,7 @@ use parent qw(SL::Controller::CsvImport::BaseMulti); use Rose::Object::MakeMethods::Generic ( - 'scalar --get_set_init' => [ qw(settings languages_by parts_by contacts_by departments_by projects_by ct_shiptos_by taxzones_by price_factors_by pricegroups_by) ], + 'scalar --get_set_init' => [ qw(settings languages_by parts_by contacts_by departments_by projects_by ct_shiptos_by taxzones_by price_factors_by pricegroups_by currencies_by) ], ); @@ -37,7 +37,7 @@ sub init_class { sub init_settings { my ($self) = @_; - return { map { ( $_ => $self->controller->profile->get($_) ) } qw(order_column item_column) }; + return { map { ( $_ => $self->controller->profile->get($_) ) } qw(order_column item_column max_amount_diff) }; } @@ -46,14 +46,25 @@ sub init_profile { my $profile = $self->SUPER::init_profile; + # SUPER::init_profile sets row_ident to the translated class name + # overwrite it with the user specified settings + foreach my $p (@{ $profile }) { + if ($p->{row_ident} eq $::locale->text('Order')) { + $p->{row_ident} = $self->settings->{'order_column'}; + } + if ($p->{row_ident} eq $::locale->text('OrderItem')) { + $p->{row_ident} = $self->settings->{'item_column'}; + } + } + foreach my $p (@{ $profile }) { my $prof = $p->{profile}; - if ($p->{row_ident} eq 'Order') { + if ($p->{row_ident} eq $self->settings->{'order_column'}) { # no need to handle delete @{$prof}{qw(delivery_customer_id delivery_vendor_id proforma quotation amount netamount)}; - # handable, but not handled by now } - if ($p->{row_ident} eq 'OrderItem') { + if ($p->{row_ident} eq $self->settings->{'item_column'}) { + # no need to handle delete @{$prof}{qw(trans_id)}; } } @@ -67,8 +78,26 @@ sub setup_displayable_columns { $self->SUPER::setup_displayable_columns; - $self->add_displayable_columns('Order', - { name => 'datatype', description => $::locale->text('Zeilenkennung') }, + $self->add_displayable_columns($self->settings->{'order_column'}, + { name => 'datatype', description => $self->settings->{'order_column'} }, + { name => 'closed', description => $::locale->text('Closed') }, + { name => 'currency', description => $::locale->text('Currency') }, + { name => 'currency_id', description => $::locale->text('Currency (database ID)') }, + { name => 'cusordnumber', description => $::locale->text('Customer Order Number') }, + { name => 'delivered', description => $::locale->text('Delivered') }, + { name => 'employee_id', description => $::locale->text('Employee (database ID)') }, + { name => 'intnotes', description => $::locale->text('Internal Notes') }, + { name => 'marge_percent', description => $::locale->text('Margepercent') }, + { name => 'marge_total', description => $::locale->text('Margetotal') }, + { name => 'notes', description => $::locale->text('Notes') }, + { name => 'ordnumber', description => $::locale->text('Order Number') }, + { name => 'quonumber', description => $::locale->text('Quotation Number') }, + { name => 'reqdate', description => $::locale->text('Reqdate') }, + { name => 'salesman_id', description => $::locale->text('Salesman (database ID)') }, + { name => 'shippingpoint', description => $::locale->text('Shipping Point') }, + { name => 'shipvia', description => $::locale->text('Ship via') }, + { name => 'transaction_description', description => $::locale->text('Transaction description') }, + { name => 'transdate', description => $::locale->text('Order Date') }, { name => 'verify_amount', description => $::locale->text('Amount (for verification)') }, { name => 'verify_netamount', description => $::locale->text('Net amount (for verification)') }, { name => 'taxincluded', description => $::locale->text('Tax Included') }, @@ -94,7 +123,16 @@ sub setup_displayable_columns { { name => 'shipto_id', description => $::locale->text('Ship to (database ID)') }, ); - $self->add_displayable_columns('OrderItem', + $self->add_displayable_columns($self->settings->{'item_column'}, + { name => 'datatype', description => $self->settings->{'item_column'} }, + { name => 'cusordnumber', description => $::locale->text('Customer Order Number') }, + { name => 'description', description => $::locale->text('Description') }, + { name => 'discount', description => $::locale->text('Discount') }, + { name => 'lastcost', description => $::locale->text('Lastcost') }, + { name => 'longdescription', description => $::locale->text('Long Description') }, + { name => 'marge_percent', description => $::locale->text('Margepercent') }, + { name => 'marge_total', description => $::locale->text('Margetotal') }, + { name => 'ordnumber', description => $::locale->text('Order Number') }, { name => 'parts_id', description => $::locale->text('Part (database ID)') }, { name => 'partnumber', description => $::locale->text('Part Number') }, { name => 'project_id', description => $::locale->text('Project (database ID)') }, @@ -104,6 +142,12 @@ sub setup_displayable_columns { { name => 'price_factor', description => $::locale->text('Price factor (name)') }, { name => 'pricegroup_id', description => $::locale->text('Price group (database ID)') }, { name => 'pricegroup', description => $::locale->text('Price group (name)') }, + { name => 'qty', description => $::locale->text('Quantity') }, + { name => 'reqdate', description => $::locale->text('Reqdate') }, + { name => 'sellprice', description => $::locale->text('Sellprice') }, + { name => 'serialnumber', description => $::locale->text('Serial No.') }, + { name => 'subtotal', description => $::locale->text('Subtotal') }, + { name => 'unit', description => $::locale->text('Unit') }, ); } @@ -182,6 +226,12 @@ sub init_pricegroups_by { return { map { my $col = $_; ( $col => { map { ( $_->$col => $_ ) } @{ $all_pricegroups } } ) } qw(id pricegroup) }; } +sub init_currencies_by { + my ($self) = @_; + + return { map { my $col = $_; ( $col => { map { ( $_->$col => $_ ) } @{ $self->all_currencies } } ) } qw(id name) }; +} + sub check_objects { my ($self) = @_; @@ -212,10 +262,11 @@ sub check_objects { $self->check_project($entry, global => 1); $self->check_ct_shipto($entry); $self->check_taxzone($entry); + $self->check_currency($entry); if ($vc_obj) { # copy from customer if not given - foreach (qw(payment_id language_id taxzone_id)) { + foreach (qw(payment_id language_id taxzone_id currency_id)) { $entry->{object}->$_($vc_obj->$_) unless $entry->{object}->$_; } } @@ -242,7 +293,7 @@ sub check_objects { { header => $::locale->text('Customer/Vendor'), method => 'vc_name' }); # Todo: access via ->[0] ok? Better: search first order column and use this $self->add_columns($self->settings->{'order_column'}, - map { "${_}_id" } grep { exists $self->controller->data->[0]->{raw_data}->{$_} } qw(payment language department globalproject taxzone cp)); + map { "${_}_id" } grep { exists $self->controller->data->[0]->{raw_data}->{$_} } qw(payment language department globalproject taxzone cp currency)); $self->add_columns($self->settings->{'order_column'}, 'globalproject_id') if exists $self->controller->data->[0]->{raw_data}->{globalprojectnumber}; $self->add_columns($self->settings->{'order_column'}, 'cp_id') if exists $self->controller->data->[0]->{raw_data}->{contact}; @@ -265,7 +316,6 @@ sub check_objects { $self->check_project($entry, global => 0); $self->check_price_factor($entry); $self->check_pricegroup($entry); - } } @@ -321,7 +371,6 @@ sub check_objects { # If amounts are given, show calculated amounts as info and given amounts (verify_xxx). # And throw an error if the differences are too big. - my $max_diff = 0.02; my @to_verify = ( { column => 'amount', raw_column => 'verify_amount', info_header => 'Calc. Amount', @@ -349,7 +398,7 @@ sub check_objects { if ($entry->{raw_data}->{datatype} eq $self->settings->{'order_column'}) { next if !$entry->{raw_data}->{ $tv->{raw_column} }; my $parsed_value = $::form->parse_amount(\%::myconfig, $entry->{raw_data}->{ $tv->{raw_column} }); - if (abs($entry->{object}->${ \$tv->{column} } - $parsed_value) > $max_diff) { + if (abs($entry->{object}->${ \$tv->{column} } - $parsed_value) > $self->settings->{'max_amount_diff'}) { push @{ $entry->{errors} }, $::locale->text($tv->{err_msg}); } } @@ -357,7 +406,7 @@ sub check_objects { } # If order has errors set error for orderitems as well - my $order_entry; + $order_entry = undef; foreach my $entry (@{ $self->controller->data }) { # Search first order if ($entry->{raw_data}->{datatype} eq $self->settings->{'order_column'}) { @@ -574,7 +623,6 @@ sub check_taxzone { return 1; } - sub check_price_factor { my ($self, $entry) = @_; @@ -625,6 +673,31 @@ sub check_pricegroup { return 1; } +sub check_currency { + my ($self, $entry) = @_; + + my $object = $entry->{object}; + + # Check whether or not currency ID is valid. + if ($object->currency_id && !$self->currencies_by->{id}->{ $object->currency_id }) { + push @{ $entry->{errors} }, $::locale->text('Error: Invalid currency'); + return 0; + } + + # Map name to ID if given. + if (!$object->currency_id && $entry->{raw_data}->{currency}) { + my $currency = $self->currencies_by->{name}->{ $entry->{raw_data}->{currency} }; + if (!$currency) { + push @{ $entry->{errors} }, $::locale->text('Error: Invalid currency'); + return 0; + } + + $object->currency_id($currency->id); + } + + return 1; +} + sub save_objects { my ($self, %params) = @_;