CustomerVendor-Presenter: croaken, wenn Parameter fehlen oder falsch sind

diff --git a/SL/Presenter/CustomerVendor.pm b/SL/Presenter/CustomerVendor.pm
index 2bf5ebc3c368a72eb5aff36eb15bb17e4385b705..4a370297040ce97f26d6bff3531eba7f51236166 100644 (file)
--- a/SL/Presenter/CustomerVendor.pm
+++ b/SL/Presenter/CustomerVendor.pm
@@ -39,7 +39,14 @@ sub _customer_vendor {
 sub customer_vendor_picker {
   my ($self, $name, $value, %params) = @_;
 
 sub customer_vendor_picker {
   my ($self, $name, $value, %params) = @_;
 

-  $value = SL::DB::Manager::Customer->find_by(id => $value) if $value && !ref $value;
+  croak 'Unknown "type" parameter' unless $params{type} =~ m{^(?:customer|vendor)$};
+  croak 'Unknown value class'      if     $value && (ref($value) !~ m{^SL::DB::(?:Customer|Vendor)$});
+
+  if ($value && !ref $value) {
+    my $class = $params{type} eq 'customer' ? 'SL::DB::Manager::Customer' : 'SL::DB::Manager::Vendor';
+    $value    = $class->find_by(id => $value);
+  }
+

   my $id = delete($params{id}) || $self->name_to_id($name);
   my $fat_set_item = delete $params{fat_set_item};
 
   my $id = delete($params{id}) || $self->name_to_id($name);
   my $fat_set_item = delete $params{fat_set_item};