CreatePeriodicInvoices-Job: for anstelle von map für reine Nebeneffekt-Schleifen

diff --git a/SL/BackgroundJob/CreatePeriodicInvoices.pm b/SL/BackgroundJob/CreatePeriodicInvoices.pm
index 47770255149474c15a4e975fa54c75e6a79c1eb7..1abe8c36b2e28c243843e2ae41ef4ac8776e899f 100644 (file)
--- a/SL/BackgroundJob/CreatePeriodicInvoices.pm
+++ b/SL/BackgroundJob/CreatePeriodicInvoices.pm
@@ -58,7 +58,7 @@ sub run {
     }
   }
 
     }
   }
 

-  map { _print_invoice(@{ $_ }) } @invoices_to_print;
+  _print_invoice(@{ $_ }) for @invoices_to_print;

 
   _send_email(\@new_invoices, [ map { $_->[0] } @invoices_to_print ]) if @new_invoices;
 
 
   _send_email(\@new_invoices, [ map { $_->[0] } @invoices_to_print ]) if @new_invoices;
 


@@ -154,10 +154,10 @@ sub _create_periodic_invoice {
                                 employee     => $order->employee, # new_from sets employee to import user
                                );
 
                                 employee     => $order->employee, # new_from sets employee to import user
                                );
 

-    map { _replace_vars($invoice, $time_period_vars, $_) } qw(notes intnotes transaction_description);
+    _replace_vars($invoice, $time_period_vars, $_) for qw(notes intnotes transaction_description);

 
     foreach my $item (@{ $invoice->items }) {
 
     foreach my $item (@{ $invoice->items }) {

-      map { _replace_vars($item, $time_period_vars, $_) } qw(description longdescription);
+      _replace_vars($item, $time_period_vars, $_) for qw(description longdescription);

     }
 
     $invoice->post(ar_id => $config->ar_chart_id) || die;
     }
 
     $invoice->post(ar_id => $config->ar_chart_id) || die;