Bugs, Doku Stub

diff --git a/SL/Controller/DeliveryPlan.pm b/SL/Controller/DeliveryPlan.pm
index 348b5534164b1d63dc17a45893c76db27df0bd05..da114d84a68f7e6a9cc4ba3d7a77d0ebaddd2185 100644 (file)
--- a/SL/Controller/DeliveryPlan.pm
+++ b/SL/Controller/DeliveryPlan.pm
@@ -198,19 +198,16 @@ sub init_models {
   my ($self) = @_;
 
   SL::Controller::Helper::GetModels->new(
   my ($self) = @_;
 
   SL::Controller::Helper::GetModels->new(

-    controller => $self,
-    model  => 'OrderItem',
-    filtered => {
-      launder_to => 'filter',
-    },
-    sorted => {
-      _default => {
-        by        => 'reqdate',
-        dir       => 1,
+    controller   => $self,
+    model        => 'OrderItem',
+    sorted       => {
+      _default     => {
+        by           => 'reqdate',
+        dir          => 1,

       },
       %sort_columns,
     },
       },
       %sort_columns,
     },

-    query => $delivery_plan_query,
+    query        => $delivery_plan_query,

     with_objects => [ 'order', 'order.customer', 'part' ],
   );
 }
     with_objects => [ 'order', 'order.customer', 'part' ],
   );
 }

diff --git a/SL/Controller/Helper/GetModels/Base.pm b/SL/Controller/Helper/GetModels/Base.pm
index 6a9a9cda779d01029e64f209cc19ad2d212beb92..9327c31f66faf93b07547d3da64e82798d28d35c 100644 (file)
--- a/SL/Controller/Helper/GetModels/Base.pm
+++ b/SL/Controller/Helper/GetModels/Base.pm
@@ -43,3 +43,42 @@ sub is_enabled {
 }
 
 1;
 }
 
 1;

+
+__END__
+
+=encoding utf-8
+
+=head1 NAME
+
+SL::Controller::Helper::GetModels::Base - base class for GetModels plugins
+
+=head1 SYNOPSIS
+
+  package SL::Controller::Helper::Getmodels::...;
+  use parent 'SL::Controller::Helper::Getmodels::Base'
+
+  sub read_params { ... }
+
+  sub finalize { ... }
+
+=head1 DESCRIPTION
+
+This is a base class for plugins of the GetModels framework for controllers. It
+provides some common ground.
+
+=head1 FUNCTIONS
+
+=over 4
+
+=back
+
+=head1 BUGS AND CAVEATS
+
+None yet :)
+
+=head1 AUTHOR
+
+Sven Schöling E<lt>s.schoeling@linet-services.deE<gt>
+
+=cut
+

diff --git a/SL/Controller/Helper/GetModels/Sorted.pm b/SL/Controller/Helper/GetModels/Sorted.pm
index dee86810f16b32700b1690b38b5ee65e6fcd1fe3..14e733d452c397a96c8098f8e8d98c867e73c106 100644 (file)
--- a/SL/Controller/Helper/GetModels/Sorted.pm
+++ b/SL/Controller/Helper/GetModels/Sorted.pm
@@ -146,7 +146,7 @@ In a controller:
   use SL::Controller::Helper::GetModels;
   use SL::Controller::Helper::Sorted;
 
   use SL::Controller::Helper::GetModels;
   use SL::Controller::Helper::Sorted;
 

-  __PACKAGE__->make_sorted(
+  __PACKAGE__->make_sorted(                                     # update this

     DEFAULT_BY   => 'run_at',
     DEFAULT_DIR  => 1,
     MODEL        => 'BackgroundJobHistory',
     DEFAULT_BY   => 'run_at',
     DEFAULT_DIR  => 1,
     MODEL        => 'BackgroundJobHistory',


@@ -170,7 +170,7 @@ In said template:
 
   <table>
    <tr>
 
   <table>
    <tr>

-    <th>[% L.sortable_table_header('package_name') %]</th>
+    <th>[% L.sortable_table_header('package_name') %]</th>         # models

     <th>[% L.sortable_table_header('run_at') %]</th>
     <th>[% L.sortable_table_header('error') %]</th>
    </tr>
     <th>[% L.sortable_table_header('run_at') %]</th>
     <th>[% L.sortable_table_header('error') %]</th>
    </tr>


@@ -190,7 +190,7 @@ This specialized helper module enables controllers to display a
 sortable list of database models with as few lines as possible.
 
 For this to work the controller has to provide the information which
 sortable list of database models with as few lines as possible.
 
 For this to work the controller has to provide the information which

-indexes are eligible for sorting etc. by a call to L<make_sorted> at
+indexes are eligible for sorting etc. by a call to L<make_sorted> at  #not compiletime

 compile time.
 
 The underlying functionality that enables the use of more than just
 compile time.
 
 The underlying functionality that enables the use of more than just


@@ -214,7 +214,7 @@ parameters that were used in the current view.
 
 =over 4
 
 
 =over 4
 

-=item C<make_sorted %sort_spec>
+=item C<make_sorted %sort_spec>                                         # meh complete rewrite

 
 This function must be called by a controller at compile time. It is
 uesd to set the various parameters required for this helper to do its
 
 This function must be called by a controller at compile time. It is
 uesd to set the various parameters required for this helper to do its

diff --git a/SL/Controller/Project.pm b/SL/Controller/Project.pm
index 720c93dabfbe629b47d20e74c6bc8d7e5b0b1352..23101dacfd5ba3a16bd0b300420d84807b2ed96e 100644 (file)
--- a/SL/Controller/Project.pm
+++ b/SL/Controller/Project.pm
@@ -207,7 +207,6 @@ sub prepare_report {
     controller_class      => 'Project',
     output_format         => 'HTML',
     top_info_text         => $::locale->text('Projects'),
     controller_class      => 'Project',
     output_format         => 'HTML',
     top_info_text         => $::locale->text('Projects'),

-    raw_bottom_info_text  => $self->render('project/report_bottom', { output => 0 }),

     title                 => $::locale->text('Projects'),
     allow_pdf_export      => 1,
     allow_csv_export      => 1,
     title                 => $::locale->text('Projects'),
     allow_pdf_export      => 1,
     allow_csv_export      => 1,


@@ -219,7 +218,6 @@ sub prepare_report {
   $self->models->disable_pagination if $report->{options}{output_format} =~ /^(pdf|csv)$/i;
   $self->models->set_report_generator_sort_options(report => $report, sortable_columns => \@sortable);
   $report->set_options(
   $self->models->disable_pagination if $report->{options}{output_format} =~ /^(pdf|csv)$/i;
   $self->models->set_report_generator_sort_options(report => $report, sortable_columns => \@sortable);
   $report->set_options(

-    top_info_text         => $::locale->text('Projects'),

     raw_bottom_info_text  => $self->render('project/report_bottom', { output => 0 }),
   );
 }
     raw_bottom_info_text  => $self->render('project/report_bottom', { output => 0 }),
   );
 }