From: Bernd Bleßmann <bernd@kivitendo-premium.de>
Date: Tue, 27 Oct 2015 14:07:19 +0000 (+0100)
Subject: Merge branch 'master' of github.com:kivitendo/kivitendo-erp
X-Git-Tag: release-3.4.1~618
X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/mfinanz.git/commitdiff_plain/7c6b944f86080cac2bc7723a46622ef4bda2e6f1?hp=2c14706b3db5025126c88a2d0340e8e663ac31e8

Merge branch 'master' of github.com:kivitendo/kivitendo-erp
---

diff --git a/SL/BackgroundJob/SelfTest/Transactions.pm b/SL/BackgroundJob/SelfTest/Transactions.pm
index f4f13d01a..6307ea99f 100644
--- a/SL/BackgroundJob/SelfTest/Transactions.pm
+++ b/SL/BackgroundJob/SelfTest/Transactions.pm
@@ -15,13 +15,14 @@ sub run {
 
   $self->_setup;
 
-  $self->tester->plan(tests => 17);
+  $self->tester->plan(tests => 18);
 
   $self->check_konten_mit_saldo_nicht_in_guv;
   $self->check_bilanzkonten_mit_pos_eur;
   $self->check_balanced_individual_transactions;
   $self->check_verwaiste_acc_trans_eintraege;
   $self->check_verwaiste_invoice_eintraege;
+  $self->check_ar_acc_trans_amount;
   $self->check_netamount_laut_invoice_ar;
   $self->check_invnumbers_unique;
   $self->check_summe_stornobuchungen;
@@ -428,6 +429,28 @@ sub check_every_account_with_taxkey {
   }
 }
 
+sub check_ar_acc_trans_amount {
+  my ($self) = @_;
+
+  my $query = qq|
+          select ar.invnumber, ar.netamount, ac.amount
+           from ar left join acc_trans ac on (ac.trans_id = ar.id) where ac.chart_link like 'AR_amount%' AND ac.amount <> ar.netamount|;
+
+  my $ar_amount_not_ac_amount = selectall_hashref_query($::form, $self->dbh, $query);
+
+  if ( scalar @{ $ar_amount_not_ac_amount } > 0 ) {
+    $self->tester->ok(0, "Folgende Ausgangsrechnungen haben einen falschen Netto-Wert im Nebenbuch:");
+
+    for my $ar_ac_amount_nok (@{ $ar_amount_not_ac_amount } ) {
+      $self->tester->diag("Rechnungsnummer: $ar_ac_amount_nok->{invnumber} Hauptbuch-Wert: $ar_ac_amount_nok->{amount}
+                            Nebenbuch-Wert: $ar_ac_amount_nok->{netamount}");
+    }
+  } else {
+    $self->tester->ok(1, "Hauptbuch-Nettowert und Nebenbuch-Nettowert stimmen überein.");
+  }
+
+}
+
 1;
 
 __END__
diff --git a/SL/Controller/DeliveryValueReport.pm b/SL/Controller/DeliveryValueReport.pm
index 64207cade..858472b2f 100644
--- a/SL/Controller/DeliveryValueReport.pm
+++ b/SL/Controller/DeliveryValueReport.pm
@@ -62,7 +62,6 @@ sub prepare_report {
   my ($self)      = @_;
 
   my $vc          = $self->vc;
-  my $mode        = 'delivery_value_report';
   my $report      = SL::ReportGenerator->new(\%::myconfig, $::form);
   my $csv_option  = $::form->{report_generator_output_format};
   $self->{report} = $report;
diff --git a/doc/changelog b/doc/changelog
index 2c4645dce..cb62a04a7 100644
--- a/doc/changelog
+++ b/doc/changelog
@@ -44,6 +44,9 @@ Kleinere neue Features und Detailverbesserungen:
 
   - Konkurrierende Schreibprozesse beim Speichern von Belegen verhindern.
 
+  - SelfTest um einen Test erweitert. Hauptbuch-Nettowert weicht vom Nebenbuch-Netto-Wert ab
+    (acc_trans.amount != ar.netamount).
+
 2015-08-20 - Release 3.3
 
 Größere neue Features:
diff --git a/sql/Pg-upgrade2-auth/details_and_report_of_parts.pl b/sql/Pg-upgrade2-auth/details_and_report_of_parts.pl
index 762d98f99..90fc16acd 100644
--- a/sql/Pg-upgrade2-auth/details_and_report_of_parts.pl
+++ b/sql/Pg-upgrade2-auth/details_and_report_of_parts.pl
@@ -1,6 +1,6 @@
 # @tag: details_and_report_of_parts
 # @description: Setzt das Recht zur Anzeige von Details und Berichten von Waren, Dienstleistungen und Erzeugnissen
-# @depends: release_3_0_0
+# @depends: release_3_2_0 add_master_rights
 package SL::DBUpgrade2::details_and_report_of_parts;
 
 use strict;
diff --git a/sql/Pg-upgrade2-auth/productivity_rights.pl b/sql/Pg-upgrade2-auth/productivity_rights.pl
index 4c97c265b..7f287119f 100644
--- a/sql/Pg-upgrade2-auth/productivity_rights.pl
+++ b/sql/Pg-upgrade2-auth/productivity_rights.pl
@@ -1,6 +1,6 @@
 # @tag: productivity_rights
 # @description: Setzt das Recht die Produktivität einzusehen und das Recht den Link zum Admin-Menü anzuzeigen wieder wie vorher
-# @depends: release_3_0_0
+# @depends: release_3_2_0 add_master_rights
 package SL::DBUpgrade2::productivity_rights;
 
 use strict;
diff --git a/sql/Pg-upgrade2-auth/release_3_2_0.sql b/sql/Pg-upgrade2-auth/release_3_2_0.sql
index 9e9c50ea8..852ec011d 100644
--- a/sql/Pg-upgrade2-auth/release_3_2_0.sql
+++ b/sql/Pg-upgrade2-auth/release_3_2_0.sql
@@ -1,5 +1,5 @@
 -- @tag: release_3_2_0
 -- @description: Abhängigkeitsscript für Release 3.2.0, bzw. vergessene 3.1.0
--- @depends: release_3_0_0 clients_webdav foreign_key_constraints_on_delete rights_for_showing_ar_and_ap_transactions productivity_rights clients details_and_report_of_parts
+-- @depends: release_3_0_0 clients_webdav foreign_key_constraints_on_delete  clients
 -- @charset: utf-8
 
diff --git a/sql/Pg-upgrade2-auth/release_3_3_0.sql b/sql/Pg-upgrade2-auth/release_3_3_0.sql
index 37484a2b6..efcfa1752 100644
--- a/sql/Pg-upgrade2-auth/release_3_3_0.sql
+++ b/sql/Pg-upgrade2-auth/release_3_3_0.sql
@@ -1,4 +1,4 @@
 -- @tag: release_3_3_0
--- @description: Abhängigkeitsscript für Release 3.2.0, bzw. vergessene 3.1.0
--- @depends: release_3_2_0 sales_letter_rights delivery_plan_rights requirement_spec_rights delivery_process_value bank_transaction_rights
+-- @description: Abhängigkeitsscript für Release 3.3.0
+-- @depends: release_3_2_0 sales_letter_rights delivery_plan_rights requirement_spec_rights delivery_process_value bank_transaction_rights details_and_report_of_parts productivity_rights rights_for_showing_ar_and_ap_transactions
 -- @charset: utf-8
diff --git a/sql/Pg-upgrade2-auth/rights_for_showing_ar_and_ap_transactions.pl b/sql/Pg-upgrade2-auth/rights_for_showing_ar_and_ap_transactions.pl
index 9eaab726b..523975ecf 100644
--- a/sql/Pg-upgrade2-auth/rights_for_showing_ar_and_ap_transactions.pl
+++ b/sql/Pg-upgrade2-auth/rights_for_showing_ar_and_ap_transactions.pl
@@ -1,6 +1,6 @@
 # @tag: rights_for_showing_ar_and_ap_transactions
 # @description: Setzt das Recht zur Anzeige von Debitoren- und Kreditorenbuchungen im Rechnungsbericht
-# @depends: release_3_0_0
+# @depends: release_3_2_0 add_master_rights
 package SL::DBUpgrade2::rights_for_showing_ar_and_ap_transactions;
 
 use strict;
diff --git a/sql/Pg-upgrade2-auth/sales_letter_rights.pl b/sql/Pg-upgrade2-auth/sales_letter_rights.pl
index 22c97875c..f018317da 100644
--- a/sql/Pg-upgrade2-auth/sales_letter_rights.pl
+++ b/sql/Pg-upgrade2-auth/sales_letter_rights.pl
@@ -1,6 +1,6 @@
 # @tag: sales_letter_rights
-# @description: Setzt das neue Recht den Lieferplan anzuzeigen
-# @depends: release_3_2_0
+# @description: Setzt das neue Recht die Brieffunktion anzuzeigen
+# @depends: release_3_2_0 add_master_rights
 package SL::DBUpgrade2::sales_letter_rights;
 
 use strict;
diff --git a/templates/webpages/am/edit_templates.html b/templates/webpages/am/edit_templates.html
index 86bf82899..ff6ece22b 100644
--- a/templates/webpages/am/edit_templates.html
+++ b/templates/webpages/am/edit_templates.html
@@ -4,7 +4,7 @@
  <h1>[% title %]</h1>
 
   [% IF type == 'templates' %]
-   <p style="text-align: right;">[<a href="doc/html/ch03s02.html" target="_blank" title="[% 'Open in new window' | $T8 %]">[% 'Help Template Variables' | $T8 %]</a>]</p>
+   <p style="text-align: right;">[<a href="doc/html/ch03s03.html" target="_blank" title="[% 'Open in new window' | $T8 %]">[% 'Help Template Variables' | $T8 %]</a>]</p>
   [% END %]
 
  <form method="post" name="Form" action="amtemplates.pl">