From c750d149b1ae3f58568121c7c3257d0118bc34ae Mon Sep 17 00:00:00 2001
From: Niclas Zimmermann <niclas@kivitendo-premium.de>
Date: Fri, 3 May 2013 17:34:28 +0200
Subject: [PATCH] Selftest verbesserung
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Zähler noch hochgesetzt und von betroffenen Konten werden jetzt auch
Kontonummer/Kontobeschreibung angezeigt.
---
 SL/BackgroundJob/SelfTest/Transactions.pm | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/SL/BackgroundJob/SelfTest/Transactions.pm b/SL/BackgroundJob/SelfTest/Transactions.pm
index e6c1bf3df..9b5daed21 100644
--- a/SL/BackgroundJob/SelfTest/Transactions.pm
+++ b/SL/BackgroundJob/SelfTest/Transactions.pm
@@ -15,7 +15,7 @@ sub run {
 
   $self->_setup;
 
-  $self->tester->plan(tests => 15);
+  $self->tester->plan(tests => 16);
 
   $self->check_konten_mit_saldo_nicht_in_guv;
   $self->check_bilanzkonten_mit_pos_eur;
@@ -396,11 +396,15 @@ sub calc_saldenvortraege {
 sub check_every_account_with_taxkey {
   my ($self) = @_;
 
-  my $query = qq|SELECT 1 FROM chart WHERE id NOT IN (select chart_id from taxkeys) LIMIT 1|;
-  my ($account_without_chart) = selectfirst_array_query($::form, $self->dbh, $query);
+  my $query = qq|SELECT accno, description FROM chart WHERE id NOT IN (select chart_id from taxkeys)|;
+  my $accounts_without_tk = selectall_hashref_query($::form, $self->dbh, $query);
 
-  if ($account_without_chart){
-    $self->tester->ok(0, "Es sollte keine Konten ohne Steuerschlüssel geben!");
+  if ( scalar @{ $accounts_without_tk } > 0 ){
+    $self->tester->ok(0, "Folgende Konten haben keinen gültigen Steuerschlüssel:");
+
+    for my $account_without_tk (@{ $accounts_without_tk } ) {
+      $self->tester->diag("Kontonummer: $account_without_tk->{accno} Beschreibung: $account_without_tk->{description}");
+    }
   } else {
     $self->tester->ok(1, "Jedes Konto hat einen gültigen Steuerschlüssel!");
   }
-- 
2.39.5