X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/timetracker.git/blobdiff_plain/0bf91be4d6ee52adaf09a74d729c7a34cf012de7..b134135b685422ddcdc2d6856972c60ea15f661f:/time.php diff --git a/time.php b/time.php index da816362..6d62fb69 100644 --- a/time.php +++ b/time.php @@ -124,12 +124,11 @@ if ($user->can('manage_subgroups')) { } // SUBGROUP_DEBUG if ($user->can('track_time')) { - // Determine max rank. - $max_rank = $on_behalf_group_id == $user->group_id ? $user->rank-1 : 512; // TODO: stop using magic numbers. + $rank = $user->getMaxRankForGroup($on_behalf_group_id); if ($user->can('track_own_time')) - $options = array('group_id'=>$on_behalf_group_id,'status'=>ACTIVE,'max_rank'=>$max_rank,'include_self'=>true,'self_first'=>true); + $options = array('group_id'=>$on_behalf_group_id,'status'=>ACTIVE,'max_rank'=>$rank,'include_self'=>true,'self_first'=>true); else - $options = array('group_id'=>$on_behalf_group_id,'status'=>ACTIVE,'max_rank'=>$max_rank); + $options = array('group_id'=>$on_behalf_group_id,'status'=>ACTIVE,'max_rank'=>$rank); $user_list = $user->getUsers($options); if (count($user_list) >= 1) { $form->addInput(array('type'=>'combobox',