X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/timetracker.git/blobdiff_plain/e5719c4a72d1011a40d99b7ddfe7a84304bc0a7f..4bfd0a6f4a7a79c4bfeaeab17b9b898b10a3d6d2:/WEB-INF/lib/form/FormElement.class.php

diff --git a/WEB-INF/lib/form/FormElement.class.php b/WEB-INF/lib/form/FormElement.class.php
index e7ea9ccb..f2d0c920 100644
--- a/WEB-INF/lib/form/FormElement.class.php
+++ b/WEB-INF/lib/form/FormElement.class.php
@@ -26,19 +26,19 @@
 // | https://www.anuko.com/time_tracker/credits.htm
 // +----------------------------------------------------------------------+
 
+// FromElement is the base class for controls on forms.
 class FormElement {
-	var $mId			= "";
-	var $mName;
-	var $mFormName		= "";
-	var $mValue			= "";
-	var $mSize			= "";
-	var $mMaxLength		= "";
-	var $mTabindex		= "";
-	var $mAccesskey     = "";
-	var $mOnSelect		= "";
-	var $mOnChange		= "";
-	var $mOnClick		= "";
-	var $mOnKeyPress	= "";
+  var $id = '';         // Control id.
+  var $name;            // Control name.
+  var $form_name = '';  // Form name the control is in.
+  var $value = '';      // Value of the control.
+  var $size = '';       // Control size.
+  var $max_length = ''; // Max lenght of text in control.
+  var $on_change = '';  // What happens when value of control changes.
+  var $on_click = '';   // What happens when the control is clicked.
+
+  // TODO: refactoring ongoing down from here.
+	var $mOnKeyPress	= ""; // This is only used in TextArea, consider moving out of the base class.
 	var $mOnFocus		= "";
 	var $mLabel         = "";
 	var $mStyle         = "";
@@ -52,35 +52,29 @@ class FormElement {
 
 	function getClass()	{ return $this->cClassName; }
 	
-	function setName($name)	{ $this->mName = $name;	}
-	function getName()	{ return $this->mName; }
+	function setName($name)	{ $this->name = $name; }
+	function getName()	{ return $this->name; }
 	
-	function setFormName($name)	{ $this->mFormName = $name;	}
-	function getFormName()	{ return $this->mFormName; }
+	function setFormName($name) { $this->form_name = $name; }
+	function getFormName()	{ return $this->form_name; }
 	
-	function setValue($value)	{ $this->mValue = $value;}
-	function getValue() { return $this->mValue; }
+	function setValue($value) { $this->value = $value;}
+	function getValue() { return $this->value; }
 	
-	function setValueSafe($value)	{ $this->mValue = $value;}
-	function getValueSafe() { return $this->mValue; }
+	function setValueSafe($value) { $this->value = $value;}
+	function getValueSafe() { return $this->value; }
 
-	function setId($id)	{ $this->mId = $id;	}
-	function getId() { return $this->mId; }
+	function setId($id) { $this->id = $id;	}
+	function getId() { return $this->id; }
 	
-	function setSize($value)	{ $this->mSize = $value; }
-	function getSize() { return $this->mSize; }
+	function setSize($value) { $this->size = $value; }
+	function getSize() { return $this->size; }
 
 	function setLabel($label)	{ $this->mLabel = $label; }
 	function getLabel() { return $this->mLabel; }
 	
-	function setMaxLength($value)	{ $this->mMaxLength = $value; }
-	function getMaxLength() { return $this->mMaxLength; }
-	
-	function setTabindex($value)	{ $this->mTabindex = $value; }
-	function getTabindex() { return $this->mTabindex; }
-	
-	function setAccesskey($value)	{ $this->mAccesskey = $value; }
-	function getAccesskey() { return $this->mAccesskey; }
+	function setMaxLength($value) { $this->max_length = $value; }
+	function getMaxLength() { return $this->max_length; }
 
 	function setStyle($value)	{ $this->mStyle = $value; }
 	function getStyle() { return $this->mStyle; }
@@ -91,9 +85,8 @@ class FormElement {
 	function setEnable($flag)	{ $this->mEnabled = $flag;	}
 	function isEnable()	{ return $this->mEnabled; }
 	
-	function setOnChange($str)	{ $this->mOnChange = $str; }
-	function setOnClick($str)	{ $this->mOnClick = $str; }
-	function setOnSelect($str)	{ $this->mOnSelect = $str; }
+	function setOnChange($str) { $this->on_change = $str; }
+	function setOnClick($str) { $this->on_click = $str; }
 
 	function setLocalization($i18n)	{
 		$this->mI18n = $i18n;
@@ -104,7 +97,7 @@ class FormElement {
 	}
 	
 	function toStringLabel() {
-	    return "<label for=\"" . $this->mId . "\">" . $this->mLabel . "</label>";
+	    return "<label for=\"" . $this->id . "\">" . $this->mLabel . "</label>";
 	}
 	
 	function toArray() {