X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/timetracker.git/blobdiff_plain/fd0872d9e582113346fa1e93557f370286c5c9f2..11868a92089a10db070993b89e595f45fac3f6ff:/mobile/time_delete.php diff --git a/mobile/time_delete.php b/mobile/time_delete.php index 33ba6146..f5305bc6 100644 --- a/mobile/time_delete.php +++ b/mobile/time_delete.php @@ -32,17 +32,20 @@ import('ttUserHelper'); import('ttTimeHelper'); import('DateAndTime'); -// Access check. +// Access checks. if (!ttAccessAllowed('track_own_time')) { header('Location: access_denied.php'); exit(); } - -$cl_id = $request->getParameter('id'); -$time_rec = ttTimeHelper::getRecord($cl_id, $user->getActiveUser()); - -// Prohibit deleting invoiced records. -if ($time_rec['invoice_id']) die($i18n->get('error.sys')); +$cl_id = (int)$request->getParameter('id'); +$user_id = $user->getUser(); +$time_rec = ttTimeHelper::getRecord($cl_id, $user_id); +if (!$time_rec || $time_rec['invoice_id']) { + // Prohibit deleting not ours or invoiced records. + header('Location: access_denied.php'); + exit(); +} +// End of access checks. // Escape comment for presentation. $time_rec['comment'] = htmlspecialchars($time_rec['comment']); @@ -60,11 +63,8 @@ if ($request->isPost()) { $err->add($i18n->get('error.range_locked')); if ($err->no()) { - // Delete the record. - $result = ttTimeHelper::delete($cl_id, $user->getActiveUser()); - - if ($result) { + if (ttTimeHelper::delete($cl_id, $user_id)) { header('Location: time.php'); exit(); } else {