From: Kim Keown <kimkeown@users.noreply.github.com>
Date: Sun, 16 Oct 2016 21:42:38 +0000 (-0600)
Subject: Expense Item description - Follow-up to pull request #22 (#23)
X-Git-Tag: timetracker_1.19-1~1628
X-Git-Url: http://wagnertech.de/gitweb/gitweb.cgi/timetracker.git/commitdiff_plain/55e76bcb802e12987d7afa9a79fcf37eaec0d746?hp=55e76bcb802e12987d7afa9a79fcf37eaec0d746

Expense Item description - Follow-up to pull request #22 (#23)

* mysql.sql suggested revision Line 330

Follow-up for pull request #22: $cl_item_name for expenses.php and expense_edit.php was changed to textarea to allow a larger expense description input area. However, database input size had been overlooked and was fortunately noticed upon review.

Updated revision of mysql.sql to replace varchar(255) with a text property to allow a detailed description of the expense.

Line 330
  `name` text NOT NULL,                # expense item name (what is an expense for)

* dbinstall.php revision Line 612

Follow-up to pull request #22:
Previously expenses.php and expense_edit.php $cl_item_name field was revised to 'textarea' to provide a larger input box and longer description of the expense.
However, database character allowance had been overlooked and was fortunately noticed upon review.

- Update mysql.sql to replace varchar(255) with the 'text' property to increase allowable entry length.
Limit character input via expenses.php and expense_edit.php $cl_item_name textarea 'maxlength'.

- Update dbinstall.php with an identical revision.
Line 612
   Original: `name` varchar(255) NOT NULL,
    `name` text NOT NULL,

* mysql.sql revision Line 330

Follow-up to pull request #22:
Previously expenses.php and expense_edit.php $cl_item_name field was revised to 'textarea' to provide a larger input box and longer description of the expense. However, database character allowance had been overlooked and was fortunately noticed upon review.

- Update mysql.sql to replace tt_expense_items 'name' property varchar(255) with the text property to increase allowable entry length.
Limit character input via expenses.php and expense_edit.php $cl_item_name textarea 'maxlength'. Update dbinstall.php with an identical revision.

Line 330
(Original:  `name` varchar(255) NOT NULL,)
`name` text NOT NULL,

*  expense_edit.php revision Line 122

Follow-up to pull request #22:
Previously expenses.php and expense_edit.php $cl_item_name field was revised to 'textarea' to provide a larger input box and longer expense description. However, database character allowance had been overlooked and was fortunately noticed upon review. Accordingly, the textarea maxlength revision was removed.

- Update mysql.sql to replace tt_expense_items 'name' property varchar(255) with the text property to increase allowable entry length.
- Update dbinstall.php with an identical revision.

 - Update expenses.php and expense_edit.php $cl_item_name textarea to include a maxlength property of 800 characters.
The expense record is useful for recording any added debit or fixed-rate charge, and a generous character limit will allow a detailed description that can be easily understood in billing logs and reports.

Line 122
Original:
$form->addInput(array('type'=>'textarea', 'name'=>'item_name','style'=>'width: 250px; height:'.NOTE_INPUT_HEIGHT.'px;','value'=>$cl_item_name));

Revised:
$form->addInput(array('type'=>'textarea','maxlength'=>'800','name'=>'item_name','style'=>'width: 250px; height:'.NOTE_INPUT_HEIGHT.'px;','value'=>$cl_item_name));

*  expenses.php revision Line 130

Follow-up to pull request #22:
Previously expenses.php and expense_edit.php $cl_item_name field was revised to 'textarea' to provide a larger input box and longer expense description. However, database character allowance had been overlooked and was fortunately noticed upon review. Accordingly, the textarea maxlength revision was removed.

- Update mysql.sql to replace tt_expense_items 'name' property varchar(255) with the text property to increase allowable entry length.
- Update dbinstall.php with an identical revision.

 - Update expenses.php and expense_edit.php $cl_item_name textarea to include a maxlength property of 800 characters.
The expense record is useful for recording any added debit or fixed-rate charge, and a generous character limit will allow for a detailed description that can be easily understood within billing logs and reports.

Line 130
Original:
$form->addInput(array('type'=>'textarea', 'name'=>'item_name','style'=>'width: 250px; height:'.NOTE_INPUT_HEIGHT.'px;','value'=>$cl_item_name));

Revised:
$form->addInput(array('type'=>'textarea','maxlength'=>'800','name'=>'item_name','style'=>'width: 250px; height:'.NOTE_INPUT_HEIGHT.'px;','value'=>$cl_item_name));
---